Skip to content

Commit 7a24de9

Browse files
committed
remove unnecessary track definitions
Signed-off-by: Danju Visvanathan <danju.visvanathan@gmail.com>
1 parent 7780fa4 commit 7a24de9

3 files changed

Lines changed: 0 additions & 12 deletions

File tree

openfeature/client.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -970,9 +970,6 @@ def track(
970970
:param tracking_event_details: Optional data relevant to the tracking event
971971
"""
972972

973-
if not hasattr(self.provider, "track"):
974-
return
975-
976973
if evaluation_context is None:
977974
evaluation_context = EvaluationContext()
978975

openfeature/provider/no_op_provider.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,3 @@ def resolve_object_details(
8383
reason=Reason.DEFAULT,
8484
variant=PASSED_IN_DEFAULT,
8585
)
86-
87-
def track(
88-
self,
89-
tracking_event_name: str,
90-
evaluation_context: EvaluationContext | None = None,
91-
tracking_event_details: TrackingEventDetails | None = None,
92-
) -> None:
93-
pass

tests/test_client.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -663,7 +663,6 @@ def test_tracking_merges_evaluation_contexts():
663663

664664
def test_should_noop_if_provider_does_not_support_tracking(monkeypatch):
665665
provider = NoOpProvider()
666-
monkeypatch.delattr(NoOpProvider, "track", False)
667666
set_provider(provider)
668667
client = get_client()
669668
client.track(tracking_event_name="test")

0 commit comments

Comments
 (0)