Skip to content

Commit 86d8421

Browse files
committed
address feedback
Signed-off-by: Matthew Keeler <mkeeler@launchdarkly.com>
1 parent 58d5551 commit 86d8421

1 file changed

Lines changed: 11 additions & 22 deletions

File tree

tests/provider/test_registry.py

Lines changed: 11 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
from unittest.mock import Mock
22

3+
import pytest
4+
35
from openfeature.exception import GeneralError
46
from openfeature.provider._registry import ProviderRegistry
57
from openfeature.provider.no_op_provider import NoOpProvider
@@ -15,27 +17,19 @@ def test_registry_serves_noop_as_default():
1517
def test_setting_provider_requires_domain():
1618
registry = ProviderRegistry()
1719

18-
try:
20+
with pytest.raises(GeneralError) as exc_info:
1921
registry.set_provider(None, NoOpProvider()) # type: ignore[reportArgumentType]
20-
raise AssertionError(
21-
"Expected an exception when setting provider with None domain"
22-
)
23-
except GeneralError as e:
24-
assert e.error_message == "No domain"
25-
except Exception as e:
26-
raise AssertionError("Expected GeneralError, got {type(e)}") from e
22+
23+
assert exc_info.value.error_message == "No domain"
2724

2825

2926
def test_setting_provider_requires_provider():
3027
registry = ProviderRegistry()
3128

32-
try:
29+
with pytest.raises(GeneralError) as exc_info:
3330
registry.set_provider("domain", None) # type: ignore[reportArgumentType]
34-
raise AssertionError("Expected an exception when setting provider to None")
35-
except GeneralError as e:
36-
assert e.error_message == "No provider"
37-
except Exception as e:
38-
raise AssertionError("Expected GeneralError, got {type(e)}") from e
31+
32+
assert exc_info.value.error_message == "No provider"
3933

4034

4135
def test_can_register_provider_to_multiple_domains():
@@ -81,15 +75,10 @@ def test_registering_provider_for_first_time_initializes_it():
8175
def test_setting_default_provider_requires_provider():
8276
registry = ProviderRegistry()
8377

84-
try:
78+
with pytest.raises(GeneralError) as exc_info:
8579
registry.set_default_provider(None) # type: ignore[reportArgumentType]
86-
raise AssertionError(
87-
"Expected an exception when setting default provider to None"
88-
)
89-
except GeneralError as e:
90-
assert e.error_message == "No provider"
91-
except Exception as e:
92-
raise AssertionError("Expected GeneralError, got {type(e)}") from e
80+
81+
assert exc_info.value.error_message == "No provider"
9382

9483

9584
def test_replacing_default_provider_shuts_down_old_one():

0 commit comments

Comments
 (0)