refactor: Delete provider status instead of marking as NOT_READY

Once a provider has been removed, there is no value in retaining a
reference to it in the `_provider_status` dictionary. Instead of
explicitly setting the status as `NOT_READY`, we can rely on this being
the default status served from the `get_provider_status` method,
allowing us to remove the dictionary entry entirely.

Signed-off-by: Matthew Keeler <mkeeler@launchdarkly.com>

Author: keelerm84

openfeature/provider/_registry.py

@@ -102,7 +102,7 @@ def _shutdown_provider(self, provider: FeatureProvider) -> None:
         try:
             if hasattr(provider, "shutdown"):
                 provider.shutdown()
-            self._provider_status[provider] = ProviderStatus.NOT_READY
+            del self._provider_status[provider]
         except Exception as err:
             self.dispatch_event(
                 provider,

tests/provider/test_registry.py

@@ -1,6 +1,7 @@
 from unittest.mock import Mock
 
 from openfeature.exception import GeneralError
+from openfeature.provider import ProviderStatus
 from openfeature.provider._registry import ProviderRegistry
 from openfeature.provider.no_op_provider import NoOpProvider
 
@@ -172,3 +173,69 @@ def test_replacing_default_provider_used_as_domain_does_not_shutdown():
 
     provider1.shutdown.assert_not_called()
     provider2.shutdown.assert_not_called()
+
+
+def test_shutting_down_registry_shuts_down_providers_once():
+    """Test that shutting down the registry shuts down each provider only once."""
+
+    registry = ProviderRegistry()
+    provider1 = Mock()
+    provider2 = Mock()
+
+    registry.set_default_provider(provider1)
+    registry.set_provider("domain1", provider1)
+
+    registry.set_provider("domain2a", provider2)
+    registry.set_provider("domain2b", provider2)
+
+    registry.shutdown()
+
+    provider1.shutdown.assert_called_once()
+    provider2.shutdown.assert_called_once()
+
+
+def test_initializing_provider_sets_status_ready():
+    """Test that initializing a provider sets its status to READY."""
+
+    registry = ProviderRegistry()
+    provider = Mock()
+
+    assert registry.get_provider_status(provider) == ProviderStatus.NOT_READY
+
+    registry.set_provider("domain", provider)
+
+    provider.initialize.assert_called_once()
+    assert registry.get_provider_status(provider) == ProviderStatus.READY
+
+
+def test_shutting_down_provider_sets_status_not_ready():
+    """Test that shutting down a provider sets its status to NOT_READY."""
+
+    registry = ProviderRegistry()
+    provider = Mock()
+
+    registry.set_provider("domain", provider)
+    assert registry.get_provider_status(provider) == ProviderStatus.READY
+
+    registry.shutdown()
+    assert registry.get_provider_status(provider) == ProviderStatus.NOT_READY
+
+
+def test_clearing_registry_resets_providers_and_default():
+    """Test that clearing the registry resets all providers and the default provider."""
+
+    registry = ProviderRegistry()
+    provider = Mock()
+
+    registry.set_provider("domain", provider)
+    registry.set_default_provider(provider)
+
+    registry.clear_providers()
+
+    default_provider = registry.get_default_provider()
+    assert isinstance(default_provider, NoOpProvider)
+    assert registry.get_provider("domain") is default_provider
+    assert registry.get_provider_status(default_provider) == ProviderStatus.READY
+
+    provider.initialize.assert_called_once()
+    provider.shutdown.assert_called_once()