Refactor: Patch fixes

Author: Vlasdislav

gpcontrib/gp_url_tools/src/gp_url_tools.c

@@ -38,11 +38,6 @@ PG_FUNCTION_INFO_V1(decode_url);
 PG_FUNCTION_INFO_V1(encode_uri);
 PG_FUNCTION_INFO_V1(decode_uri);
 
-Datum url_encode(PG_FUNCTION_ARGS);
-Datum url_decode(PG_FUNCTION_ARGS);
-Datum uri_encode(PG_FUNCTION_ARGS);
-Datum uri_decode(PG_FUNCTION_ARGS);
-
 static bool allowed_character(const char c, const char *unreserved_special);
 static unsigned char char2hex(char c);
 static char *write_character(char *output, const char c);
@@ -70,7 +65,7 @@ unsigned char char2hex(char c) {
     }
     ereport(ERROR, (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
                     errmsg("invalid hexadecimal digit: \"%c\"", c)));
-    return -1;
+    pg_unreachable();
 }
 
 bool allowed_character(const char c, const char *unreserved_special) {
@@ -147,7 +142,7 @@ bool is_utf8(const char *sequence, int length) {
 // Check that sequence of bytes starts with 'symbol' in UTF-16 encoding
 //
 // UTF-16 'symbols' starts with '%u' or '%U', and 'XXXX' after it.
-// 'XXXX' - hex sequence that encode bytes (optinally sequence 'XXXX' ->
+// 'XXXX' - hex sequence that encode bytes (optionally sequence 'XXXX' ->
 // 'XXXXXXXX')
 bool is_utf16(const char *sequence, int length) {
     return 6 <= length && sequence[0] == '%' &&