Feat: Adapt gp_url_tools for Cloudberry and fix UTF-16 surrogate decoding

Author: Vlasdislav

.github/workflows/build-cloudberry-rocky8.yml

@@ -318,7 +318,8 @@ jobs:
                "make_configs":["gpcontrib/orafce:installcheck",
                                "gpcontrib/zstd:installcheck",
                                "gpcontrib/gp_sparse_vector:installcheck",
-                               "gpcontrib/gp_toolkit:installcheck"]
+                               "gpcontrib/gp_toolkit:installcheck",
+                               "gpcontrib/gp_url_tools:installcheck"]
               },
               {"test":"ic-fixme",
                "make_configs":["src/test/regress:installcheck-fixme"],

.github/workflows/build-cloudberry.yml

@@ -312,7 +312,8 @@ jobs:
                                "gpcontrib/zstd:installcheck",
                                "gpcontrib/gp_sparse_vector:installcheck",
                                "gpcontrib/gp_toolkit:installcheck",
-                               "gpcontrib/gp_exttable_fdw:installcheck"]
+                               "gpcontrib/gp_exttable_fdw:installcheck",
+                               "gpcontrib/gp_url_tools:installcheck"]
               },
               {"test":"ic-diskquota",
                "make_configs":["gpcontrib/diskquota:installcheck"],

gpcontrib/gp_url_tools/.clang-format

@@ -6,6 +6,12 @@ TESTS        = $(wildcard test/sql/*.sql)
 REGRESS      = $(patsubst test/sql/%.sql,%,$(TESTS))
 REGRESS_OPTS = --inputdir=test
 
+ifdef USE_PGXS
 PG_CONFIG    = pg_config
 PGXS        := $(shell $(PG_CONFIG) --pgxs)
 include $(PGXS)
+else
+top_builddir = ../..
+include $(top_builddir)/src/Makefile.global
+include $(top_srcdir)/contrib/contrib-global.mk
+endif

gpcontrib/gp_url_tools/Makefile

@@ -1,45 +1,66 @@
-# gp_url_tools: Greenplum extension providing functionality for working with URL addresses
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+
+# gp_url_tools: Cloudberry extension providing functionality for working with URL addresses
 
 ### Features
-gp_url_tools is an extension for the Greenplum database that gives implementation 
+gp_url_tools is an extension for the Cloudberry database that gives implementation 
 for functions that encode/decode url/uri.
 
-### Installation
-Install from source:
-```
-git clone https://github.com/open-gpdb/gp_url_tools.git
-cd gp_url_tools
-# Build it. Building would require GP installed nearby and sourcing greenplum_path.sh
-source <path_to_gp>/greenplum_path.sh
-make && make install
-```
-
 ### Usage
+```sql
+CREATE EXTENSION gp_url_tools;
 ```
-=# create extension gp_url_tools;
-
-=# select url_tools_schema.encode_url('Hello World');
+```sql
+SELECT url_tools_schema.encode_url('Hello World');
+```
+```bash
   encode_url
 ───────────────
  Hello%20World
 (1 row)
-
-=# select url_tools_schema.decode_url('Hello%20World');
+```
+```sql
+SELECT url_tools_schema.decode_url('Hello%20World');
+```
+```bash
  decode_url  
 ─────────────
  Hello World
 (1 row)
-
-=# select url_tools_schema.encode_uri('https://ru.wikipedia.org/wiki/Greenplum_(компания)');
+```
+```sql
+SELECT url_tools_schema.encode_uri('https://ru.wikipedia.org/wiki/Greenplum_(компания)');
+```
+```bash
                                          encode_uri                  
 ────────────────────────────────────────────────────────────────────────────────────────────
  https://ru.wikipedia.org/wiki/Greenplum_(%D0%BA%D0%BE%D0%BC%D0%BF%D0%B0%D0%BD%D0%B8%D1%8F)
-
-=# select url_tools_schema.decode_uri('https://ru.wikipedia.org/wiki/Greenplum_(%D0%BA%D0%BE%D0%BC%D0%BF%D0%B0%D0%BD%D0%B8%D1%8F)');
+```
+```sql
+SELECT url_tools_schema.decode_uri('https://ru.wikipedia.org/wiki/Greenplum_(%D0%BA%D0%BE%D0%BC%D0%BF%D0%B0%D0%BD%D0%B8%D1%8F)');
+```
+```bash
                      decode_uri               
 ────────────────────────────────────────────────────
  https://ru.wikipedia.org/wiki/Greenplum_(компания)
 ```
 
 ### Acknowledgments
-Thank you very much for the extension for postgrsql: https://github.com/okbob/url_encode, its sources were very useful.
+Thank you very much for the extension for PostgreSQL: https://github.com/okbob/url_encode, its sources were very useful.

gpcontrib/gp_url_tools/README.md

@@ -1,5 +1,5 @@
 # gp_url_tools extension
-comment = 'Greenplum extension providing functionality for working with URL addresses'
+comment = 'Functions for working with URL-s'
 default_version = '1.0'
 module_pathname = '$libdir/gp_url_tools'
 relocatable = true

gpcontrib/gp_url_tools/gp_url_tools.control

@@ -4,6 +4,7 @@
 \echo Use "CREATE EXTENSION gp_url_tools" to load this file. \quit
 
 CREATE SCHEMA IF NOT EXISTS url_tools_schema;
+GRANT USAGE ON SCHEMA url_tools_schema TO public;
 
 CREATE FUNCTION url_tools_schema.encode_url(text)
 RETURNS text
@@ -24,4 +25,3 @@ CREATE FUNCTION url_tools_schema.decode_uri(text)
 RETURNS text
 AS 'MODULE_PATHNAME', 'decode_uri'
 LANGUAGE C IMMUTABLE STRICT;
-