[gp_stats_collector] Disable via GUC

Now gp_stats_collector is built by default in gpdb-devops [0]
similarly to Cloudberry [1], so disable via GUC.

[0] open-gpdb/gpdb-devops@64b1cb9
[1] apache/cloudberry@7e12a93

Author: NJrslv

.github/workflows/build-gpdb.yml

@@ -53,7 +53,7 @@ jobs:
             },
             {
               "name": "test",
-              "extra_configure_flags": "--enable-debug-extensions --enable-tap-tests --with-gp-stats-collector"
+              "extra_configure_flags": "--enable-debug-extensions --enable-tap-tests"
             }
           ]}'
           # Output the matrix for GitHub Actions
@@ -1189,7 +1189,7 @@ jobs:
           # set env for debian build
           export BUILD_DESTINATION=/opt/greenplum-db-6
 
-          if ! su - gpadmin -c "cd ${SRC_DIR} && ./configure --with-perl --with-python --with-libxml --enable-mapreduce --with-gssapi  --prefix=${BUILD_DESTINATION} --with-ldap --enable-gpperfmon --with-pam --with-openssl --disable-pxf --enable-ic-proxy  --enable-orafce --without-mdblocales --with-zstd --enable-tap-tests --with-gp-stats-collector"; then
+          if ! su - gpadmin -c "cd ${SRC_DIR} && ./configure --with-perl --with-python --with-libxml --enable-mapreduce --with-gssapi  --prefix=${BUILD_DESTINATION} --with-ldap --enable-gpperfmon --with-pam --with-openssl --disable-pxf --enable-ic-proxy  --enable-orafce --without-mdblocales --with-zstd --enable-tap-tests"; then
             echo "::error::Configure script failed"
             exit 1
           fi

gpcontrib/gp_stats_collector/src/Config.cpp

@@ -13,7 +13,7 @@ extern "C" {
 static char *guc_uds_path = nullptr;
 static bool guc_enable_analyze = true;
 static bool guc_enable_cdbstats = true;
-static bool guc_enable_collector = true;
+static bool guc_enable_collector = false;
 static bool guc_report_nested_queries = true;
 static char *guc_ignored_users = nullptr;
 static int guc_max_text_size = 1 << 20;	  // in bytes (1MB)
@@ -45,7 +45,7 @@ Config::init_gucs()
 
 	DefineCustomBoolVariable(
 		"gpsc.enable", "Enable metrics collector", 0LL, &guc_enable_collector,
-		true, PGC_SUSET, GUC_NOT_IN_SAMPLE | GUC_GPDB_NEED_SYNC, 0LL, 0LL, 0LL);
+		false, PGC_SUSET, GUC_NOT_IN_SAMPLE | GUC_GPDB_NEED_SYNC, 0LL, 0LL, 0LL);
 
 	DefineCustomBoolVariable(
 		"gpsc.enable_analyze", "Collect analyze metrics in gpsc", 0LL,
@@ -65,7 +65,7 @@ Config::init_gucs()
 	DefineCustomStringVariable("gpsc.ignored_users_list",
 							   "Make gpsc ignore queries issued by given users",
 							   0LL, &guc_ignored_users,
-							   "gpadmin,repl,gpperfmon,monitor", PGC_SUSET,
+							   "", PGC_SUSET,
 							   GUC_NOT_IN_SAMPLE | GUC_GPDB_NEED_SYNC, 0LL,
 							   assign_ignored_users_hook, 0LL);