Fixes #29873: refactor(ingestion): migrate Tableau test-connection to declarative framework (#29886)

* Fixes #29873: refactor(ingestion): migrate Tableau test-connection to declarative framework

Replace the imperative test_connection_steps handler with a TableauChecks
provider: one @check per step returning Evidence, and a TABLEAU_ERRORS
ErrorPack that maps HTTP 401/403/404, TLS failures and the Tableau-specific
exceptions to actionable diagnoses, folding in the shared network pack.

ServerInfo becomes the ConnectionGate step so a bad server URL or PAT
short-circuits the remaining steps instead of re-dialling the host for each.

* refactor(ingestion): lean 401 remediation for Tableau test-connection

* refactor(ingestion): scope Tableau _status_of to known HTTP-bearing error types

* refactor(ingestion): preserve Tableau's 3-minute test-connection timeout

Author: IceS2

ingestion/src/metadata/core/connections/test_connection/checks/dashboard.py

@@ -22,14 +22,16 @@
 
 from __future__ import annotations
 
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, TypeVar
 
 from metadata.core.connections.test_connection.check import CheckError, StepName
 from metadata.core.connections.test_connection.records import Diagnosis, Evidence
 
 if TYPE_CHECKING:
     from collections.abc import Callable, Sized
 
+_T = TypeVar("_T")
+
 
 # A check only needs to prove the list endpoint is reachable and returns items,
 # not enumerate every one, so ``fetch_list`` counts at most this many and renders
@@ -43,6 +45,13 @@ class DashboardStep(StepName):
 
     CheckAccess = "CheckAccess"
     GetDashboards = "GetDashboards"
+    ServerInfo = "ServerInfo"
+    ValidateApiVersion = "ValidateApiVersion"
+    ValidateSiteUrl = "ValidateSiteUrl"
+    GetWorkbooks = "GetWorkbooks"
+    GetViews = "GetViews"
+    GetOwners = "GetOwners"
+    GetDataModels = "GetDataModels"
 
 
 def _count(number: int, noun: str, cap: int | None = None) -> str:
@@ -72,6 +81,20 @@ def verify_access(authenticate: Callable[[], object], command: str) -> Evidence:
     return Evidence(summary="authenticated", command=command)
 
 
+def call_endpoint(call: Callable[[], _T], command: str) -> _T:
+    """Call a REST endpoint and hand its result back to the check.
+
+    For steps whose evidence is not a count: the check summarizes the returned
+    value itself (an API version, a resolved owner). On failure, re-raise as
+    ``CheckError`` carrying the attempted command so the failed step still
+    reports what it ran.
+    """
+    try:
+        return call()
+    except Exception as cause:
+        raise CheckError(cause, Evidence(command=command)) from cause
+
+
 def fetch_list(
     fetch: Callable[[], Sized | None],
     noun: str,

ingestion/src/metadata/ingestion/source/dashboard/tableau/client.py

@@ -14,10 +14,9 @@
 
 import math
 import traceback
-from typing import Callable, Dict, Iterable, List, Optional, Tuple, Union  # noqa: UP035
+from typing import Dict, Iterable, List, Optional, Tuple, Union  # noqa: UP035
 
 import validators
-from cached_property import cached_property
 from tableauserverclient import (
     Pager,
     PersonalAccessTokenAuth,
@@ -96,9 +95,8 @@ def __init__(
         self.all_projects: List[ProjectItem] = []  # noqa: UP006
         self.ssl_manager = ssl_manager
 
-    @cached_property
-    def server_info(self) -> Callable:
-        return self.tableau_server.server_info.get
+    def server_info(self):
+        return self.tableau_server.server_info.get()
 
     def server_api_version(self) -> str:
         return self.tableau_server.version