Skip to content

Commit 11df810

Browse files
committed
fix: address bot feedback on AWS Secrets Manager and unused Java imports
1 parent ba1bcfc commit 11df810

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

ingestion/src/metadata/utils/secrets/aws_secrets_manager.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@
1717

1818
from botocore.exceptions import ClientError
1919

20+
from metadata.generated.schema.security.secrets.secretsManagerClientLoader import (
21+
SecretsManagerClientLoader,
22+
)
23+
from metadata.generated.schema.security.secrets.secretsManagerProvider import (
24+
SecretsManagerProvider,
25+
)
2026
from metadata.utils.secrets.aws_based_secrets_manager import (
2127
AWSBasedSecretsManager,
2228
NULL_VALUE,
@@ -31,6 +37,13 @@ class AWSSecretsManager(AWSBasedSecretsManager):
3137
AWS Secrets Manager
3238
"""
3339

40+
def __init__(self, loader: SecretsManagerClientLoader):
41+
super().__init__(
42+
client="secretsmanager",
43+
provider=SecretsManagerProvider.aws,
44+
loader=loader,
45+
)
46+
3447
def get_string_value(self, secret_id: str) -> Optional[str]: # noqa: UP045
3548
"""
3649
Get the secret value as a string

openmetadata-integration-tests/src/test/java/org/openmetadata/it/factories/SearchServiceTestFactory.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import org.openmetadata.schema.api.services.CreateSearchService;
88
import org.openmetadata.schema.api.services.CreateSearchService.SearchServiceType;
99
import org.openmetadata.schema.entity.services.SearchService;
10-
import org.openmetadata.schema.security.ssl.VerifySSL;
1110
import org.openmetadata.schema.services.connections.search.ElasticSearchConnection;
1211
import org.openmetadata.schema.services.connections.search.OpenSearchConnection;
1312
import org.openmetadata.schema.type.SearchConnection;

0 commit comments

Comments
 (0)