refactor: centralize time-series deletion skip logic and avoid raw string literals

Author: Megh-Shah-08

openmetadata-service/src/main/java/org/openmetadata/service/Entity.java

@@ -744,11 +744,15 @@ public static boolean isTimeSeriesEntity(String entityType) {
     return ENTITY_TS_REPOSITORY_MAP.containsKey(entityType);
   }
 
+  public static boolean shouldSkipTimeSeriesDelete(String entityType) {
+    return entityType.equalsIgnoreCase(Entity.TEST_CASE_RESOLUTION_STATUS)
+        || entityType.equalsIgnoreCase(Entity.TEST_CASE_RESULT);
+  }
+
   public static void deleteEntity(
       String updatedBy, String entityType, UUID entityId, boolean recursive, boolean hardDelete) {
     if (isTimeSeriesEntity(entityType)) {
-      if (entityType.equalsIgnoreCase(Entity.TEST_CASE_RESOLUTION_STATUS)
-          || entityType.equalsIgnoreCase(Entity.TEST_CASE_RESULT)) {
+      if (shouldSkipTimeSeriesDelete(entityType)) {
         LOG.debug(
             "Skipping delete for time-series entity {} with id {} (handled via cleanup)",
             entityType,

openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/dataRetention/DataRetention.java

@@ -263,7 +263,9 @@ private void cleanOrphanedTestCaseResolutionStatusRelationships() {
             collectionDAO
                 .relationshipDAO()
                 .deleteOrphanedRelationships(
-                    Entity.TEST_CASE, Entity.TEST_CASE_RESOLUTION_STATUS, "test_case"));
+                    Entity.TEST_CASE,
+                    Entity.TEST_CASE_RESOLUTION_STATUS,
+                    collectionDAO.testCaseDAO().getTableName()));
     LOG.info("TestCaseResolutionStatus orphaned relationships cleanup complete.");
   }
 

openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java

@@ -4372,8 +4372,7 @@ protected void batchDeleteChildren(
   private void processDeletionBatch(
       List<UUID> entityIds, String entityType, boolean hardDelete, String updatedBy) {
     if (Entity.isTimeSeriesEntity(entityType)) {
-      if (entityType.equalsIgnoreCase(Entity.TEST_CASE_RESOLUTION_STATUS)
-          || entityType.equalsIgnoreCase(Entity.TEST_CASE_RESULT)) {
+      if (Entity.shouldSkipTimeSeriesDelete(entityType)) {
         LOG.debug(
             "Skipping batch delete for time-series entity {} (handled via cleanup)", entityType);
         return;