Remove * callsites (#28151)

(cherry picked from commit 71893d5)

Author: mohityadav766

openmetadata-service/src/main/java/org/openmetadata/service/apps/ApplicationContext.java

@@ -45,7 +45,7 @@ public static void initialize() {
         appRepo
             .listAfter(
                 null,
-                appRepo.getFields("*"),
+                appRepo.getFields("pipelines"),
                 listFilter,
                 appRepo.getDao().listCount(listFilter),
                 "")

openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/insights/workflows/costAnalysis/CostAnalysisWorkflow.java

@@ -102,7 +102,7 @@ public CostAnalysisWorkflow(
 
   private void initialize() throws SearchIndexException {
     PaginatedEntitiesSource databaseServices =
-        new PaginatedEntitiesSource(Entity.DATABASE_SERVICE, batchSize, List.of("*"));
+        new PaginatedEntitiesSource(Entity.DATABASE_SERVICE, batchSize, List.of());
     int total = 0;
 
     String keysetCursor = null;
@@ -117,7 +117,8 @@ private void initialize() throws SearchIndexException {
           filter.addQueryParam("database", databaseService.getFullyQualifiedName());
 
           sources.add(
-              new PaginatedEntitiesSource(Entity.TABLE, batchSize, List.of("*"), filter)
+              new PaginatedEntitiesSource(
+                      Entity.TABLE, batchSize, List.of(Entity.FIELD_LIFE_CYCLE), filter)
                   .withName(
                       String.format(
                           "[CostAnalysisWorkflow] %s", databaseService.getFullyQualifiedName())));

openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/insights/workflows/dataAssets/DataAssetsWorkflow.java

@@ -5,6 +5,7 @@
 import static org.openmetadata.service.apps.bundles.insights.utils.TimestampUtils.START_TIMESTAMP_KEY;
 import static org.openmetadata.service.workflows.searchIndex.ReindexingUtil.ENTITY_TYPE_KEY;
 import static org.openmetadata.service.workflows.searchIndex.ReindexingUtil.getInitialStatsForEntities;
+import static org.openmetadata.service.workflows.searchIndex.ReindexingUtil.getSearchIndexFields;
 
 import java.util.ArrayList;
 import java.util.Collections;
@@ -139,7 +140,7 @@ private void initialize() {
                     || entityTypesToProcess.contains(entityType))
         .forEach(
             entityType -> {
-              List<String> fields = List.of("*");
+              List<String> fields = getSearchIndexFields(entityType);
               ListFilter filter = getListFilter(entityType);
               PaginatedEntitiesSource source =
                   new PaginatedEntitiesSource(entityType, batchSize, fields, filter)

openmetadata-service/src/main/java/org/openmetadata/service/governance/workflows/elements/nodes/automatedTask/impl/CheckChangeDescriptionTaskImpl.java

@@ -55,7 +55,7 @@ public void execute(DelegateExecution execution) {
   private boolean checkChangeDescription(DelegateExecution execution, String entityLinkStr) {
     // Parse entity
     MessageParser.EntityLink entityLink = MessageParser.EntityLink.parse(entityLinkStr);
-    EntityInterface entity = Entity.getEntity(entityLink, "*", Include.ALL);
+    EntityInterface entity = Entity.getEntity(entityLink, "", Include.ALL);
 
     // No changeDescription means it's a create event - return true
     ChangeDescription changeDescription = entity.getChangeDescription();

openmetadata-service/src/main/java/org/openmetadata/service/governance/workflows/elements/nodes/automatedTask/impl/RollbackEntityImpl.java

@@ -61,7 +61,7 @@ public void execute(DelegateExecution execution) {
         updatedBy = "governance-bot";
       }
 
-      EntityInterface currentEntity = Entity.getEntity(entityLink, "*", Include.ALL);
+      EntityInterface currentEntity = Entity.getEntity(entityLink, "", Include.ALL);
 
       String entityType = currentEntity.getEntityReference().getType();
       UUID entityId = currentEntity.getId();

openmetadata-service/src/main/java/org/openmetadata/service/governance/workflows/elements/nodes/automatedTask/impl/SetEntityCertificationImpl.java

@@ -43,7 +43,7 @@ public void execute(DelegateExecution execution) {
                   varHandler.getNamespacedVariable(
                       inputNamespaceMap.get(RELATED_ENTITY_VARIABLE), RELATED_ENTITY_VARIABLE));
       String entityType = entityLink.getEntityType();
-      EntityInterface entity = Entity.getEntity(entityLink, "*", Include.ALL);
+      EntityInterface entity = Entity.getEntity(entityLink, "certification", Include.ALL);
 
       String certification =
           Optional.ofNullable(certificationExpr)

openmetadata-service/src/main/java/org/openmetadata/service/governance/workflows/elements/nodes/automatedTask/impl/SetGlossaryTermStatusImpl.java

@@ -41,7 +41,7 @@ public void execute(DelegateExecution execution) {
               (String)
                   varHandler.getNamespacedVariable(
                       inputNamespaceMap.get(RELATED_ENTITY_VARIABLE), RELATED_ENTITY_VARIABLE));
-      GlossaryTerm glossaryTerm = Entity.getEntity(entityLink, "*", Include.ALL);
+      GlossaryTerm glossaryTerm = Entity.getEntity(entityLink, "", Include.ALL);
 
       String status = (String) statusExpr.getValue(execution);
       String user =

openmetadata-service/src/main/java/org/openmetadata/service/governance/workflows/elements/nodes/automatedTask/sink/SinkTaskDelegate.java

@@ -36,6 +36,7 @@
 import org.openmetadata.service.Entity;
 import org.openmetadata.service.governance.workflows.WorkflowVariableHandler;
 import org.openmetadata.service.resources.feeds.MessageParser;
+import org.openmetadata.service.workflows.searchIndex.ReindexingUtil;
 
 /**
  * Flowable delegate that executes sink operations within a workflow.
@@ -239,7 +240,10 @@ BatchAccumulator merge(SinkResult result, List<SinkResult.SinkError> fetchErrors
                   for (String entityLinkStr : subBatch) {
                     try {
                       var entityLink = MessageParser.EntityLink.parse(entityLinkStr);
-                      entities.add(Entity.getEntity(entityLink, "*", Include.ALL));
+                      String fields =
+                          String.join(
+                              ",", ReindexingUtil.getSearchIndexFields(entityLink.getEntityType()));
+                      entities.add(Entity.getEntity(entityLink, fields, Include.ALL));
                     } catch (Exception e) {
                       LOG.error("Failed to fetch entity: {}", entityLinkStr, e);
                       fetchErrors.add(
@@ -288,7 +292,9 @@ private SinkResult executeSingleEntityMode(
         (String) varHandler.getNamespacedVariable(relatedEntityNamespace, RELATED_ENTITY_VARIABLE);
 
     MessageParser.EntityLink entityLink = MessageParser.EntityLink.parse(relatedEntityValue);
-    EntityInterface entity = Entity.getEntity(entityLink, "*", Include.ALL);
+    String fields =
+        String.join(",", ReindexingUtil.getSearchIndexFields(entityLink.getEntityType()));
+    EntityInterface entity = Entity.getEntity(entityLink, fields, Include.ALL);
 
     LOG.info(
         "[{}] Executing single entity sink for: {}",

openmetadata-service/src/main/java/org/openmetadata/service/search/SearchIndexRetryWorker.java

@@ -384,7 +384,8 @@ private void reindexEntityCascade(EntityReference root) throws Exception {
 
       EntityInterface entity;
       try {
-        entity = Entity.getEntity(current, "*", Include.ALL);
+        String fields = String.join(",", ReindexingUtil.getSearchIndexFields(current.getType()));
+        entity = Entity.getEntity(current, fields, Include.ALL);
       } catch (Exception ex) {
         continue;
       }