Skip to content

Commit 2d23eff

Browse files
authored
Refactor:Move MUI Components from Learning player model to Untitled Core Components (#29550)
* Refactor:Move MUI Components from Learning player model to Untitled Core Components * nit * fix playwright test failure
1 parent 5b39da0 commit 2d23eff

4 files changed

Lines changed: 189 additions & 306 deletions

File tree

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/LearningResources.spec.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ test.describe(
196196
}) => {
197197
await test.step('Click row and verify player modal opens', async () => {
198198
await page.getByText('Collate Clues: Automations').click();
199-
const dialog = page.getByRole('dialog');
199+
const dialog = page.getByTestId('resource-player-dialog');
200200
await expect(dialog).toBeVisible();
201201
await expect(
202202
dialog.getByText('Collate Clues: Automations')
@@ -205,7 +205,9 @@ test.describe(
205205

206206
await test.step('Close preview modal', async () => {
207207
await page.getByTestId('close-resource-player').click();
208-
await expect(page.getByRole('dialog')).not.toBeVisible();
208+
await expect(
209+
page.getByTestId('resource-player-dialog')
210+
).not.toBeVisible();
209211
});
210212
});
211213

@@ -353,7 +355,7 @@ test.describe(
353355
await expect(resourceCard).toBeVisible();
354356
await resourceCard.click();
355357

356-
const playerDialog = page.getByRole('dialog');
358+
const playerDialog = page.getByTestId('resource-player-dialog');
357359
await expect(playerDialog).toBeVisible();
358360
await expect(
359361
playerDialog.getByText(`PW Player Resource ${uniqueId}`)

openmetadata-ui/src/main/resources/ui/src/components/Learning/Learning.interface.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
* limitations under the License.
1212
*/
1313

14+
import type { BadgeColors } from '@openmetadata/ui-core-components';
15+
1416
export type ResourceCategory =
1517
| 'Discovery'
1618
| 'Administration'
@@ -19,6 +21,15 @@ export type ResourceCategory =
1921
| 'Observability'
2022
| 'AI';
2123

24+
export const CATEGORY_BADGE_COLORS: Record<ResourceCategory, BadgeColors> = {
25+
Discovery: 'blue',
26+
Administration: 'blue-light',
27+
DataGovernance: 'indigo',
28+
DataQuality: 'orange',
29+
Observability: 'orange',
30+
AI: 'purple',
31+
};
32+
2233
export type ResourceType = 'Storylane' | 'Video' | 'Article';
2334

2435
export type ResourceDifficulty = 'Intro' | 'Intermediate' | 'Advanced';

0 commit comments

Comments
 (0)