Skip to content

Commit 330f2dc

Browse files
committed
fix(migration): drop generic exception catch + inline rule description per code review
1 parent 361a9f6 commit 330f2dc

2 files changed

Lines changed: 0 additions & 7 deletions

File tree

openmetadata-service/src/main/java/org/openmetadata/service/migration/utils/v1129/MigrationUtil.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,6 @@ public static void addTriggerRuleToDataStewardPolicy(CollectionDAO collectionDAO
7070
Rule triggerRule =
7171
new Rule()
7272
.withName("DataStewardPolicy-TriggerRule")
73-
.withDescription(
74-
"Allow data stewards to trigger ingestion pipelines. Stewards already have "
75-
+ "EditOwners on all resources and can reach trigger via an ownership "
76-
+ "rewrite; this rule makes the capability explicit for audit clarity.")
7773
.withResources(List.of("all"))
7874
.withOperations(List.of(MetadataOperation.TRIGGER))
7975
.withEffect(Rule.Effect.ALLOW);
@@ -87,8 +83,6 @@ public static void addTriggerRuleToDataStewardPolicy(CollectionDAO collectionDAO
8783
}
8884
} catch (EntityNotFoundException ex) {
8985
LOG.warn("DataStewardPolicy not found, skipping TriggerRule addition");
90-
} catch (Exception e) {
91-
LOG.error("Failed to add TriggerRule to DataStewardPolicy: {}", e.getMessage(), e);
9286
}
9387
}
9488
}

openmetadata-service/src/main/resources/json/data/policy/DataStewardPolicy.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
},
1616
{
1717
"name": "DataStewardPolicy-TriggerRule",
18-
"description": "Allow data stewards to trigger ingestion pipelines. Stewards already have EditOwners on all resources and can reach trigger via an ownership rewrite; this rule makes the capability explicit for audit clarity.",
1918
"resources": ["all"],
2019
"operations": ["Trigger"],
2120
"effect": "allow"

0 commit comments

Comments
 (0)