fix(quicksight): handle iterable _parent and fix checkstyle violation also fix bot comments

Author: mohitjeswani01

ingestion/src/metadata/ingestion/source/dashboard/quicksight/metadata.py

@@ -273,16 +273,38 @@ def _build_column_lineage_from_parser(
             src_col = col_pair[0]
             tgt_col = col_pair[-1]
 
-            # Multi-table safety: filter by parent table to avoid resolving
-            # a shared column name (e.g. 'id') to the wrong upstream table.
-            if src_col._parent:
-                # _parent may be qualified: '<default>.table' or 'schema.table'
-                parent_str = str(src_col._parent).replace("<default>.", "")
-                # Compare only the table name portion (last segment)
-                parent_table = parent_str.split(".")[-1].lower()
+            parent = getattr(src_col, "_parent", None)
+            if parent is not None:
+                # _parent may be a single Table or an iterable of Tables.
+                # Normalise to a list so we handle both cases uniformly.
+                parents = (
+                    list(parent)
+                    if hasattr(parent, "__iter__")
+                    and not isinstance(parent, str)
+                    else [parent]
+                )
                 entity_table = from_entity.name.root.lower()
-                if parent_table != entity_table:
+                # Accept the pair only when at least one parent table
+                # matches the current upstream entity being processed.
+                if not any(
+                    str(p)
+                    .replace("<default>.", "")
+                    .split(".")[-1]
+                    .lower()
+                    == entity_table
+                    for p in parents
+                ):
                     continue
+            else:
+                # _parent is None — parser could not determine source
+                # table.  Log for visibility but allow the pair through;
+                # get_column_fqn provides a secondary guard (column must
+                # exist in entity).
+                logger.debug(
+                    "No parent table info for column %s; "
+                    "skipping parent-table filter",
+                    src_col.raw_name,
+                )
 
             # raw_name may be fully-qualified (e.g. 'schema.table.col')
             # Extract just the column name portion.
@@ -306,7 +328,8 @@ def _build_column_lineage_from_parser(
                     )
             except Exception as exc:  # pylint: disable=broad-except
                 logger.debug(
-                    f"Failed to build column lineage for {src_col_name} -> {tgt_col_name}: {exc}"
+                    f"Failed to build column lineage "
+                    f"for {src_col_name} -> {tgt_col_name}: {exc}"
                 )
                 logger.debug(traceback.format_exc())
 

ingestion/tests/unit/topology/dashboard/test_quicksight.py

@@ -526,6 +526,59 @@ def test_build_column_lineage_no_fallback_when_parser_has_global_lineage(self):
         assert result == []
 
     @pytest.mark.order(13)
+    def test_build_column_lineage_from_parser_iterable_parent(self):
+        """
+        When src_col._parent is an iterable of parent tables (as some
+        parser outputs produce), _build_column_lineage_from_parser must
+        correctly match against from_entity when any parent matches.
+        Issue #26670.
+        """
+        # Parent is an iterable (list) of Table objects
+        parent_table_mock = MagicMock()
+        parent_table_mock.__str__ = MagicMock(
+            return_value="relation_table"
+        )
+
+        src_col = MagicMock()
+        src_col.raw_name = "id"
+        # _parent is a list — simulates iterable parser output
+        src_col._parent = [parent_table_mock]
+
+        tgt_col = MagicMock()
+        tgt_col.raw_name = "relation_id"
+
+        mock_parser = MagicMock()
+        mock_parser.column_lineage = [(src_col, tgt_col)]
+
+        src_fqn = "postgres.public.relation_table.id"
+        alias_fqn = "quicksight_service.dataset.relation_id"
+
+        mock_from_entity = MagicMock()
+        mock_from_entity.name.root = "relation_table"
+        mock_data_model = MagicMock()
+
+        with patch(
+            "metadata.ingestion.source.dashboard.quicksight.metadata.get_column_fqn",
+            return_value=src_fqn,
+        ):
+            with patch.object(
+                self.quicksight,
+                "_get_data_model_column_fqn",
+                return_value=alias_fqn,
+            ):
+                result = (
+                    self.quicksight._build_column_lineage_from_parser(
+                        mock_parser,
+                        mock_from_entity,
+                        mock_data_model,
+                    )
+                )
+
+        assert len(result) == 1
+        assert result[0].fromColumns == [src_fqn]
+        assert result[0].toColumn == alias_fqn
+
+    @pytest.mark.order(14)
     def test_build_column_lineage_from_parser_falls_back_when_empty(self):
         """
         When lineage_parser.column_lineage is empty (parser failed or