Commit 4722e2b
committed
chore(ingestion): drop pylint, expand ruff to Stage 2c
Replace pylint with a coherent ruff-only stack (Stage 2c of the modernize
roadmap). Pylint is dropped from dev deps and CI workflows; ruff selected
ruleset expanded to ~22 families covering style, bug catchers, hygiene,
and the pylint port (PLE/PLC/PLW/PLR with the noisy "too-many-X"
complexity caps + magic-value disabled).
What's selected (with rationale in pyproject.toml):
E, W, F, I, N — style + correctness baseline + naming
UP — pyupgrade (py>=3.10 modernizations)
B, C4, C90, RET, SIM, TRY — bug catchers
PIE, ICN, T20, TC, TID, PTH, PERF — hygiene
PLE, PLC, PLW, PLR — pylint port (PLR complexity caps ignored)
RUF — ruff-native (incl. RUF100 unused-noqa)
What's removed:
- .pylintrc (root) — duplicate of the ingestion pylint config
- [tool.pylint.*] block in ingestion/pyproject.toml (~140 lines)
- ingestion/plugins/{print_checker,import_checker}.py + tests + README
(replaced by built-in T20 + TID251 banned-api respectively)
- pylint dep from ingestion/setup.py and openmetadata-airflow-apis/pyproject.toml
- `make lint` Makefile target + the pylint invocation in py_format_check
- dead pylint TODO comment + ignored test entry in noxfile.py
Cwd-stable config: ruff is invoked both from the repo root (pre-commit,
CI) and from ingestion/ (`make py_format_check`). The `src`,
`extend-exclude`, and per-file-ignores entries are listed twice — once
relative to ingestion/ and once with the `ingestion/` prefix — so
first-party isort detection and exclusions match in both invocations.
Grandfathering: ran `ruff check --add-noqa` once + format-stable
iteration. ~12,130 noqa directives across ~1,400 files. Cleanup is
deferred to follow-up PRs that drop noqas one rule at a time.
Documentation sweep: replaced `make lint` references in CLAUDE.md,
AGENTS.md, DEVELOPER.md, copilot-instructions, and 6 SKILL files with
the apply+verify shape `make py_format && make py_format_check`.
`make py_format` is NOT a strict superset of pylint — it only applies
auto-fixable violations; `make py_format_check` catches the rest.
Basedpyright baseline regenerated: ruff format reflowed multi-line
signatures in ~70 files, shifting type-error column positions. The
basedpyright baseline matches by (file path, error code, range), so
column shifts caused 19 entries to mis-align. Net diff is small
(154 lines in/out of the 13MB baseline.json) — purely positional.
Verified locally:
- make py_format_check → All checks passed
- nox --no-venv -s static-checks → 0 errors, 0 warnings, 0 notes1 parent 48a7de3 commit 4722e2b
1,387 files changed
Lines changed: 12047 additions & 12228 deletions
File tree
- .github
- ingestion
- .basedpyright
- examples/airflow/dags
- operators/docker
- plugins
- src
- _openmetadata_testutils
- factories
- base
- metadata/generated/schema
- api/classification
- entity
- classification
- data
- type
- helpers
- kafka
- pii
- postgres
- pydantic
- pytest_openmetadata
- airflow_provider_openmetadata
- hooks
- lineage
- config
- metadata
- antlr
- applications
- automations
- clients
- microsoftfabric
- cli
- config
- data_quality
- api
- builders
- interface
- sqlalchemy
- processor
- runner
- source
- validations
- checkers
- column
- base
- pandas
- sqlalchemy
- mixins
- runtime_param_setter
- table
- base
- pandas
- sqlalchemy
- great_expectations
- utils
- ingestion
- api
- bulksink
- connections
- lineage
- models
- ometa
- mixins
- processor
- sink
- source
- api
- rest
- dashboard
- domodashboard
- grafana
- hex
- lightdash
- looker
- metabase
- microstrategy
- mode
- powerbi
- qlikcloud
- qliksense
- quicksight
- redash
- sigma
- ssrs
- superset
- tableau
- database
- athena
- azuresql
- bigquery
- bigtable
- burstiq
- cassandra
- clickhouse
- cockroach
- common/data_diff
- couchbase
- databricks
- data_diff
- datalake
- clients
- db2
- dbt
- deltalake
- clients
- domodatabase
- doris
- druid
- dynamodb
- exasol
- glue
- greenplum
- hive
- metastore_dialects
- mysql
- postgres
- impala
- iomete
- mariadb
- microsoftfabric
- mongodb
- mssql
- my_db
- mysql
- oracle
- pinotdb
- postgres
- pgspider
- presto
- query
- redshift
- salesforce
- saperp
- saphana
- sas
- singlestore
- snowflake
- data_diff
- sqlite
- starrocks
- profiler
- teradata
- timescale
- trino
- data_diff
- profiler
- unitycatalog
- data_diff
- vertica
- drive
- googledrive
- sftp
- mcp
- messaging
- kafka
- kinesis
- pubsub
- redpanda
- metadata
- alationsink
- amundsen
- atlas
- mlmodel
- mlflow
- sagemaker
- pipeline
- airbyte
- airflow
- api
- dagster
- databrickspipeline
- dbtcloud
- domopipeline
- fivetran
- flink
- gluepipeline
- kafkaconnect
- microsoftfabricpipeline
- nifi
- openlineage
- spline
- search
- elasticsearch
- opensearch
- security
- storage
- gcs
- s3
- stage
- mixins
- pandas
- sqalchemy
- models
- parsers
- pii
- algorithms
- scanners
- profiler
- adaptors
- api
- interface
- nosql
- pandas
- burstiq
- sqlalchemy
- athena
- bigquery
- databricks
- mariadb
- redshift
- single_store
- snowflake
- trino
- metrics
- composed
- hybrid
- static
- system
- bigquery
- databricks
- redshift
- snowflake
- window
- orm
- converter
- bigquery
- redshift
- snowflake
- trino
- functions
- types
- processor
- source
- database
- base
- bigquery
- databricks
- mssql
- fetcher
- readers
- dataframe
- file
- sampler
- nosql
- pandas
- burstiq
- sqlalchemy
- azuresql
- bigquery
- databricks
- postgres
- snowflake
- timescale
- trino
- storage
- gcs
- s3
- sdk
- api
- data_quality
- dataframes
- tests
- entities
- examples
- utils
- datalake
- dependency_injector
- secrets
- service_spec
- workflow
- context
- tests
- cli_e2e
- base
- config_builders
- common
- integration
- airflow
- test_dags
- alationsink
- amundsen
- atlas
- auto_classification
- containers
- databases
- automations
- cockroach
- connections
- data_quality
- datalake
- fivetran
- great_expectations
- kafka
- lineage/e2e
- mongodb
- mysql
- ometa
- orm_profiler
- system
- postgres
- profiler
- s3
- sas
- sdk
- data_quality/dataframes
- sftp
- sources
- database/delta_lake
- mlmodels/mlflow
- sql_server
- superset
- test_suite
- trino
- usage
- workflow
- load
- test_resources
- unit
- airflow
- bulksink
- clients/microsoftfabric
- data_quality/validations
- great_expectations
- lineage
- masker
- queries
- metadata
- data_quality
- ingestion
- models
- ometa
- source/database/snowflake/profiler
- pii
- utils
- dependency_injector
- models
- observability
- data_quality
- source
- validations
- runtime_param_setter
- table/sqlalchemy
- profiler
- custom_types
- pandas
- sqlalchemy
- azuresql
- bigquery
- mssql
- mysql
- postgres
- snowflake
- test_inherited_metrics
- pii
- algorithms
- data
- readers
- sampler
- pandas
- sqlalchemy
- sdk
- data_quality
- source
- database
- mcp
- pipeline
- topology
- api
- dashboard
- fixtures
- database
- drive
- mlmodel
- pipeline
- search
- storage
- utils
- workflow
- utils
- docker_service_builders
- database_container
- openmetadata-airflow-apis
- openmetadata_managed_apis
- api
- routes
- operations
- resources
- utils
- views
- workflows
- ingestion
- tests
- integration
- operations
- unit
- ingestion_pipeline
- skills
- agents
- code-review
- connector-audit/prompts
- openmetadata-workflow
- planning
- tdd
- verification
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
448 | 448 | | |
449 | 449 | | |
450 | 450 | | |
451 | | - | |
452 | | - | |
| 451 | + | |
| 452 | + | |
453 | 453 | | |
454 | 454 | | |
455 | 455 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
56 | | - | |
| 55 | + | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | | - | |
124 | | - | |
| 123 | + | |
| 124 | + | |
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| |||
0 commit comments