Skip to content

Commit 4e24ba1

Browse files
ulixius9claude
andauthored
fix(cli-e2e): use profileSampleConfig in profiler test builders (#27947)
PR #27184 (commit 47c88d4, "Dynamic Sampling Config") moved profileSample/profileSampleType out of DatabaseServiceProfilerPipeline and TableProfilerConfig into a nested profileSampleConfig object, but the CLI E2E test config builders weren't updated. Both pydantic models now use extra='forbid', so the old format raises "Extra parameter 'profileSample'" and the scheduled py-cli-e2e-tests workflow has been red on every run since 2026-04-17 (postgres, mysql, mssql, oracle, redshift, snowflake, redash, metabase, quicksight, tableau, bigquery_multiple_project, dbt_redshift). Update the ProfilerConfigBuilder to emit the new schema and update the BigQuery TableProfilerConfig usage to match. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 219c568 commit 4e24ba1

2 files changed

Lines changed: 18 additions & 3 deletions

File tree

ingestion/tests/cli_e2e/base/config_builders/builders.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,12 @@ def build(self) -> dict:
5858
self.config["source"]["sourceConfig"] = {
5959
"config": {
6060
"type": "Profiler",
61-
"profileSample": self.profilerSample,
61+
"profileSampleConfig": {
62+
"sampleConfigType": "STATIC",
63+
"config": {
64+
"profileSample": self.profilerSample,
65+
},
66+
},
6267
}
6368
}
6469

ingestion/tests/cli_e2e/test_cli_bigquery.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@
3030
from metadata.generated.schema.tests.basic import TestCaseResult, TestCaseStatus
3131
from metadata.generated.schema.tests.testCase import TestCaseParameterValue
3232
from metadata.generated.schema.type.basic import ProfileSampleType, Timestamp
33+
from metadata.generated.schema.type.samplingConfig import (
34+
ProfileSampleConfig,
35+
SampleConfigType,
36+
)
37+
from metadata.generated.schema.type.staticSamplingConfig import StaticSamplingConfig
3338

3439
from .common.test_cli_db import CliCommonDB # noqa: TID252
3540
from .common_e2e_sqa_mixins import SQACommonMethods # noqa: TID252
@@ -189,8 +194,13 @@ def add_table_profile_config(self):
189194
self.openmetadata.create_or_update_table_profiler_config(
190195
self.get_data_quality_table(),
191196
TableProfilerConfig(
192-
profileSampleType=ProfileSampleType.ROWS,
193-
profileSample=100,
197+
profileSampleConfig=ProfileSampleConfig(
198+
sampleConfigType=SampleConfigType.STATIC,
199+
config=StaticSamplingConfig(
200+
profileSample=100,
201+
profileSampleType=ProfileSampleType.ROWS,
202+
),
203+
),
194204
),
195205
)
196206

0 commit comments

Comments
 (0)