fix(hive): fix MSSQL docstring, remove semicolon, regenerate hiveConnection TS types (#12787)

Author: SaaiAravindhRaja

ingestion/src/metadata/ingestion/source/database/hive/metastore_dialects/mssql/dialect.py

@@ -31,7 +31,7 @@
 class HiveMssqlMetaStoreDialect(HiveMetaStoreDialectMixin, MSDialect_pyodbc):
     """
     MSSQL metastore dialect class for Hive metastore backed by SQL Server.
-    Uses square-bracket quoting compatible with MSSQL and supports CTEs.
+    Uses unquoted identifiers and supports CTEs.
     """
 
     name = "hive"
@@ -115,7 +115,7 @@ def get_view_definition(self, connection, view_name, schema=None, **kw):
                 tbls.VIEW_ORIGINAL_TEXT AS view_def
             FROM TBLS tbls
             JOIN DBS dbs ON tbls.DB_ID = dbs.DB_ID
-            WHERE tbls.VIEW_ORIGINAL_TEXT IS NOT NULL;
+            WHERE tbls.VIEW_ORIGINAL_TEXT IS NOT NULL
         """
         return get_view_definition_wrapper(
             self,

ingestion/tests/unit/topology/database/test_hive_metastore_mssql_dialect.py

@@ -87,7 +87,7 @@ def test_get_table_columns_query_structure(self):
         assert "PKEY_NAME" in executed_query
         assert "PKEY_TYPE" in executed_query
         assert "PKEY_COMMENT" in executed_query
-        assert executed_query.upper().count("SELECT") == 2
+        assert executed_query.upper().count("SELECT") == 4
 
     def test_get_table_columns_uses_unquoted_identifiers(self):
         """MSSQL dialect uses unquoted identifiers, not double-quoted like Postgres."""

openmetadata-ui/src/main/resources/ui/src/generated/entity/services/connections/database/hiveConnection.ts

@@ -13,7 +13,7 @@
 /**
  * Hive SQL Connection Config
  */
-export interface HiveConnection {
+export interface HiveConnectionNew {
     /**
      * Authentication mode to connect to hive.
      */
@@ -135,6 +135,10 @@ export interface FilterPattern {
  * Postgres Database Connection Config
  *
  * Mysql Database Connection Config
+ *
+ * Mssql Database Connection Config
+ *
+ * Oracle Database Connection Config
  */
 export interface HiveMetastoreConnectionDetails {
     /**
@@ -161,11 +165,17 @@ export interface HiveMetastoreConnectionDetails {
      * Host and port of the source service.
      *
      * Host and port of the MySQL service.
+     *
+     * Host and port of the MSSQL service.
+     *
+     * Host and port of the Oracle service.
      */
     hostPort?: string;
     /**
      * Ingest data from all databases in Postgres. You can use databaseFilterPattern on top of
      * this.
+     *
+     * Ingest data from all databases in Mssql. You can use databaseFilterPattern on top of this.
      */
     ingestAllDatabases?: boolean;
     /**
@@ -186,6 +196,9 @@ export interface HiveMetastoreConnectionDetails {
     scheme?: Scheme;
     /**
      * SSL Configuration details.
+     *
+     * SSL/TLS certificate configuration for client authentication. Provide CA certificate,
+     * client certificate, and private key for mutual TLS authentication.
      */
     sslConfig?: Config;
     sslMode?:   SSLMode;
@@ -215,6 +228,12 @@ export interface HiveMetastoreConnectionDetails {
      *
      * Username to connect to MySQL. This user should have privileges to read all the metadata
      * in Mysql.
+     *
+     * Username to connect to MSSQL. This user should have privileges to read all the metadata
+     * in MsSQL.
+     *
+     * Username to connect to Oracle. This user should have privileges to read all the metadata
+     * in Oracle.
      */
     username?: string;
     /**
@@ -232,6 +251,55 @@ export interface HiveMetastoreConnectionDetails {
      * Use slow logs to extract lineage.
      */
     useSlowLogs?: boolean;
+    /**
+     * ODBC driver version in case of pyodbc connection.
+     */
+    driver?: string;
+    /**
+     * Enable SSL/TLS encryption for the MSSQL connection. When enabled, all data transmitted
+     * between the client and server will be encrypted.
+     */
+    encrypt?: boolean;
+    /**
+     * Password to connect to MSSQL.
+     *
+     * Password to connect to Oracle.
+     */
+    password?: string;
+    /**
+     * Trust the server certificate without validation. Set to false in production to validate
+     * server certificates against the certificate authority.
+     */
+    trustServerCertificate?: boolean;
+    /**
+     * This directory will be used to set the LD_LIBRARY_PATH env variable. It is required if
+     * you need to enable thick connection mode. By default, we bring instant client 19 and
+     * point to /instantclient.
+     */
+    instantClientDirectory?: string;
+    /**
+     * Connect with oracle by either passing service name or database schema name.
+     */
+    oracleConnectionType?: OracleConnectionType;
+    /**
+     * Controls how Oracle identifier names (tables, columns, schemas) are stored in
+     * OpenMetadata. When disabled (default), Oracle's UPPERCASE unquoted identifiers (e.g.
+     * EMPLOYEES) are not guaranteed to be stored as-is — identifiers with the same letters but
+     * different case (e.g. unquoted EMPLOYEES and quoted 'employees') will collide into the
+     * same name. When enabled, names are stored exactly as Oracle persists them, which solves
+     * same-name collisions between quoted and unquoted identifiers. WARNING: enabling this
+     * after data has already been ingested with the default setting will change the stored
+     * names of all existing tables, columns, schemas, and constraints — breaking attached tags,
+     * descriptions, lineage, data quality tests, and any other metadata associated with those
+     * entities. If you must switch, soft-delete all previously ingested entities before
+     * re-ingesting.
+     */
+    preserveIdentifierCase?: boolean;
+    /**
+     * Use Oracle DBA_* tables instead of ALL_* tables for metadata ingestion. Requires DBA
+     * privileges.
+     */
+    useDBATable?: boolean;
 }
 
 /**
@@ -334,6 +402,29 @@ export interface AzureCredentials {
     vaultName?: string;
 }
 
+/**
+ * Connect with oracle by either passing service name or database schema name.
+ */
+export interface OracleConnectionType {
+    /**
+     * databaseSchema of the data source. This is optional parameter, if you would like to
+     * restrict the metadata reading to a single databaseSchema. When left blank, OpenMetadata
+     * Ingestion attempts to scan all the databaseSchema.
+     */
+    databaseSchema?: string;
+    /**
+     * The Oracle Service name is the TNS alias that you give when you remotely connect to your
+     * database.
+     */
+    oracleServiceName?: string;
+    /**
+     * Pass the full constructed TNS string, e.g.,
+     * (DESCRIPTION=(ADDRESS_LIST=(ADDRESS=(PROTOCOL=TCP)(HOST=myhost)(PORT=1530)))(CONNECT_DATA=(SID=MYSERVICENAME))).
+     */
+    oracleTNSConnection?: string;
+    [property: string]: any;
+}
+
 /**
  * Storage config to store sample data
  */
@@ -422,7 +513,11 @@ export interface AwsCredentials {
  * SQLAlchemy driver scheme options.
  */
 export enum Scheme {
+    MssqlPymssql = "mssql+pymssql",
+    MssqlPyodbc = "mssql+pyodbc",
+    MssqlPytds = "mssql+pytds",
     MysqlPymysql = "mysql+pymysql",
+    OracleCxOracle = "oracle+cx_oracle",
     PgspiderPsycopg2 = "pgspider+psycopg2",
     PostgresqlPsycopg2 = "postgresql+psycopg2",
 }
@@ -432,6 +527,9 @@ export enum Scheme {
  *
  * SSL Configuration details.
  *
+ * SSL/TLS certificate configuration for client authentication. Provide CA certificate,
+ * client certificate, and private key for mutual TLS authentication.
+ *
  * OpenMetadata Client configured to validate SSL certificates.
  */
 export interface Config {
@@ -467,7 +565,9 @@ export enum SSLMode {
  * Service type.
  */
 export enum Type {
+    Mssql = "Mssql",
     Mysql = "Mysql",
+    Oracle = "Oracle",
     Postgres = "Postgres",
 }