Skip to content

Commit 895bbf6

Browse files
authored
Fix LineageFilter playwright (#27208)
1 parent 89f78f2 commit 895bbf6

2 files changed

Lines changed: 38 additions & 6 deletions

File tree

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage/LineageFilters.spec.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ import {
3939
openImpactAnalysisTab,
4040
performZoomOut,
4141
rearrangeNodes,
42+
setLineageDepthAndVerify,
4243
visitLineageTab,
4344
} from '../../../utils/lineage';
4445
import { test } from '../../fixtures/pages';
@@ -127,6 +128,8 @@ test.describe('Lineage Filters', () => {
127128
await lineageEntity.visitEntityPage(page);
128129
await visitLineageTab(page);
129130
await waitForAllLoadersToDisappear(page);
131+
await setLineageDepthAndVerify(page, 2, 2);
132+
await waitForAllLoadersToDisappear(page);
130133
await rearrangeNodes(page);
131134
await performZoomOut(page);
132135
await expect(
@@ -273,6 +276,8 @@ test.describe('Lineage Filters', () => {
273276
await test.step('Verify filters working for Lineage tab', async () => {
274277
await page.reload();
275278
await waitForAllLoadersToDisappear(page);
279+
await setLineageDepthAndVerify(page, 2, 2);
280+
await waitForAllLoadersToDisappear(page);
276281

277282
await page.getByTestId('filters-button').click();
278283
await page.getByTestId(`search-dropdown-${filterTestId}`).click();
@@ -963,6 +968,8 @@ test.describe('Lineage Filters', () => {
963968
for (const entity of depth2ndEntities) {
964969
await entity.visitEntityPage(page);
965970
await visitLineageTab(page);
971+
await waitForAllLoadersToDisappear(page);
972+
await setLineageDepthAndVerify(page, 2, 2);
966973
await page.getByRole('tab', { name: 'Impact Analysis' }).click();
967974
await waitForAllLoadersToDisappear(page);
968975

@@ -1002,6 +1009,8 @@ test.describe('Lineage Filters', () => {
10021009
for (const entity of depth2ndEntities) {
10031010
await entity.visitEntityPage(page);
10041011
await visitLineageTab(page);
1012+
await waitForAllLoadersToDisappear(page);
1013+
await setLineageDepthAndVerify(page, 2, 2);
10051014
await page.getByRole('tab', { name: 'Impact Analysis' }).click();
10061015

10071016
await waitForAllLoadersToDisappear(page);

openmetadata-ui/src/main/resources/ui/playwright/utils/lineage.ts

Lines changed: 29 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -869,9 +869,7 @@ export const verifyColumnLineageInCSV = async (
869869
export const verifyLineageConfig = async (page: Page) => {
870870
await page.getByTestId('lineage-config').click();
871871

872-
await page.locator('.ant-modal-content').first().waitFor({
873-
state: 'visible',
874-
});
872+
await page.getByTestId('field-upstream').waitFor({ state: 'visible' });
875873

876874
await page.getByTestId('field-upstream').fill('-1');
877875
await page.getByTestId('field-downstream').fill('-1');
@@ -941,9 +939,7 @@ export const updateLineageConfigFromModal = async (
941939
) => {
942940
await page.getByTestId('lineage-config').click();
943941

944-
await page.locator('.ant-modal-content').first().waitFor({
945-
state: 'visible',
946-
});
942+
await page.getByTestId('field-upstream').waitFor({ state: 'visible' });
947943

948944
await page
949945
.getByTestId('field-upstream')
@@ -956,6 +952,33 @@ export const updateLineageConfigFromModal = async (
956952
await page.getByRole('dialog').waitFor({ state: 'hidden' });
957953
};
958954

955+
export const setLineageDepthAndVerify = async (
956+
page: Page,
957+
upstreamDepth: number,
958+
downstreamDepth: number
959+
) => {
960+
await page.getByTestId('lineage-config').click();
961+
962+
await page.getByTestId('field-upstream').waitFor({ state: 'visible' });
963+
964+
await page.getByTestId('field-upstream').fill(upstreamDepth.toString());
965+
await page.getByTestId('field-downstream').fill(downstreamDepth.toString());
966+
967+
const lineageRes = page.waitForResponse((response) => {
968+
const url = response.url();
969+
970+
return (
971+
url.includes('/api/v1/lineage/getLineage') &&
972+
url.includes(`upstreamDepth=${upstreamDepth}`) &&
973+
url.includes(`downstreamDepth=${downstreamDepth}`)
974+
);
975+
});
976+
977+
await page.getByText('OK').click();
978+
await page.getByRole('dialog').waitFor({ state: 'hidden' });
979+
await lineageRes;
980+
};
981+
959982
export const verifyPlatformLineageForEntity = async (
960983
page: Page,
961984
fromFqn: string,

0 commit comments

Comments
 (0)