Skip to content

Commit a3d7299

Browse files
committed
fix(policy): grant Trigger to IngestionBot for /trigger authz
1 parent 54a4c9c commit a3d7299

10 files changed

Lines changed: 73 additions & 1 deletion

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
-- Placeholder for 1.12.9 MySQL
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
-- Placeholder for 1.12.9 MySQL
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
-- Placeholder for 1.12.9 Postgres
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
-- Placeholder for 1.12.9 Postgres
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
package org.openmetadata.service.migration.mysql.v1129;
2+
3+
import static org.openmetadata.service.migration.utils.v1129.MigrationUtil.addTriggerOperationToIngestionBotPolicy;
4+
5+
import lombok.SneakyThrows;
6+
import org.openmetadata.service.migration.api.MigrationProcessImpl;
7+
import org.openmetadata.service.migration.utils.MigrationFile;
8+
9+
public class Migration extends MigrationProcessImpl {
10+
11+
public Migration(MigrationFile migrationFile) {
12+
super(migrationFile);
13+
}
14+
15+
@Override
16+
@SneakyThrows
17+
public void runDataMigration() {
18+
addTriggerOperationToIngestionBotPolicy(collectionDAO);
19+
}
20+
}

openmetadata-service/src/main/java/org/openmetadata/service/migration/mysql/v1130/Migration.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.openmetadata.service.migration.mysql.v1130;
22

3+
import static org.openmetadata.service.migration.utils.v1129.MigrationUtil.addTriggerOperationToIngestionBotPolicy;
4+
35
import lombok.SneakyThrows;
46
import lombok.extern.slf4j.Slf4j;
57
import org.openmetadata.service.migration.api.MigrationProcessImpl;
@@ -31,5 +33,6 @@ public void runDataMigration() {
3133
LOG.error("v1130 glossaryTerm version relatedTerms transform failed; re-run to retry.", e);
3234
}
3335
MigrationUtil.addTableColumnSearchSettings();
36+
addTriggerOperationToIngestionBotPolicy(collectionDAO);
3437
}
3538
}
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
package org.openmetadata.service.migration.postgres.v1129;
2+
3+
import static org.openmetadata.service.migration.utils.v1129.MigrationUtil.addTriggerOperationToIngestionBotPolicy;
4+
5+
import lombok.SneakyThrows;
6+
import org.openmetadata.service.migration.api.MigrationProcessImpl;
7+
import org.openmetadata.service.migration.utils.MigrationFile;
8+
9+
public class Migration extends MigrationProcessImpl {
10+
11+
public Migration(MigrationFile migrationFile) {
12+
super(migrationFile);
13+
}
14+
15+
@Override
16+
@SneakyThrows
17+
public void runDataMigration() {
18+
addTriggerOperationToIngestionBotPolicy(collectionDAO);
19+
}
20+
}

openmetadata-service/src/main/java/org/openmetadata/service/migration/postgres/v1130/Migration.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.openmetadata.service.migration.postgres.v1130;
22

3+
import static org.openmetadata.service.migration.utils.v1129.MigrationUtil.addTriggerOperationToIngestionBotPolicy;
4+
35
import lombok.SneakyThrows;
46
import lombok.extern.slf4j.Slf4j;
57
import org.openmetadata.service.migration.api.MigrationProcessImpl;
@@ -31,5 +33,6 @@ public void runDataMigration() {
3133
LOG.error("v1130 glossaryTerm version relatedTerms transform failed; re-run to retry.", e);
3234
}
3335
MigrationUtil.addTableColumnSearchSettings();
36+
addTriggerOperationToIngestionBotPolicy(collectionDAO);
3437
}
3538
}
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
package org.openmetadata.service.migration.utils.v1129;
2+
3+
import static org.openmetadata.service.migration.utils.v160.MigrationUtil.addOperationsToPolicyRule;
4+
5+
import java.util.List;
6+
import lombok.extern.slf4j.Slf4j;
7+
import org.openmetadata.schema.type.MetadataOperation;
8+
import org.openmetadata.service.jdbi3.CollectionDAO;
9+
10+
@Slf4j
11+
public class MigrationUtil {
12+
13+
private MigrationUtil() {}
14+
15+
public static void addTriggerOperationToIngestionBotPolicy(CollectionDAO collectionDAO) {
16+
addOperationsToPolicyRule(
17+
"IngestionBotPolicy",
18+
"IngestionBotRule-Allow",
19+
List.of(MetadataOperation.TRIGGER),
20+
collectionDAO);
21+
}
22+
}

openmetadata-service/src/main/resources/json/data/policy/IngestionBotPolicy.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"name": "IngestionBotRule-Allow",
1212
"description" : "Allow ingestion bots to create/update/delete data entities",
1313
"resources" : ["All"],
14-
"operations": ["Create", "BulkCreate", "BulkUpdate", "EditAll", "ViewAll", "Delete"],
14+
"operations": ["Create", "BulkCreate", "BulkUpdate", "EditAll", "ViewAll", "Delete", "Trigger"],
1515
"effect": "allow"
1616
},
1717
{

0 commit comments

Comments
 (0)