fix(policy): expose custom properties via RuleEvaluator and use JsonUtils for extension (#27033)

Author: SaaiAravindhRaja

openmetadata-service/src/main/java/org/openmetadata/service/security/policyevaluator/ResourceContext.java

@@ -19,6 +19,7 @@
 import org.openmetadata.schema.type.EntityReference;
 import org.openmetadata.schema.type.Include;
 import org.openmetadata.schema.type.TagLabel;
+import org.openmetadata.schema.utils.JsonUtils;
 import org.openmetadata.service.Entity;
 import org.openmetadata.service.exception.EntityNotFoundException;
 import org.openmetadata.service.jdbi3.EntityRepository;
@@ -189,17 +190,17 @@ public List<EntityReference> getDomains() {
   }
 
   @Override
-  @SuppressWarnings("unchecked")
   public Map<String, Object> getCustomProperties() {
     resolveEntity();
-    if (entity == null) {
+    if (entity == null || entity.getExtension() == null) {
       return Collections.emptyMap();
     }
-    Object extension = entity.getExtension();
-    if (extension instanceof Map) {
-      return (Map<String, Object>) extension;
+    try {
+      return JsonUtils.getMap(entity.getExtension());
+    } catch (Exception e) {
+      LOG.warn("Failed to get custom properties: {}", e.getMessage());
+      return Collections.emptyMap();
     }
-    return Collections.emptyMap();
   }
 
   private EntityInterface resolveEntity() {
@@ -226,7 +227,9 @@ private EntityInterface resolveEntity() {
         if (entityRepository.isSupportsReviewers()) {
           fields = EntityUtil.addField(fields, Entity.FIELD_REVIEWERS);
         }
-        fields = EntityUtil.addField(fields, FIELD_EXTENSION);
+        if (supportsExtension()) {
+          fields = EntityUtil.addField(fields, FIELD_EXTENSION);
+        }
         fieldList = entityRepository.getFields(fields);
       }
 
@@ -268,5 +271,13 @@ private boolean useRepositoryCache() {
     return operation != ResourceContextInterface.Operation.PATCH
         && operation != ResourceContextInterface.Operation.PUT;
   }
+
+  private boolean supportsExtension() {
+    try {
+      return entityRepository.getFields(FIELD_EXTENSION) != null;
+    } catch (Exception e) {
+      return false;
+    }
+  }
 }
 

openmetadata-service/src/main/java/org/openmetadata/service/security/policyevaluator/RuleEvaluator.java

@@ -5,6 +5,7 @@
 
 import java.util.Arrays;
 import java.util.List;
+import java.util.Map;
 import java.util.Optional;
 import java.util.stream.Collectors;
 import lombok.extern.slf4j.Slf4j;
@@ -370,4 +371,12 @@ public boolean hasAnyRole(String... roles) {
     }
     return false;
   }
+
+  @SuppressWarnings("unused")
+  public Map<String, Object> getCustomProperties() {
+    if (resourceContext == null) {
+      return null;
+    }
+    return resourceContext.getCustomProperties();
+  }
 }