fix(migration): v200 thread_entity guard, PostgreSQL jsonb cast, self-loop cycle detection (#27756)

* fix(migration): v200 thread_entity guard, PostgreSQL jsonb cast, self-loop cycle detection

- Add tableExists guard to migrateThreadTasksToTaskEntity so it skips safely when
  thread_entity has been renamed to thread_entity_legacy by postDataMigration SQL,
  preventing crashes on fresh installs and migration re-runs
- Fix PostgreSQL jsonb type mismatch in migrateSuggestionsToTaskEntity and
  migrateLegacyActivityThreadsToActivityStream: JDBI binds String as varchar which
  PostgreSQL rejects for jsonb columns; use ::jsonb cast when ConnectionType is POSTGRES
- Re-enable migrateThreadTasksToTaskEntity for MySQL (was commented out as workaround)
  now that the tableExists guard makes it safe
- Fix hasCycleDFS in WorkflowDefinitionRepository to skip self-loop edges so
  BPMN reassignment cycles (AssignedStage -> AssignedStage) are not flagged as cycles,
  allowing IncidentLifecycleWorkflow to seed without error
- Fix initSeedDataFromResources in EntityRepository to continue seeding remaining
  entities when one entity fails, instead of aborting the entire seed operation
- Add unit tests covering MySQL/PostgreSQL variants for all three migration methods,
  tableExists guard, and jsonb cast behavior (13 tests total, all passing)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(migration): address review feedback on tableExists and jsonb cast tests

- Fix tableExists to use findFirst() instead of one(): one() throws on an
  empty result set (0 rows from an existing but empty table), causing the
  guard to incorrectly return false and log "table does not exist"
- Replace vacuous jsonb cast tests with direct insertTask reflection tests:
  the previous tests mocked an empty thread list so insertTask was never
  reached, making assertions trivially true regardless of cast logic; now
  call insertTask directly via reflection so the ::jsonb cast path is
  actually exercised for POSTGRES and absent for MYSQL
- Update tableExists mock stubs in tests from .one() to .findFirst()
  to match the corrected implementation

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix v200 migration: insert entity_relationship rows for migrated tasks

Thread tasks and suggestions migrated to task_entity were missing
entity_relationship rows for assignees, createdBy, and about — causing
the repository to return empty assignees and no createdBy in the API.
Added insertTaskLinkRelationships helper called after each task INSERT
in both migrateThreadTasksToTaskEntity and migrateSuggestionsToTaskEntity.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix v200 migration: UPSERT entity_relationship rows and handle thread_entity_legacy

- Replace INSERT IGNORE/ON CONFLICT DO NOTHING with UPSERT so stale
  entity_relationship rows written by 1.12.x FeedRepository (toEntity='thread')
  get corrected to toEntity='task' on PK conflict instead of being silently skipped
- Fall back to thread_entity_legacy when thread_entity is absent so subsequent
  server starts (after post-DDL rename) still process thread tasks
- For tasks already in task_entity, still call insertTaskLinkRelationships instead
  of skipping entirely, ensuring relationship rows are backfilled idempotently

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix v200 migration: null-safe createdBy lookup in alreadyExists backfill

Use threadJson.path("createdBy").asText("system") to avoid treating a
JSON null value as the literal string "null" which would cause lookupUserId
to fail and skip the CREATED entity_relationship row.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: yan-3005

openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java

@@ -1228,7 +1228,16 @@ protected void setDefaultStatus(T entity, boolean update) {
   public final void initSeedDataFromResources() throws IOException {
     List<T> entities = getEntitiesFromSeedData();
     for (T entity : entities) {
-      initializeEntity(entity);
+      try {
+        initializeEntity(entity);
+      } catch (Exception e) {
+        LOG.warn(
+            "Failed to initialize {} '{}': {}",
+            entityType,
+            entity.getFullyQualifiedName(),
+            e.getMessage(),
+            e);
+      }
     }
   }
 

openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/WorkflowDefinitionRepository.java

@@ -347,6 +347,9 @@ private boolean hasCycleDFS(
     List<String> neighbors = adjacencyList.get(node);
     if (neighbors != null) {
       for (String neighbor : neighbors) {
+        if (neighbor.equals(node)) {
+          continue;
+        }
         if (hasCycleDFS(neighbor, adjacencyList, visited, recursionStack)) {
           return true;
         }

openmetadata-service/src/main/java/org/openmetadata/service/migration/mysql/v200/Migration.java

@@ -1,9 +1,11 @@
 package org.openmetadata.service.migration.mysql.v200;
 
+import static org.openmetadata.service.jdbi3.locator.ConnectionType.MYSQL;
 import static org.openmetadata.service.migration.utils.v200.MigrationUtil.addTableColumnSearchSettings;
 import static org.openmetadata.service.migration.utils.v200.MigrationUtil.backfillAnnouncementRelationships;
 import static org.openmetadata.service.migration.utils.v200.MigrationUtil.migrateLegacyActivityThreadsToActivityStream;
 import static org.openmetadata.service.migration.utils.v200.MigrationUtil.migrateSuggestionsToTaskEntity;
+import static org.openmetadata.service.migration.utils.v200.MigrationUtil.migrateThreadTasksToTaskEntity;
 
 import lombok.SneakyThrows;
 import org.openmetadata.service.migration.api.MigrationProcessImpl;
@@ -19,11 +21,9 @@ public Migration(MigrationFile migrationFile) {
   @SneakyThrows
   public void runDataMigration() {
     addTableColumnSearchSettings();
-    migrateSuggestionsToTaskEntity(handle);
-    // Causing issues with collate CI, needs to be fixed before enabling this migration
-    // @harshach
-    // migrateThreadTasksToTaskEntity(handle);
-    migrateLegacyActivityThreadsToActivityStream(handle);
+    migrateSuggestionsToTaskEntity(handle, MYSQL);
+    migrateThreadTasksToTaskEntity(handle, MYSQL);
+    migrateLegacyActivityThreadsToActivityStream(handle, MYSQL);
     backfillAnnouncementRelationships(handle);
   }
 }

openmetadata-service/src/main/java/org/openmetadata/service/migration/postgres/v200/Migration.java

@@ -1,9 +1,11 @@
 package org.openmetadata.service.migration.postgres.v200;
 
+import static org.openmetadata.service.jdbi3.locator.ConnectionType.POSTGRES;
 import static org.openmetadata.service.migration.utils.v200.MigrationUtil.addTableColumnSearchSettings;
 import static org.openmetadata.service.migration.utils.v200.MigrationUtil.backfillAnnouncementRelationships;
 import static org.openmetadata.service.migration.utils.v200.MigrationUtil.migrateLegacyActivityThreadsToActivityStream;
 import static org.openmetadata.service.migration.utils.v200.MigrationUtil.migrateSuggestionsToTaskEntity;
+import static org.openmetadata.service.migration.utils.v200.MigrationUtil.migrateThreadTasksToTaskEntity;
 
 import lombok.SneakyThrows;
 import org.openmetadata.service.migration.api.MigrationProcessImpl;
@@ -19,11 +21,9 @@ public Migration(MigrationFile migrationFile) {
   @SneakyThrows
   public void runDataMigration() {
     addTableColumnSearchSettings();
-    migrateSuggestionsToTaskEntity(handle);
-    // Causing issues with collate CI, needs to be fixed before enabling this migration
-    // @harshach
-    // migrateThreadTasksToTaskEntity(handle);
-    migrateLegacyActivityThreadsToActivityStream(handle);
+    migrateSuggestionsToTaskEntity(handle, POSTGRES);
+    migrateThreadTasksToTaskEntity(handle, POSTGRES);
+    migrateLegacyActivityThreadsToActivityStream(handle, POSTGRES);
     backfillAnnouncementRelationships(handle);
   }
 }