Skip to content

Commit b42c9ad

Browse files
authored
Fixed the translations issues in AdvancedSearch description option (#27961)
* Fixed the translations issues in AdvancedSearch description option * nit
1 parent 4c07b28 commit b42c9ad

3 files changed

Lines changed: 13 additions & 8 deletions

File tree

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/AdvancedSearch.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ test.describe(
673673
await sidebarClick(page, SidebarItem.EXPLORE);
674674
});
675675

676-
test(`Contains - table with that word in description is visible`, async ({
676+
test('Description Contains filter returns matching tables', async ({
677677
page,
678678
}) => {
679679
await test.step('Open advanced search dialog', async () => {
@@ -756,7 +756,7 @@ test.describe(
756756
await page.getByTestId('clear-filters').click();
757757
});
758758

759-
test(`Not Contains – table IS visible (word absent from description)`, async ({
759+
test('Not Contains – table IS visible (word absent from description)', async ({
760760
page,
761761
}) => {
762762
await test.step('Open advanced search dialog', async () => {

openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/PersonaFlow.spec.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -752,14 +752,18 @@ test.describe.serial('Team persona setting flow', () => {
752752
});
753753
});
754754

755-
let CURATED_DESCRIPTION_TEXT;
755+
let CURATED_DESCRIPTION_TEXT: string;
756756
let WORD_TO_SEARCH: string;
757-
const curatedAdminUser = new UserClass();
758-
const curatedPersona = new PersonaClass();
759-
const curatedTable = new TableClass();
757+
let curatedAdminUser: UserClass;
758+
let curatedPersona: PersonaClass;
759+
let curatedTable: TableClass;
760760

761761
test.describe('Curated Assets – Description filter', () => {
762762
test.beforeAll('Setup', async ({ browser }) => {
763+
curatedAdminUser = new UserClass();
764+
curatedPersona = new PersonaClass();
765+
curatedTable = new TableClass();
766+
763767
const UNIQUE_WORD = `unique-word-${uuid()}`;
764768
WORD_TO_SEARCH = `table with a unique description ${UNIQUE_WORD}.`;
765769
CURATED_DESCRIPTION_TEXT = `This is a curated table with a unique description ${UNIQUE_WORD}. It is bioluminescent and not an oscilloscope.`;
@@ -823,6 +827,7 @@ test.describe('Curated Assets – Description filter', () => {
823827
adminPage,
824828
}) => {
825829
await test.step('Navigate to persona settings and add curated assets widget', async () => {
830+
await redirectToHomePage(adminPage);
826831
await addCuratedAssetWidget(adminPage);
827832
});
828833

openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchClassBase.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,8 @@ class AdvancedSearchClassBase {
177177
sqlOp: 'NOT IN',
178178
},
179179
match_phrase: {
180-
label: t('label.contains'),
181-
labelForFormat: t('label.contains'),
180+
label: t('label.contain-plural'),
181+
labelForFormat: t('label.contain-plural'),
182182
reversedOp: 'not_match_phrase',
183183
elasticSearchQueryType: 'match_phrase',
184184
valueSources: ['value'],

0 commit comments

Comments
 (0)