Skip to content

Commit cc7acfa

Browse files
committed
fixed the icons changes
1 parent dc3d77c commit cc7acfa

6 files changed

Lines changed: 41 additions & 42 deletions

File tree

openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ArchiveView/ArchiveView.component.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ const ArchiveRow: FC<ArchiveRowProps> = ({
104104
<ButtonUtility
105105
color="tertiary"
106106
data-testid="restore-btn"
107-
icon={<RefreshIcon height={18} width={18} />}
107+
icon={<RefreshIcon height={20} width={20} />}
108108
size="sm"
109109
tooltip={t('label.restore')}
110110
onClick={() => onRestore(item)}
@@ -114,7 +114,7 @@ const ArchiveRow: FC<ArchiveRowProps> = ({
114114
<ButtonUtility
115115
color="tertiary"
116116
data-testid="delete-btn"
117-
icon={<TrashIcon height={18} width={18} />}
117+
icon={<TrashIcon height={20} width={20} />}
118118
size="sm"
119119
tooltip={t('label.delete')}
120120
onClick={() => onDelete(item)}

openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/ArticleDetailHeader/ArticleDetailHeader.component.tsx

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ import { ReactComponent as ThumbsUpActiveIcon } from '../../../assets/svg/action
4646
import { ReactComponent as ThumbsUpIcon } from '../../../assets/svg/action-icons/thumbs-up.svg';
4747
import { ReactComponent as TrashIcon } from '../../../assets/svg/action-icons/trash.svg';
4848
import { ReactComponent as EditorIcon } from '../../../assets/svg/common/editor.svg';
49-
import { ReactComponent as FileIcon } from '../../../assets/svg/common/file.svg';
5049
import { ReactComponent as GlobeIcon } from '../../../assets/svg/common/globe.svg';
5150
import { ReactComponent as UserIcon } from '../../../assets/svg/common/user.svg';
5251
import { ReactComponent as SidebarCollapsible } from '../../../assets/svg/ic-sidebar-collapsible.svg';
@@ -266,8 +265,8 @@ const ArticleDetailHeader: FC<ArticleDetailHeaderProps> = ({
266265
color="success"
267266
size="lg"
268267
type="color">
269-
<UploadCloud01 size={16} />{' '}
270-
<Typography weight="medium">{t('label.saved')}</Typography>
268+
<UploadCloud01 size={12} />{' '}
269+
<Typography className='tw:text-utility-success-700' weight="medium">{t('label.saved')}</Typography>
271270
</Badge>
272271
</div>
273272
);
@@ -281,7 +280,7 @@ const ArticleDetailHeader: FC<ArticleDetailHeaderProps> = ({
281280
color="gray"
282281
size="lg"
283282
type="color">
284-
<UploadCloud01 size={16} />{' '}
283+
<UploadCloud01 size={12} />{' '}
285284
<Typography weight="medium">{t('label.unsaved')}</Typography>
286285
</Badge>
287286
</div>
@@ -341,14 +340,14 @@ const ArticleDetailHeader: FC<ArticleDetailHeaderProps> = ({
341340
{/* Row 1: title + meta + actions */}
342341
<div className="tw:flex tw:items-center tw:justify-between tw:mb-6">
343342
<div className="tw:flex tw:gap-4 tw:items-stretch tw:w-full tw:max-w-[60%] tw:pr-3">
344-
<div className="h:full tw:w-auto tw:shrink-0 tw:bg-tertiary tw:rounded-xl tw:flex tw:items-center tw:p-2">
343+
{/* <div className="h:full tw:w-auto tw:shrink-0 tw:bg-tertiary tw:rounded-xl tw:flex tw:items-center tw:p-2">
345344
<FileIcon
346345
className="tw:text-quaternary"
347346
height={40}
348347
style={{ verticalAlign: 'middle', flexShrink: 0 }}
349348
width={40}
350349
/>
351-
</div>
350+
</div> */}
352351

353352
<div className="tw:flex tw:flex-col tw:gap-2 tw:min-w-0">
354353
{/* Article name with icon */}
@@ -619,8 +618,8 @@ const ArticleDetailHeader: FC<ArticleDetailHeaderProps> = ({
619618
<TrashIcon
620619
aria-hidden="true"
621620
className="ttw:shrink-0 tw:text-error-primary"
622-
height={18}
623-
width={18}
621+
height={20}
622+
width={20}
624623
/>
625624
<Typography
626625
ellipsis

openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/CreateMemoryModal/CreateMemoryModal.component.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ import {
3737
Lock01,
3838
Plus,
3939
Share07,
40-
Trash01,
4140
X,
4241
} from '@untitledui/icons';
4342
import { ConfigProvider } from 'antd';
@@ -56,7 +55,8 @@ import {
5655
import { useTranslation } from 'react-i18next';
5756
import ReactMarkdown from 'react-markdown';
5857
import { Link } from 'react-router-dom';
59-
import { ReactComponent as EditIcon } from '../../../assets/svg/edit-new.svg';
58+
import { ReactComponent as EditIcon } from '../../../assets/svg/action-icons/edit.svg';
59+
import { ReactComponent as TrashIcon } from '../../../assets/svg/action-icons/trash.svg';
6060
import {
6161
getCustomMarkdownComponents,
6262
preprocessMarkdownText,
@@ -871,10 +871,10 @@ const CreateMemoryModal: FC<CreateMemoryModalProps> = ({
871871
{t(visibilityOption.descriptionKey)}
872872
</Typography>
873873
)}
874-
{!isViewOnly && isOwner && (
874+
{!isViewOnly && (isOwner || isAdminUser) && (
875875
<ButtonUtility
876876
color="tertiary"
877-
icon={<EditIcon height={14} width={14} />}
877+
icon={<EditIcon height={16} width={16} />}
878878
onClick={() => setIsEditingVisibility(true)}
879879
/>
880880
)}
@@ -1023,7 +1023,7 @@ const CreateMemoryModal: FC<CreateMemoryModalProps> = ({
10231023
{Boolean(memoryToEdit) && canDelete && (
10241024
<Button
10251025
color="tertiary-destructive"
1026-
iconLeading={Trash01}
1026+
iconLeading={TrashIcon}
10271027
isDisabled={isDeleting || isSubmitting}
10281028
isLoading={isDeleting}
10291029
size="sm"

openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/DocumentsView/DocumentPreviewPanel.component.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,13 @@ const DocumentPreviewPanel: FC<DocumentPreviewPanelProps> = ({
7777
{t('label.detail-plural')}
7878
</Typography>
7979
<Box align="center" gap={2}>
80-
<CopyLinkButton className='tw:h-7.5 tw:w-7.5' url={url}>
81-
<CopyIcon aria-hidden="true" height={18} width={18} />
80+
<CopyLinkButton className='tw:h-8 tw:w-8' url={url}>
81+
<CopyIcon aria-hidden="true" height={20} width={20} />
8282
</CopyLinkButton>
8383
<ButtonUtility
8484
color="tertiary"
8585
data-testid="close-preview-btn"
86-
icon={<XClose size={18} />}
86+
icon={<XClose size={20} />}
8787
size="xs"
8888
tooltip={t('label.close')}
8989
onClick={onClose}

openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/DocumentsView/DocumentsView.component.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ const FileActions: FC<FileActionsProps> = ({
169169
<ButtonUtility
170170
color="tertiary"
171171
data-testid="edit-memory-btn"
172-
icon={ <DotsVerticalIcon height={18} width={18} />}
172+
icon={ <DotsVerticalIcon height={20} width={20} />}
173173
size="sm"
174174
tooltip={t('label.manage-entity', { entity: t('label.document') })}
175175
/>
@@ -188,7 +188,7 @@ const FileActions: FC<FileActionsProps> = ({
188188
{() => (
189189
<Box align="center" justify="between">
190190
<Box align='center' gap={2}>
191-
<MoveFolderIcon className="tw:text-secondary" height={18} width={18} />
191+
<MoveFolderIcon className="tw:text-secondary" height={20} width={20} />
192192
<Typography ellipsis className="tw:grow tw:text-secondary">
193193
{t('label.move-to-folder')}
194194
</Typography>
@@ -220,8 +220,8 @@ const FileActions: FC<FileActionsProps> = ({
220220
<TrashIcon
221221
aria-hidden="true"
222222
className="tw:shrink-0 tw:text-error-primary"
223-
height={18}
224-
width={18}
223+
height={20}
224+
width={20}
225225
/>
226226
<Typography
227227
ellipsis
@@ -531,12 +531,12 @@ const FileRow: FC<FileRowProps> = ({
531531
className="tw:ml-1.5"
532532
color="tertiary"
533533
data-testid="download-btn"
534-
icon={<DownloadIcon height={18} width={18} />}
534+
icon={<DownloadIcon height={20} width={20} />}
535535
tooltip={t('label.download')}
536536
onClick={() => onDownload?.(file)}
537537
/>
538538
<CopyLinkButton url={rowUrl}>
539-
<CopyIcon aria-hidden="true" height={18} width={18} />
539+
<CopyIcon aria-hidden="true" height={20} width={20} />
540540
</CopyLinkButton>
541541
<FileActions
542542
canDelete={canDelete}

openmetadata-ui/src/main/resources/ui/src/components/ContextCenter/MemoriesView/MemoriesView.component.tsx

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111
* limitations under the License.
1212
*/
1313
import {
14-
Badge,
15-
Box,
16-
ButtonUtility,
17-
Dot,
18-
Dropdown,
19-
Skeleton,
20-
Tooltip,
21-
TooltipTrigger,
22-
Typography,
14+
Badge,
15+
Box,
16+
ButtonUtility,
17+
Dot,
18+
Dropdown,
19+
Skeleton,
20+
Tooltip,
21+
TooltipTrigger,
22+
Typography,
2323
} from '@openmetadata/ui-core-components';
2424
import { FC, useMemo } from 'react';
2525
import { useTranslation } from 'react-i18next';
@@ -31,16 +31,16 @@ import { ReactComponent as ClockIcon } from '../../../assets/svg/common/clock.sv
3131
import ProfilePicture from '../../../components/common/ProfilePicture/ProfilePicture';
3232
import { ENTITY_ICON_MAPPER } from '../../../constants/Assets.constants';
3333
import {
34-
ContextMemory,
35-
EntityReference,
34+
ContextMemory,
35+
EntityReference,
3636
} from '../../../generated/entity/context/contextMemory';
3737
import { getShortRelativeTime } from '../../../utils/date-time/DateTimeUtils';
3838
import { getEntityName } from '../../../utils/EntityNameUtils';
3939
import { stripMarkdown } from '../../../utils/StringUtils';
4040
import CopyLinkButton from '../../CopyLinkButton/CopyLinkButton.component';
4141
import {
42-
MemoriesViewProps,
43-
MemoryActionsProps,
42+
MemoriesViewProps,
43+
MemoryActionsProps,
4444
} from './MemoriesView.interface';
4545
import './MemoriesView.less';
4646

@@ -52,7 +52,7 @@ const MemoryActions: FC<MemoryActionsProps> = ({ memory, onDeleteMemory }) => {
5252
<ButtonUtility
5353
color="tertiary"
5454
data-testid="edit-memory-btn"
55-
icon={ <DotsVerticalIcon height={18} width={18} />}
55+
icon={ <DotsVerticalIcon height={20} width={20} />}
5656
size="sm"
5757
tooltip={t('label.manage-entity', { entity: t('label.memory') })}
5858
/>
@@ -68,8 +68,8 @@ const MemoryActions: FC<MemoryActionsProps> = ({ memory, onDeleteMemory }) => {
6868
<TrashIcon
6969
aria-hidden="true"
7070
className="tw:shrink-0 tw:text-error-primary"
71-
height={18}
72-
width={18}
71+
height={20}
72+
width={20}
7373
/>
7474
<Typography
7575
ellipsis
@@ -291,15 +291,15 @@ const MemoryRow: FC<MemoryRowProps> = ({
291291
{/* Actions — always visible */}
292292
<Box align="center" gap={1} onClick={(e) => e.stopPropagation()}>
293293
<CopyLinkButton url={memoryUrl}>
294-
<CopyIcon aria-hidden="true" height={18} width={18} />
294+
<CopyIcon aria-hidden="true" height={20} width={20} />
295295
</CopyLinkButton>
296296
{canActOnMemory && canEdit && onEditMemory && (
297297
<Tooltip title={t('label.edit')}>
298298
<TooltipTrigger>
299299
<ButtonUtility
300300
color="tertiary"
301301
data-testid="edit-memory-btn"
302-
icon={<EditIcon height={18} width={18} />}
302+
icon={<EditIcon height={20} width={20} />}
303303
size="sm"
304304
onClick={() => onEditMemory(memory)}
305305
/>

0 commit comments

Comments
 (0)