Fix: Address performance and backward compatibility issues in TestCase relationship cleanup

Author: Megh-Shah-08

openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/TestCaseResourceIT.java

@@ -4453,7 +4453,7 @@ void test_testCaseDeleteCleanup(TestNamespace ns) {
     List<CollectionDAO.EntityRelationshipRecord> relationships =
         Entity.getCollectionDAO()
             .relationshipDAO()
-            .findTo(testCase.getId(), Entity.TEST_CASE, Relationship.RELATED_TO.ordinal());
+            .findTo(testCase.getId(), Entity.TEST_CASE, Relationship.PARENT_OF.ordinal());
 
     assertNotNull(relationships);
     long statusCount =
@@ -4467,13 +4467,14 @@ void test_testCaseDeleteCleanup(TestNamespace ns) {
     // 4. Hard delete the test case
     java.util.Map<String, String> params = new java.util.HashMap<>();
     params.put("hardDelete", "true");
+    params.put("recursive", "true");
     client.testCases().delete(testCase.getId().toString(), params);
 
     // 5. Verify relationships are cleaned up
     List<CollectionDAO.EntityRelationshipRecord> relationshipsAfter =
         Entity.getCollectionDAO()
             .relationshipDAO()
-            .findTo(testCase.getId(), Entity.TEST_CASE, Relationship.RELATED_TO.ordinal());
+            .findTo(testCase.getId(), Entity.TEST_CASE, Relationship.PARENT_OF.ordinal());
 
     long statusCountAfter =
         relationshipsAfter.stream()

openmetadata-service/src/main/java/org/openmetadata/service/Entity.java

@@ -773,11 +773,8 @@ public static void deleteEntity(
       String updatedBy, String entityType, UUID entityId, boolean recursive, boolean hardDelete) {
     if (entityType.equalsIgnoreCase(Entity.TEST_CASE_RESOLUTION_STATUS)
         || entityType.equalsIgnoreCase(Entity.TEST_CASE_RESULT)) {
-      // TimeSeries entities don't have a standard repository delete flow.
-      // We only want to delete their relationships if they are orphaned.
-      EntityTimeSeriesRepository<?> repository = getEntityTimeSeriesRepository(entityType);
-      // We don't call repository.delete(entityId) here because we want to preserve history.
-      // The relationships will be cleaned up by the caller's relationshipDAO().deleteAll().
+      // TimeSeries entities are cleaned up via entitySpecificCleanup,
+      // not through the standard repository delete flow.
       return;
     }
     EntityRepository<?> dao = getEntityRepository(entityType);

openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/CollectionDAO.java

@@ -2398,7 +2398,7 @@ default void deleteAll(UUID id, String entity) {
 
     @SqlUpdate(
         "DELETE FROM entity_relationship WHERE toEntity = :toEntity AND fromEntity = :fromEntity "
-            + "AND fromId NOT IN (SELECT id FROM <table>)")
+            + "AND NOT EXISTS (SELECT 1 FROM <table> t WHERE t.id = entity_relationship.fromId)")
     int deleteOrphanedRelationships(
         @Bind("fromEntity") String fromEntity,
         @Bind("toEntity") String toEntity,

openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TestCaseRepository.java

@@ -897,8 +897,7 @@ protected void entitySpecificCleanup(TestCase entityInterface) {
     TestCaseResolutionStatusRepository testCaseResolutionStatusRepository =
         (TestCaseResolutionStatusRepository)
             Entity.getEntityTimeSeriesRepository(Entity.TEST_CASE_RESOLUTION_STATUS);
-    testCaseResolutionStatusRepository.deleteAllRelationshipsByTestCase(
-        entityInterface.getFullyQualifiedName());
+    testCaseResolutionStatusRepository.deleteAllRelationshipsByTestCase(entityInterface.getId());
   }
 
   private void deleteAllTestCaseResults(String fqn) {

openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TestCaseResolutionStatusRepository.java

@@ -236,18 +236,14 @@ public void storeInternal(
     recordEntity.withTestCaseReference(testCaseReference);
   }
 
-  public void deleteAllRelationshipsByTestCase(String testCaseFQN) {
-    List<String> jsons =
-        ((CollectionDAO.TestCaseResolutionStatusTimeSeriesDAO) timeSeriesDao)
-            .listTestCaseResolutionForEntityFQNHash(testCaseFQN);
-    if (jsons.isEmpty()) {
-      return;
-    }
-    List<UUID> statusIds =
-        jsons.stream()
-            .map(json -> JsonUtils.readValue(json, TestCaseResolutionStatus.class).getId())
-            .toList();
-    daoCollection.relationshipDAO().batchDeleteRelationships(statusIds, entityType);
+  public void deleteAllRelationshipsByTestCase(UUID testCaseId) {
+    daoCollection
+        .relationshipDAO()
+        .deleteFrom(
+            testCaseId,
+            Entity.TEST_CASE,
+            Relationship.PARENT_OF.ordinal(),
+            Entity.TEST_CASE_RESOLUTION_STATUS);
   }
 
   @Override
@@ -257,15 +253,15 @@ protected void storeRelationship(TestCaseResolutionStatus recordEntity) {
         recordEntity.getId(),
         Entity.TEST_CASE,
         Entity.TEST_CASE_RESOLUTION_STATUS,
-        Relationship.RELATED_TO,
+        Relationship.PARENT_OF,
         null,
         false);
   }
 
   @Override
   protected void setInheritedFields(TestCaseResolutionStatus recordEntity) {
     recordEntity.setTestCaseReference(
-        getFromEntityRef(recordEntity.getId(), Relationship.RELATED_TO, Entity.TEST_CASE, true));
+        getFromEntityRef(recordEntity.getId(), Relationship.PARENT_OF, Entity.TEST_CASE, true));
   }
 
   private void openOrAssignTask(TestCaseResolutionStatus incidentStatus) {