Address Copilot review: Fix multi-table column lineage fallback and correct pytest ordering

Author: mohitjeswani01

ingestion/src/metadata/ingestion/source/dashboard/quicksight/metadata.py

@@ -355,9 +355,12 @@ def _build_column_lineage_from_parser(
                 )
                 logger.debug(traceback.format_exc())
 
-        if not column_lineage:
-            # Fallback: parser returned no column lineage or all pairs
-            # were filtered out. Use name-based matching as before.
+        # Only fall back to name-based matching when the parser found
+        # NO column lineage globally (parse failure, too complex, no aliases).
+        # If the parser DID produce lineage but none matched this specific
+        # from_entity (multi-table query), return an empty list rather than
+        # manufacturing incorrect cross-table lineage.
+        if not column_lineage and not lineage_parser.column_lineage:
             columns = [col.name.root for col in data_model_entity.columns]
             return self._get_column_lineage(
                 from_entity, data_model_entity, columns

ingestion/tests/unit/topology/dashboard/test_quicksight.py

@@ -497,6 +497,49 @@ def test_build_column_lineage_from_parser_multi_table_filters_correctly(self):
         assert result[0].fromColumns == [src_fqn]
         assert result[0].toColumn == alias_fqn
 
+    @pytest.mark.order(11)
+    def test_build_column_lineage_no_fallback_when_parser_has_global_lineage(self):
+        """
+        Regression test for the multi-table fallback bug (Issue #26670).
+
+        When lineage_parser.column_lineage is non-empty (parser succeeded)
+        but none of the pairs match from_entity (because they belong to a
+        different upstream table in a multi-table JOIN), the method must
+        return an empty list and must NOT call _get_column_lineage (the
+        name-based fallback). Calling the fallback here would manufacture
+        incorrect cross-table column lineage.
+        """
+        # Parser found lineage for a DIFFERENT table, not our from_entity
+        other_src_col = MagicMock()
+        other_src_col.raw_name = "user_id"
+        other_src_col._parent = MagicMock()
+        other_src_col._parent.__str__ = MagicMock(return_value="users_table")
+
+        other_tgt_col = MagicMock()
+        other_tgt_col.raw_name = "uid"
+
+        mock_parser = MagicMock()
+        # Parser globally found lineage — but only for 'users_table'
+        mock_parser.column_lineage = [(other_src_col, other_tgt_col)]
+
+        mock_from_entity = MagicMock()
+        # Our from_entity is 'orders_table' — no parser pairs match it
+        mock_from_entity.name.root = "orders_table"
+        mock_data_model = MagicMock()
+
+        with patch.object(
+            self.quicksight,
+            "_get_column_lineage",
+        ) as mock_fallback:
+            result = self.quicksight._build_column_lineage_from_parser(
+                mock_parser, mock_from_entity, mock_data_model
+            )
+
+        # Must NOT have called the name-based fallback
+        mock_fallback.assert_not_called()
+        # Must return an empty list — no manufactured lineage
+        assert result == []
+
     @pytest.mark.order(12)
     def test_build_column_lineage_from_parser_iterable_parent(self):
         """
@@ -550,7 +593,7 @@ def test_build_column_lineage_from_parser_iterable_parent(self):
         assert result[0].fromColumns == [src_fqn]
         assert result[0].toColumn == alias_fqn
 
-    @pytest.mark.order(11)
+    @pytest.mark.order(13)
     def test_build_column_lineage_from_parser_falls_back_when_empty(self):
         """
         When lineage_parser.column_lineage is empty (parser failed or