Skip to content

Commit f8b1c1a

Browse files
shrabantipaul-collateShrabanti Paul
authored andcommitted
Fix flaky customizedetail page spec (#27420)
* increase data contracts test timeout * fix flaky customizeDetailPage specs --------- Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
1 parent 958c473 commit f8b1c1a

1 file changed

Lines changed: 6 additions & 14 deletions

File tree

openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/CustomizeDetailPage.spec.ts

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -461,12 +461,10 @@ test.describe('Persona customization', PLAYWRIGHT_BASIC_TEST_TAG_OBJ, () => {
461461
const addWidgetButton = adminPage
462462
.getByTestId('ExtraWidget.EmptyWidgetPlaceholder')
463463
.getByTestId('add-widget-button');
464-
await addWidgetButton.waitFor({ state: 'visible' });
464+
await expect(addWidgetButton).toBeVisible();
465465
await expect(addWidgetButton).toBeEnabled();
466466
await addWidgetButton.click();
467-
await adminPage
468-
.getByTestId('widget-info-tabs')
469-
.waitFor({ state: 'visible' });
467+
await expect(adminPage.getByTestId('widget-info-tabs')).toBeVisible();
470468

471469
await adminPage
472470
.getByTestId('add-widget-modal')
@@ -477,9 +475,7 @@ test.describe('Persona customization', PLAYWRIGHT_BASIC_TEST_TAG_OBJ, () => {
477475
.getByTestId('add-widget-button')
478476
.click();
479477

480-
await adminPage
481-
.getByTestId('widget-info-tabs')
482-
.waitFor({ state: 'hidden' });
478+
await expect(adminPage.getByTestId('widget-info-tabs')).toBeHidden();
483479
await adminPage.getByTestId('save-button').click();
484480

485481
await toastNotification(
@@ -609,12 +605,10 @@ test.describe('Persona customization', PLAYWRIGHT_BASIC_TEST_TAG_OBJ, () => {
609605
const addWidgetButton = adminPage
610606
.getByTestId('ExtraWidget.EmptyWidgetPlaceholder')
611607
.getByTestId('add-widget-button');
612-
await addWidgetButton.waitFor({ state: 'visible' });
608+
await expect(addWidgetButton).toBeVisible();
613609
await expect(addWidgetButton).toBeEnabled();
614610
await addWidgetButton.click();
615-
await adminPage
616-
.getByTestId('widget-info-tabs')
617-
.waitFor({ state: 'visible' });
611+
await expect(adminPage.getByTestId('widget-info-tabs')).toBeVisible();
618612

619613
await adminPage
620614
.getByTestId('add-widget-modal')
@@ -625,9 +619,7 @@ test.describe('Persona customization', PLAYWRIGHT_BASIC_TEST_TAG_OBJ, () => {
625619
.getByTestId('add-widget-button')
626620
.click();
627621

628-
await adminPage
629-
.getByTestId('widget-info-tabs')
630-
.waitFor({ state: 'hidden' });
622+
await expect(adminPage.getByTestId('widget-info-tabs')).toBeHidden();
631623

632624
await adminPage.getByTestId('save-button').click();
633625

0 commit comments

Comments
 (0)