Skip to content

Commit f92690b

Browse files
Remove unused deleteAllByEntityFQN and fix test comment scope
- Remove dead deleteAllByEntityFQN() method (cleanup uses deleteAllByEntityFQNPrefix instead) - Narrow test section comment to reference only #27041 since the tests cover profiler data cleanup, not entity_extension time series
1 parent e7c128f commit f92690b

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

openmetadata-integration-tests/src/test/java/org/openmetadata/it/tests/TableResourceIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5850,7 +5850,7 @@ void test_listTablesWithColumnTags_performance(TestNamespace ns) {
58505850
}
58515851

58525852
// ===================================================================
5853-
// TIMESERIES CLEANUP ON HARD DELETE TESTS (fixes #27041, #27042)
5853+
// TABLE PROFILER TIMESERIES CLEANUP ON HARD DELETE TESTS (fixes #27041)
58545854
// ===================================================================
58555855

58565856
/**

openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityTimeSeriesDAO.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -532,14 +532,6 @@ default void delete(String entityFQNHash, String extension) {
532532
delete(getTimeSeriesTableName(), entityFQNHash, extension);
533533
}
534534

535-
@SqlUpdate("DELETE FROM <table> WHERE entityFQNHash = :entityFQNHash")
536-
void deleteAllByEntityFQN(
537-
@Define("table") String table, @BindFQN("entityFQNHash") String entityFQN);
538-
539-
default void deleteAllByEntityFQN(String entityFQN) {
540-
deleteAllByEntityFQN(getTimeSeriesTableName(), entityFQN);
541-
}
542-
543535
@SqlUpdate(
544536
"DELETE FROM <table> WHERE entityFQNHash = :entityFQNHash OR entityFQNHash LIKE :prefix")
545537
void deleteAllByEntityFQNPrefixInternal(

0 commit comments

Comments
 (0)