chore(ingestion): keep main's baseline + globally ignore TRY400

Per gitar-bot's review on PR #27774:

1. Main's PR #27728 promoted ~60 `logger.warning()` → `logger.error()`
   inside `except` blocks. Those changes landed on main with their own
   baseline updates. Our PR doesn't promote anything — the merge from
   origin/main brought those `error` calls along with their baseline
   entries.

   The bot interpreted the `# noqa: TRY400` we added next to those lines
   as us silencing the rule case-by-case. Cleaner: globally ignore
   TRY400 in pyproject.toml, with a comment explaining why the codebase's
   `logger.error(...)` + separate `logger.debug(traceback.format_exc())`
   pattern is intentional. Strip ~430 per-line `# noqa: TRY400` markers
   from source.

2. Document that `S101` in `per-file-ignores` is a forward-looking
   entry — flake8-bandit (`S`) is not yet selected, so the rule is
   no-op today; the entry stays so when `S` lands later, tests don't
   immediately error.

Reverts the platform pin and Linux Docker–generated baseline. Keep
main's baseline intact and let CI surface the exact column-shifted
entries; the team will decide whether to fix in-place (revert format
on affected files) or add per-line `# pyright: ignore` markers.

Author: IceS2

ingestion/.basedpyright/baseline.json

@@ -105,7 +105,7 @@ def get_kubernetes_client() -> Optional[client.CoreV1Api]:  # noqa: UP045
             )
             return None
     except Exception as unexpected_error:  # noqa: B025
-        logger.error(f"Unexpected error initializing Kubernetes client: {unexpected_error}")  # noqa: TRY400
+        logger.error(f"Unexpected error initializing Kubernetes client: {unexpected_error}")
         return None
 
 
@@ -178,7 +178,7 @@ def find_main_pod(
         return None  # noqa: TRY300
 
     except Exception as e:
-        logger.error(f"Failed to find main pod for job {job_name}: {e}")  # noqa: TRY400
+        logger.error(f"Failed to find main pod for job {job_name}: {e}")
         return None
 
 
@@ -314,7 +314,7 @@ def get_main_pod_description(k8s_client: client.CoreV1Api, main_pod: V1Pod, name
         return description if description_parts else None  # noqa: TRY300
 
     except Exception as e:
-        logger.error(f"Failed to get pod description: {e}")  # noqa: TRY400
+        logger.error(f"Failed to get pod description: {e}")
         return None
 
 
@@ -463,7 +463,7 @@ def gather_failure_diagnostics(
 
     except Exception as e:
         # Catch-all for any unexpected errors - diagnostics should never break the exit handler
-        logger.error(f"Unexpected error while gathering diagnostics: {e}")  # noqa: TRY400
+        logger.error(f"Unexpected error while gathering diagnostics: {e}")
         return FailureDiagnostics()
 
 
@@ -499,7 +499,7 @@ def update_pipeline_status_with_diagnostics(
             logger.warning(f"Failed to update pipeline status with diagnostics: {e}")
 
     except Exception as e:
-        logger.error(f"Failed to create pod diagnostics: {e}")  # noqa: TRY400
+        logger.error(f"Failed to create pod diagnostics: {e}")
 
 
 def main():
@@ -571,14 +571,14 @@ def main():
                 update_pipeline_status_with_diagnostics(pipeline_status, diagnostics)
             except Exception as e:
                 # Log the error but continue - diagnostics should never prevent status updates
-                logger.error(f"Failed to gather or add diagnostics, continuing with status update: {e}")  # noqa: TRY400
+                logger.error(f"Failed to gather or add diagnostics, continuing with status update: {e}")
 
         # Send updated status to OpenMetadata - this is the critical operation that must succeed
         try:
             metadata.create_or_update_pipeline_status(workflow_config.ingestionPipelineFQN, pipeline_status)
             logger.info(f"Successfully updated pipeline status to {pipeline_status.pipelineState.value}")
         except Exception as e:
-            logger.error(f"CRITICAL: Failed to send pipeline status update to OpenMetadata: {e}")  # noqa: TRY400
+            logger.error(f"CRITICAL: Failed to send pipeline status update to OpenMetadata: {e}")
             raise
     else:
         logger.info("Missing required fields - not updating pipeline status")
@@ -589,5 +589,5 @@ def main():
     try:
         main()
     except Exception as e:
-        logger.error(f"Exit handler failed: {e}")  # noqa: TRY400
+        logger.error(f"Exit handler failed: {e}")
         raise

ingestion/operators/docker/exit_handler.py

@@ -180,6 +180,12 @@ ignore = [
 
     # ── Tryceratops nits ──
     "TRY003",   # long exception messages  — community consensus: skip
+    "TRY400",   # use logger.exception over logger.error in except — the
+                # codebase intentionally logs `logger.debug(traceback.format_exc())`
+                # separately from the summary log line, splitting traceback
+                # (debug-only) from the user-facing summary so production
+                # log levels can filter independently. Forcing
+                # `logger.exception` would conflate the two.
 
     # ── Perflint unavoidable cases ──
     "PERF203",  # try inside for-loop      — sometimes the only correct shape (row-by-row)
@@ -211,6 +217,9 @@ ignore = [
 # Each path listed twice — once relative to `ingestion/` (cwd for `make
 # py_format_check`) and once with the `ingestion/` prefix (cwd is repo root
 # for pre-commit hooks). Same pattern as `extend-exclude` above.
+# `S101` (assert in test) is forward-looking — flake8-bandit (`S`) is not
+# yet selected; the rule is no-op today but the entry stays so when `S`
+# lands in a later stage tests don't immediately error out.
 "tests/**/*.py" = ["S101", "PLR2004", "PLC0415"]
 "ingestion/tests/**/*.py" = ["S101", "PLR2004", "PLC0415"]
 # Auto-generated from JSON Schema — never edit, never lint.
@@ -262,11 +271,6 @@ exclude = [
 # 3.12 is verified separately by the unit-test matrix in py-tests.yml.
 # Keep this in sync with `requires-python` above.
 pythonVersion = "3.10"
-# Pin platform analysis to Linux so the baseline file (generated against
-# CI's Ubuntu runner) matches results from any developer machine. Without
-# this, macOS arm64 analyzers resolve some stubs differently and produce
-# column-shifted error positions that don't match the committed baseline.
-pythonPlatform = "Linux"
 
 # Existing violations are grandfathered via .basedpyright/baseline.json
 # (regenerate with `basedpyright -p ingestion/pyproject.toml --writebaseline`

ingestion/pyproject.toml

@@ -101,5 +101,5 @@ def send_lineage(
             runner.execute()
 
         except Exception as exc:  # pylint: disable=broad-except
-            operator.log.error(traceback.format_exc())  # noqa: TRY400
-            operator.log.error(exc)  # noqa: TRY400
+            operator.log.error(traceback.format_exc())
+            operator.log.error(exc)

ingestion/src/airflow_provider_openmetadata/lineage/backend.py

@@ -65,8 +65,8 @@ def failure_callback(context: Dict[str, str]) -> None:  # noqa: UP006
             )
 
     except Exception as exc:  # pylint: disable=broad-except
-        logging.error(traceback.format_exc())  # noqa: TRY400
-        logging.error("Lineage Callback exception %s", exc)  # noqa: TRY400
+        logging.error(traceback.format_exc())
+        logging.error("Lineage Callback exception %s", exc)
 
 
 def success_callback(context: Dict[str, str]) -> None:  # noqa: UP006
@@ -102,5 +102,5 @@ def success_callback(context: Dict[str, str]) -> None:  # noqa: UP006
         )
 
     except Exception as exc:  # pylint: disable=broad-except
-        logging.error(traceback.format_exc())  # noqa: TRY400
-        logging.error("Lineage Callback exception %s", exc)  # noqa: TRY400
+        logging.error(traceback.format_exc())
+        logging.error("Lineage Callback exception %s", exc)

ingestion/src/airflow_provider_openmetadata/lineage/callback.py

@@ -82,5 +82,5 @@ def execute(self, context: Context) -> None:
             runner.execute()
         except Exception as err:
             logger.info(traceback.format_exc())
-            logger.error(f"Error executing the lineage runner - {err}")  # noqa: TRY400
+            logger.error(f"Error executing the lineage runner - {err}")
             raise err  # noqa: TRY201

ingestion/src/airflow_provider_openmetadata/lineage/operator.py

@@ -418,10 +418,10 @@ def get_pipeline_status_via_api(self) -> List[PipelineStatus]:  # noqa: C901, UP
             return pipeline_statuses  # noqa: TRY300
 
         except Exception as e:
-            logger.error(f"Error collecting pipeline status via API: {e}")  # noqa: TRY400
+            logger.error(f"Error collecting pipeline status via API: {e}")
             import traceback  # noqa: PLC0415
 
-            logger.error(f"Traceback: {traceback.format_exc()}")  # noqa: TRY400
+            logger.error(f"Traceback: {traceback.format_exc()}")
             raise
 
     def get_all_pipeline_status(self) -> List[PipelineStatus]:  # noqa: UP006

ingestion/src/airflow_provider_openmetadata/lineage/runner.py

@@ -36,7 +36,7 @@ def run_app(config_path: Path) -> None:
         # no logging for config because apps might have custom secrets
         workflow = ApplicationWorkflow.create(config_dict)
     except Exception as exc:
-        logger.error(f"Error running the application {exc}")  # noqa: TRY400
+        logger.error(f"Error running the application {exc}")
         logger.debug(traceback.format_exc())
         sys.exit(1)
 

ingestion/src/metadata/cli/app.py

@@ -332,6 +332,6 @@ def run_ingest_dbt(dbt_project_path: Path) -> None:
         logger.info("DBT artifacts ingestion completed successfully")
 
     except Exception as exc:
-        logger.error(f"Error during DBT artifacts ingestion: {exc}")  # noqa: TRY400
+        logger.error(f"Error during DBT artifacts ingestion: {exc}")
         logger.debug(traceback.format_exc())
         sys.exit(1)

ingestion/src/metadata/cli/ingest_dbt.py

@@ -51,7 +51,7 @@ def create_client(
                 logger.info("Using Default Azure Credentials")
                 return DefaultAzureCredential()
         except Exception as e:
-            logger.error(f"Error creating Azure Client: {e}")  # noqa: TRY400
+            logger.error(f"Error creating Azure Client: {e}")
             raise e  # noqa: TRY201
 
     def create_blob_client(self):
@@ -66,7 +66,7 @@ def create_blob_client(self):
                 )
             raise ValueError("Account Name is required to create Blob Service Client")  # noqa: TRY301
         except Exception as e:
-            logger.error(f"Error creating Blob Service Client: {e}")  # noqa: TRY400
+            logger.error(f"Error creating Blob Service Client: {e}")
             raise e  # noqa: TRY201
 
     def create_secret_client(self):
@@ -81,5 +81,5 @@ def create_secret_client(self):
                 )
             raise ValueError("Vault Name is required to create a Secret Client")  # noqa: TRY301
         except Exception as e:
-            logger.error(f"Error creating Secret Client: {e}")  # noqa: TRY400
+            logger.error(f"Error creating Secret Client: {e}")
             raise e  # noqa: TRY201