fix(hive): remove semicolon from view query, fix docstring and test assertion (#12787)

Author: SaaiAravindhRaja

ingestion/src/metadata/ingestion/source/database/hive/metastore_dialects/mssql/dialect.py

@@ -11,6 +11,7 @@
 """
 Hive Metastore MSSQL Dialect Mixin
 """
+
 from sqlalchemy import text
 from sqlalchemy.dialects.mssql.pyodbc import MSDialect_pyodbc
 from sqlalchemy.engine import reflection
@@ -31,7 +32,7 @@
 class HiveMssqlMetaStoreDialect(HiveMetaStoreDialectMixin, MSDialect_pyodbc):
     """
     MSSQL metastore dialect class for Hive metastore backed by SQL Server.
-    Uses square-bracket quoting compatible with MSSQL and supports CTEs.
+    Uses unquoted identifiers and supports CTEs.
     """
 
     name = "hive"
@@ -115,7 +116,7 @@ def get_view_definition(self, connection, view_name, schema=None, **kw):
                 tbls.VIEW_ORIGINAL_TEXT AS view_def
             FROM TBLS tbls
             JOIN DBS dbs ON tbls.DB_ID = dbs.DB_ID
-            WHERE tbls.VIEW_ORIGINAL_TEXT IS NOT NULL;
+            WHERE tbls.VIEW_ORIGINAL_TEXT IS NOT NULL
         """
         return get_view_definition_wrapper(
             self,

ingestion/tests/unit/topology/database/test_hive_metastore_mssql_dialect.py

@@ -11,6 +11,7 @@
 """
 Test Hive MSSQL Metastore Dialect
 """
+
 from unittest.mock import MagicMock, Mock
 
 from metadata.ingestion.source.database.hive.metastore_dialects.mssql.dialect import (
@@ -87,7 +88,7 @@ def test_get_table_columns_query_structure(self):
         assert "PKEY_NAME" in executed_query
         assert "PKEY_TYPE" in executed_query
         assert "PKEY_COMMENT" in executed_query
-        assert executed_query.upper().count("SELECT") == 2
+        assert executed_query.upper().count("SELECT") == 4
 
     def test_get_table_columns_uses_unquoted_identifiers(self):
         """MSSQL dialect uses unquoted identifiers, not double-quoted like Postgres."""