Skip to content

MINOR: Fix E2Es for different Services #21407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ayush-shah wants to merge 2 commits into from
Closed

MINOR: Fix E2Es for different Services #21407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad2661d
Fix: Update Snowflake ingestion tests and configuration
ayush-shah May 27, 2025
a4cd53e
Fix: Update Snowflake password secret in E2E tests configuration
ayush-shah May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/py-cli-e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
E2E_BQ_PRIVATE_KEY_ID: ${{ secrets.TEST_BQ_PRIVATE_KEY_ID }}
E2E_BQ_CLIENT_EMAIL: ${{ secrets.TEST_BQ_CLIENT_EMAIL }}
E2E_BQ_CLIENT_ID: ${{ secrets.TEST_BQ_CLIENT_ID }}
E2E_SNOWFLAKE_PASSWORD: ${{ secrets.TEST_SNOWFLAKE_PASSWORD }}
E2E_SNOWFLAKE_PASSWORD: ${{ secrets.TEST_SNOWFLAKE_PASSWORD_YAML }}
E2E_SNOWFLAKE_USERNAME: ${{ secrets.TEST_SNOWFLAKE_USERNAME }}
E2E_SNOWFLAKE_ACCOUNT: ${{ secrets.TEST_SNOWFLAKE_ACCOUNT }}
E2E_SNOWFLAKE_DATABASE: ${{ secrets.TEST_SNOWFLAKE_DATABASE_E2E }}
Expand Down
4 changes: 3 additions & 1 deletion ingestion/tests/cli_e2e/database/snowflake/snowflake.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ source:
serviceConnection:
config:
username: $E2E_SNOWFLAKE_USERNAME
password: $E2E_SNOWFLAKE_PASSWORD
# Use private key for snowflake connection, replace \n with \\n
privateKey: "$E2E_SNOWFLAKE_PASSWORD"
snowflakePrivatekeyPassphrase: $E2E_SNOWFLAKE_PARAPHRASE
account: $E2E_SNOWFLAKE_ACCOUNT
warehouse: $E2E_SNOWFLAKE_WAREHOUSE
database: $E2E_SNOWFLAKE_DATABASE
Expand Down
2 changes: 1 addition & 1 deletion ingestion/tests/cli_e2e/test_cli_snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from metadata.generated.schema.type.basic import Timestamp
from metadata.ingestion.api.status import Status

from ...src.metadata.data_quality.api.models import TestCaseDefinition
from metadata.data_quality.api.models import TestCaseDefinition
from .base.e2e_types import E2EType
from .common.test_cli_db import CliCommonDB
from .common_e2e_sqa_mixins import SQACommonMethods
Expand Down
Loading