Skip to content

don't warn for expected conditions when ingesting dbt#26458

Open
slaupster wants to merge 5 commits intoopen-metadata:mainfrom
slaupster:patch-1
Open

don't warn for expected conditions when ingesting dbt#26458
slaupster wants to merge 5 commits intoopen-metadata:mainfrom
slaupster:patch-1

Conversation

@slaupster
Copy link
Copy Markdown

@slaupster slaupster commented Mar 13, 2026

Describe your changes:

When ingesting dbt I get thousands of:

DBT Test Case Results not found for node

warnings. I don't think these should be warnings because the manifest and run_results represent different things:

  • manifest.json — a complete snapshot of all defined tests in your dbt project
  • run_results.json — only the results from the last dbt invocation

These diverge whenever:

  1. Partial dbt runs — e.g. dbt test --select some_model only runs tests for that model. All other tests remain in the manifest but have no result entry.
  2. Tests were skipped — if an upstream model errored, downstream tests may be skipped and may not appear in run_results at all.
  3. Manifest/run_results mismatch — this could warrant a warning but there is no way for us to tell. Its a fairly "on them" issue though if they have messed up and supplied non matching manifest and run results and I don't think the vast majority of others should suffer 10s of thousands of warnings.
  4. Freshness tests — the add_dbt_sources path (line 710) only adds source freshness tests when a result already exists, so those are never noisy. But regular test nodes are always added regardless.

This PR simply coverts the log to debug.

I worked on ... because ...

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Documentation:
    • Corrected the phrasing of the Ingestion Framework description in README.md to improve readability.

This will update automatically on new commits.

When ingesting dbt I get thousands of:

`DBT Test Case Results not found for node`

warnings. I don't think these should be warnings because the manifest and run_results represent different things:

- manifest.json — a complete snapshot of all defined tests in your dbt project
- run_results.json — only the results from the last dbt invocation

These diverge whenever:

1. Partial dbt runs — e.g. dbt test --select some_model only runs tests for that model. All other tests remain in the manifest but have no result entry.
2. Tests were skipped — if an upstream model errored, downstream tests may be skipped and may not appear in run_results at all.
3. Manifest/run_results mismatch — this could warrant a warning but there is no way for us to tell. Its a fairly "on them" issue though if they have messed up and supplied non matching manifest and run results and I don't think the vast majority of others should suffer 10s of thousands of warnings.
4. Freshness tests — the add_dbt_sources path (line 710) only adds source freshness tests when a result already exists, so those are never noisy. But regular test nodes are always added regardless.

This PR simply coverts the log to debug.
@slaupster slaupster requested a review from a team as a code owner March 13, 2026 03:49
@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Copy Markdown
Contributor

This PR has had no activity for 30 days and will be closed in 7 days if no further activity occurs.
Feel free to reopen it if you'd like to continue working on it.

@github-actions github-actions Bot added Stale and removed Stale labels Apr 12, 2026
TeddyCr
TeddyCr previously approved these changes Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@slaupster
Copy link
Copy Markdown
Author

slaupster commented Apr 15, 2026

thanks for approval @TeddyCr - I'm not sure how to make the CI happy though ?

@slaupster
Copy link
Copy Markdown
Author

needs safe to test label ?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

🟡 Playwright Results — all passed (17 flaky)

✅ 3956 passed · ❌ 0 failed · 🟡 17 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 298 0 1 4
🟡 Shard 2 756 0 3 8
🟡 Shard 3 728 0 4 7
🟡 Shard 4 755 0 4 18
✅ Shard 5 687 0 0 41
🟡 Shard 6 732 0 5 8
🟡 17 flaky test(s) (passed on retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
  • Features/Glossary/GlossaryAdvancedOperations.spec.ts › should create glossary with multiple owners (users + teams) (shard 2, 1 retry)
  • Flow/AddRoleAndAssignToUser.spec.ts › Verify assigned role to new user (shard 3, 1 retry)
  • Flow/IngestionBot.spec.ts › Ingestion bot should be able to access domain specific domain (shard 3, 1 retry)
  • Flow/PersonaDeletionUserProfile.spec.ts › User profile loads correctly before and after persona deletion (shard 3, 1 retry)
  • Flow/SchemaTable.spec.ts › schema table test (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Should verify property name is visible for apiCollection in right panel (shard 4, 1 retry)
  • Pages/DataContractInheritance.spec.ts › Edit Inherited Contract - Creates new asset contract instead of modifying parent (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Topic (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Spreadsheet (shard 4, 1 retry)
  • Features/AutoPilot.spec.ts › Agents created by AutoPilot should be deleted (shard 6, 1 retry)
  • Pages/Glossary.spec.ts › Column dropdown drag-and-drop functionality for Glossary Terms table (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/UserDetails.spec.ts › Admin user can edit teams from the user profile (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 27, 2026

Code Review ✅ Approved

Suppresses warnings for expected conditions during dbt ingestion to reduce log noise. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants