don't warn for expected conditions when ingesting dbt#26458
don't warn for expected conditions when ingesting dbt#26458slaupster wants to merge 5 commits intoopen-metadata:mainfrom
Conversation
When ingesting dbt I get thousands of: `DBT Test Case Results not found for node` warnings. I don't think these should be warnings because the manifest and run_results represent different things: - manifest.json — a complete snapshot of all defined tests in your dbt project - run_results.json — only the results from the last dbt invocation These diverge whenever: 1. Partial dbt runs — e.g. dbt test --select some_model only runs tests for that model. All other tests remain in the manifest but have no result entry. 2. Tests were skipped — if an upstream model errored, downstream tests may be skipped and may not appear in run_results at all. 3. Manifest/run_results mismatch — this could warrant a warning but there is no way for us to tell. Its a fairly "on them" issue though if they have messed up and supplied non matching manifest and run results and I don't think the vast majority of others should suffer 10s of thousands of warnings. 4. Freshness tests — the add_dbt_sources path (line 710) only adds source freshness tests when a result already exists, so those are never noisy. But regular test nodes are always added regardless. This PR simply coverts the log to debug.
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
This PR has had no activity for 30 days and will be closed in 7 days if no further activity occurs. |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
thanks for approval @TeddyCr - I'm not sure how to make the CI happy though ? |
|
needs |
🟡 Playwright Results — all passed (17 flaky)✅ 3956 passed · ❌ 0 failed · 🟡 17 flaky · ⏭️ 86 skipped
🟡 17 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedSuppresses warnings for expected conditions during dbt ingestion to reduce log noise. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Describe your changes:
When ingesting dbt I get thousands of:
DBT Test Case Results not found for nodewarnings. I don't think these should be warnings because the manifest and run_results represent different things:
These diverge whenever:
This PR simply coverts the log to debug.
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
Ingestion Frameworkdescription inREADME.mdto improve readability.This will update automatically on new commits.