Fixes #26889: Support recursive Active Directory group membership in LDAP auth#27027
Fixes #26889: Support recursive Active Directory group membership in LDAP auth#27027abhayguptas wants to merge 4 commits intoopen-metadata:mainfrom
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
hi @harshach, please check this PR and let me know if we need to make any more changes. Let's finalise this and merge it. :) |
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
🟡 Playwright Results — all passed (23 flaky)✅ 3687 passed · ❌ 0 failed · 🟡 23 flaky · ⏭️ 89 skipped
🟡 23 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
229e197 to
83ff62b
Compare
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
hi @PubChimps, I fixed everything here. Please review it and let's merge the PR. |
|
@aji-aju review this PR please |
Code Review ✅ Approved 1 resolved / 1 findingsAdds support for recursive Active Directory group membership in LDAP auth. Refactored test assertions to use assertNull for improved clarity, with no remaining issues found. ✅ 1 resolved✅ Quality: Use assertNull instead of assertTrue(... == null)
OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
|



Describe your changes:
Fixes #26889
I worked on adding an opt-in
recursiveGroupMembershipflag to LDAP configuration so OpenMetadata can resolve nested Active Directory group membership during role mapping.This was needed because the existing LDAP auth flow only matched direct group members, which meant users in nested AD groups were not assigned the expected roles. When the flag is enabled, OpenMetadata now uses Active Directory’s transitive membership matching rule to resolve nested groups on the server side.
How I tested it:
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>