fix: increase test_case name column size to support long dbt-generated test names#27053
Closed
nikhil255288 wants to merge 1 commit intoopen-metadata:mainfrom
Closed
fix: increase test_case name column size to support long dbt-generated test names#27053nikhil255288 wants to merge 1 commit intoopen-metadata:mainfrom
nikhil255288 wants to merge 1 commit intoopen-metadata:mainfrom
Conversation
…d test names Fixes open-metadata#25435 - Increased name column from varchar(256) to varchar(2048) in test_case table - Added migration scripts for both MySQL and PostgreSQL - Updated schema files for fresh installs
Contributor
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ ApprovedIncreases the test_case name column size to accommodate long dbt-generated test names. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
🟡 Playwright Results — all passed (31 flaky)✅ 3448 passed · ❌ 0 failed · 🟡 31 flaky · ⏭️ 223 skipped
🟡 31 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Collaborator
|
Thanks @nikhil255288 this may create cascading issues. Our recommendation with long dbt name is to use custom names at this point. Closing this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #25435
Long dbt-generated test names (e.g.
accepted_valuestests with many arguments)exceed the current
varchar(256)limit on thetest_case.namecolumn, causingingestion to fail with:
ERROR: value too long for type character varyingChanges
namecolumn intest_casetable fromvarchar(256)tovarchar(2048)1.14.0)Type of change
How was this tested?
Schema change verified against existing migration file patterns in the codebase.