Skip to content

fix: increase test_case name column size to support long dbt-generated test names#27053

Closed
nikhil255288 wants to merge 1 commit intoopen-metadata:mainfrom
nikhil255288:fix/dq-test-name-max-length-25435
Closed

fix: increase test_case name column size to support long dbt-generated test names#27053
nikhil255288 wants to merge 1 commit intoopen-metadata:mainfrom
nikhil255288:fix/dq-test-name-max-length-25435

Conversation

@nikhil255288
Copy link
Copy Markdown

Description

Fixes #25435

Long dbt-generated test names (e.g. accepted_values tests with many arguments)
exceed the current varchar(256) limit on the test_case.name column, causing
ingestion to fail with:
ERROR: value too long for type character varying

Changes

  • Increased name column in test_case table from varchar(256) to varchar(2048)
  • Added migration scripts for MySQL and PostgreSQL (1.14.0)
  • Updated schema files for fresh installs

Type of change

  • Bug fix

How was this tested?

Schema change verified against existing migration file patterns in the codebase.

…d test names

Fixes open-metadata#25435

- Increased name column from varchar(256) to varchar(2048) in test_case table
- Added migration scripts for both MySQL and PostgreSQL
- Updated schema files for fresh installs
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Apr 5, 2026

Code Review ✅ Approved

Increases the test_case name column size to accommodate long dbt-generated test names. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

🟡 Playwright Results — all passed (31 flaky)

✅ 3448 passed · ❌ 0 failed · 🟡 31 flaky · ⏭️ 223 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 455 0 2 2
🟡 Shard 2 617 0 2 32
🟡 Shard 3 613 0 8 27
🟡 Shard 4 621 0 11 47
🟡 Shard 5 586 0 1 67
🟡 Shard 6 556 0 7 48
🟡 31 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › Dashboard - customization should work (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/Glossary/GlossaryHierarchy.spec.ts › should cancel move operation (shard 2, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Features/Table.spec.ts › Tags term should be consistent for search (shard 3, 1 retry)
  • Features/TestSuiteMultiPipeline.spec.ts › TestSuite multi pipeline support (shard 3, 1 retry)
  • Features/UserProfileOnlineStatus.spec.ts › Should show online status badge on user profile for active users (shard 3, 1 retry)
  • Flow/CustomizeWidgets.spec.ts › Activity Feed Widget (shard 3, 1 retry)
  • Flow/ExploreDiscovery.spec.ts › Should display deleted assets when showDeleted is checked and deleted is not present in queryFilter (shard 3, 1 retry)
  • Flow/ExploreDiscovery.spec.ts › Should not display soft deleted assets in search suggestions (shard 3, 1 retry)
  • Flow/ObservabilityAlerts.spec.ts › Test Suite alert (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Store Procedure (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Add and update Security and SLA tabs (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Contract Status badge should be visible on condition if Contract Tab is present/hidden by Persona (shard 4, 1 retry)
  • Pages/DomainDataProductsRightPanel.spec.ts › Should edit tags for data product from domain context (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Verify domain tags and glossary terms (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with deeply nested subdomains (3+ levels) verifies FQN propagation (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with owners and experts preserves assignments (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Subdomain rename does not affect parent domain and updates nested children (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Multiple consecutive domain renames preserve all associations (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Tag Add, Update and Remove for child entities (shard 4, 2 retries)
  • Pages/EntityDataSteward.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/Glossary.spec.ts › Add and Remove Assets (shard 6, 1 retry)
  • Pages/HyperlinkCustomProperty.spec.ts › should display URL when no display text is provided (shard 6, 1 retry)
  • Pages/ProfilerConfigurationPage.spec.ts › Non admin user (shard 6, 1 retry)
  • Pages/UserDetails.spec.ts › Admin user can get all the roles hierarchy and edit roles (shard 6, 1 retry)
  • Pages/Users.spec.ts › Create and Delete user (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • ... and 1 more

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@nikhil255288 nikhil255288 changed the title fix: increase test_case name column size to support long dbt-generated test namesfix: increase test_case name column size to support long dbt-generate… fix: increase test_case name column size to support long dbt-generated test names Apr 5, 2026
@TeddyCr
Copy link
Copy Markdown
Collaborator

TeddyCr commented Apr 9, 2026

Thanks @nikhil255288 this may create cascading issues. Our recommendation with long dbt name is to use custom names at this point. Closing this for now

@TeddyCr TeddyCr closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long data quality test names exceed database test name max length

3 participants