Skip to content

fix: increase test_case name column size to support long dbt-generated test names #27053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikhil255288 wants to merge 1 commit into from
+12 −2
Closed

fix: increase test_case name column size to support long dbt-generated test names #27053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bootstrap/sql/migrations/native/1.14.0/mysql/schemaChanges.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
-- Increase test_case name column size to support long dbt-generated test names
-- Fixes: https://github.com/open-metadata/OpenMetadata/issues/25435
ALTER TABLE test_case
DROP COLUMN `name`,
ADD COLUMN `name` varchar(2048) GENERATED ALWAYS AS (json_unquote(json_extract(`json`,_utf8mb4'$.name'))) VIRTUAL NOT NULL;
5 changes: 5 additions & 0 deletions bootstrap/sql/migrations/native/1.14.0/postgres/schemaChanges.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
-- Increase test_case name column size to support long dbt-generated test names
-- Fixes: https://github.com/open-metadata/OpenMetadata/issues/25435
ALTER TABLE test_case
DROP COLUMN name,
ADD COLUMN name character varying(2048) GENERATED ALWAYS AS ((json ->> 'name'::text)) STORED NOT NULL;
2 changes: 1 addition & 1 deletion bootstrap/sql/schema/mysql.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,7 @@ CREATE TABLE `test_case` (
`updatedAt` bigint unsigned GENERATED ALWAYS AS (json_unquote(json_extract(`json`,_utf8mb4'$.updatedAt'))) VIRTUAL NOT NULL,
`updatedBy` varchar(256) GENERATED ALWAYS AS (json_unquote(json_extract(`json`,_utf8mb4'$.updatedBy'))) VIRTUAL NOT NULL,
`deleted` tinyint(1) GENERATED ALWAYS AS (json_extract(`json`,_utf8mb4'$.deleted')) VIRTUAL,
`name` varchar(256) GENERATED ALWAYS AS (json_unquote(json_extract(`json`,_utf8mb4'$.name'))) VIRTUAL NOT NULL,
`name` varchar(2048) GENERATED ALWAYS AS (json_unquote(json_extract(`json`,_utf8mb4'$.name'))) VIRTUAL NOT NULL,
`fqnHash` varchar(768) CHARACTER SET ascii COLLATE ascii_bin DEFAULT NULL,
UNIQUE KEY `fqnHash` (`fqnHash`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci;
Expand Down
2 changes: 1 addition & 1 deletion bootstrap/sql/schema/postgres.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ ALTER TABLE public."DATABASE_CHANGE_LOG" OWNER TO openmetadata_user;

CREATE TABLE public.automations_workflow (
id character varying(36) GENERATED ALWAYS AS ((json ->> 'id'::text)) STORED NOT NULL,
name character varying(256) GENERATED ALWAYS AS ((json ->> 'name'::text)) STORED NOT NULL,
name character varying(2048) GENERATED ALWAYS AS ((json ->> 'name'::text)) STORED NOT NULL,
workflowtype character varying(256) GENERATED ALWAYS AS ((json ->> 'workflowType'::text)) STORED NOT NULL,
status character varying(256) GENERATED ALWAYS AS ((json ->> 'status'::text)) STORED,
json jsonb NOT NULL,
Expand Down
Loading