Skip to content

Make OpeNMetadata Service Unit Test Required#27099

Merged
TeddyCr merged 1 commit intomainfrom
fix-required-check-for-service-test
Apr 9, 2026
Merged

Make OpeNMetadata Service Unit Test Required#27099
TeddyCr merged 1 commit intomainfrom
fix-required-check-for-service-test

Conversation

@mohityadav766
Copy link
Copy Markdown
Member

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 requested a review from TeddyCr April 6, 2026 14:32
Copilot AI review requested due to automatic review settings April 6, 2026 14:32
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Apr 6, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Apr 6, 2026

Code Review ✅ Approved

Makes the OpenMetadata Service Unit Test required in the CI/CD pipeline. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions workflow for OpenMetadata service unit tests to run the Maven test job across a database matrix (MySQL and PostgreSQL), with per-database test report naming to support branch protection / required-check gating.

Changes:

  • Add a matrix strategy to run openmetadata-service unit tests for mysql and postgresql.
  • Include the database selector in the Maven profile list and in artifact / test report check naming.

Comment on lines 107 to 110
run: |
mvn -B clean package -pl openmetadata-service -am \
-Pstatic-code-analysis \
-Pstatic-code-analysis,${{ matrix.database }} \
-DfailIfNoTests=false \
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The matrix adds -P... ,${{ matrix.database }} but Maven profiles mysql/postgresql don’t appear to be defined in the root pom.xml or openmetadata-service/pom.xml (they only exist in openmetadata-sdk/pom.xml). With mvn ... -pl openmetadata-service -am, those profiles are likely not available/active, so this will run the same unit test suite twice and won’t actually switch database behavior.

Consider either defining these profiles in the root/service POM (so they apply to this build) or passing an explicit property/env that the service tests actually consume (e.g., -Dtest.database=...) and wiring tests to use it.

Copilot uses AI. Check for mistakes.
@TeddyCr TeddyCr merged commit 3ec31e3 into main Apr 9, 2026
41 checks passed
@TeddyCr TeddyCr deleted the fix-required-check-for-service-test branch April 9, 2026 22:58
SaaiAravindhRaja pushed a commit to SaaiAravindhRaja/OpenMetadata that referenced this pull request Apr 12, 2026
SaaiAravindhRaja pushed a commit to SaaiAravindhRaja/OpenMetadata that referenced this pull request Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants