test(playwright): fix GlossaryPagination waitForResponse races (1.12.5)#27114
Conversation
Backport of the GlossaryPagination.spec.ts fix from #25751. Arms waitForResponse listeners before fill/clear actions so the debounced search request isn't missed, and awaits glossary.visitEntityPage. Fixes timeout in "Glossary tests >> should check for glossary term search" on 1.12.5. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
❌ Lint Check Failed — ESLint + Prettier (core-components)The following files have style issues that need to be fixed: Fix locally (fast — only for changed files in the branch): make ui-checkstyle-core-components-changedOr to fix all files: make ui-checkstyle-core-components |
❌ Playwright Lint Check Failed — ESLint + Prettier + Organise ImportsThe following files have style issues that need to be fixed: Fix locally (fast — only for changed files in the branch): make ui-checkstyle-playwright-changedOr to fix all playwright files: make ui-checkstyle-playwright |
Code Review ✅ ApprovedFixes GlossaryPagination waitForResponse race conditions in Playwright tests by resolving timing issues that caused test flakiness. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Summary
Backports the
GlossaryPagination.spec.tsportion of #25751 to1.12.5.The test
Glossary tests >> should check for glossary term searchwas timing out on1.12.5becausepage.waitForResponse(...)was being registered aftersearchInput.fill(...). The debounced search request fires before the listener attaches, so the waiter never resolves and the test hits the 180s timeout.This change arms each response waiter before the corresponding
fill/clearaction, and awaitsglossary.visitEntityPage(page). File is taken verbatim from commit12b364313conmain(PR #25751).A full cherry-pick of #25751 is not viable — it touches 40+ files across metrics, slow-request logging, DB migrations and integration tests, with numerous conflicts against 1.12.5 (including files that only exist on
main). Only the test fix is backported.Test plan
Glossary tests >> should check for glossary term searchpasses🤖 Generated with Claude Code