Skip to content

test(playwright): fix GlossaryPagination waitForResponse races (1.12.5)#27114

Merged
anuj-kumary merged 4 commits into1.12.5from
fix/playwright/glossary-pagination-waitforresponse-1.12.5
Apr 8, 2026
Merged

test(playwright): fix GlossaryPagination waitForResponse races (1.12.5)#27114
anuj-kumary merged 4 commits into1.12.5from
fix/playwright/glossary-pagination-waitforresponse-1.12.5

Conversation

@siddhant1
Copy link
Copy Markdown
Member

Summary

Backports the GlossaryPagination.spec.ts portion of #25751 to 1.12.5.

The test Glossary tests >> should check for glossary term search was timing out on 1.12.5 because page.waitForResponse(...) was being registered after searchInput.fill(...). The debounced search request fires before the listener attaches, so the waiter never resolves and the test hits the 180s timeout.

This change arms each response waiter before the corresponding fill/clear action, and awaits glossary.visitEntityPage(page). File is taken verbatim from commit 12b364313c on main (PR #25751).

A full cherry-pick of #25751 is not viable — it touches 40+ files across metrics, slow-request logging, DB migrations and integration tests, with numerous conflicts against 1.12.5 (including files that only exist on main). Only the test fix is backported.

Test plan

  • CI Playwright run: Glossary tests >> should check for glossary term search passes
  • Nested and case-insensitive glossary search tests in the same spec pass

🤖 Generated with Claude Code

Backport of the GlossaryPagination.spec.ts fix from #25751. Arms
waitForResponse listeners before fill/clear actions so the debounced
search request isn't missed, and awaits glossary.visitEntityPage.

Fixes timeout in "Glossary tests >> should check for glossary term
search" on 1.12.5.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@siddhant1 siddhant1 requested a review from a team as a code owner April 7, 2026 04:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@siddhant1 siddhant1 added the safe to test Add this label to run secure Github workflows on PRs label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

❌ Lint Check Failed — ESLint + Prettier (core-components)

The following files have style issues that need to be fixed:

Fix locally (fast — only for changed files in the branch):

make ui-checkstyle-core-components-changed

Or to fix all files:

make ui-checkstyle-core-components

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

❌ Playwright Lint Check Failed — ESLint + Prettier + Organise Imports

The following files have style issues that need to be fixed:
playwright/e2e/Features/Glossary/GlossaryPagination.spec.ts

Fix locally (fast — only for changed files in the branch):

make ui-checkstyle-playwright-changed

Or to fix all playwright files:

make ui-checkstyle-playwright

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.97% (57437/87058) 45.64% (30363/66518) 48.41% (9115/18828)

@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Apr 8, 2026

Code Review ✅ Approved

Fixes GlossaryPagination waitForResponse race conditions in Playwright tests by resolving timing issues that caused test flakiness. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@anuj-kumary anuj-kumary merged commit d6f7956 into 1.12.5 Apr 8, 2026
33 of 38 checks passed
@anuj-kumary anuj-kumary deleted the fix/playwright/glossary-pagination-waitforresponse-1.12.5 branch April 8, 2026 04:27
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants