Skip to content

Fixed the component re-rendering issue which causes the Entity test failure #27355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshach merged 4 commits into from
Apr 14, 2026
Merged

Fixed the component re-rendering issue which causes the Entity test failure #27355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
717644e
Fixed the component re-rendering issue which causes the Entity test f…
Rohit0301 Apr 14, 2026
e43d809
Merge branch 'main' into fix-entity-spec-failure-aut
Rohit0301 Apr 14, 2026
1d80c0b
fixed DataAssetsTest
Rohit0301 Apr 14, 2026
0bab0e1
fixed loading issue
Rohit0301 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataAssetRulesDisabled.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,19 +196,19 @@ test.describe(
).toBeVisible();

await page
.getByTestId('select-owner-tabs')
.getByRole('tabpanel', { name: /Users/ })
.getByTestId('loader')
.waitFor({ state: 'detached' });
.waitFor({ state: 'hidden' });

await page
.locator("[data-testid='select-owner-tabs']")
.getByRole('tab', { name: 'Teams' })
.click();

await page
.getByTestId('select-owner-tabs')
.getByRole('tabpanel', { name: 'Teams' })
.getByTestId('loader')
.waitFor({ state: 'detached' });
.waitFor({ state: 'hidden' });

const teamsSearchBar = page.getByTestId(
'owner-select-teams-search-bar'
Expand Down
27 changes: 21 additions & 6 deletions openmetadata-ui/src/main/resources/ui/playwright/utils/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,16 @@ export const assignDomain = async (
await waitForAllLoadersToDisappear(page);

if (checkSelectedDomain) {
await expect(page.getByTestId('domain-link')).toContainText(
domain.displayName
);
const hasMultipleDomains = await page
.getByTestId('domain-count-button')
.isVisible();
if (hasMultipleDomains) {
await expect(page.getByTestId('domain-count-button')).toBeVisible();
} else {
await expect(page.getByTestId('domain-link')).toContainText(
domain.displayName
);
}
}
};

Expand Down Expand Up @@ -422,9 +429,17 @@ export const assignDataProduct = async (
action: 'Add' | 'Edit' = 'Add',
parentId = 'KnowledgePanel.DataProducts'
) => {
await expect(page.getByTestId('domain-link')).toContainText(
domain.displayName
);
const hasMultipleDomains = await page
.getByTestId('domain-count-button')
.isVisible();
if (hasMultipleDomains) {
await expect(page.getByTestId('domain-count-button')).toBeVisible();
} else {
await expect(page.getByTestId('domain-link')).toContainText(
domain.displayName
);
}

await page
.getByTestId(parentId)
.getByTestId('data-products-container')
Expand Down
9 changes: 7 additions & 2 deletions ...esources/ui/src/components/common/EntitySelectableList/EntitySelectableList.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* limitations under the License.
*/
import { Popover } from 'antd';
import { useState } from 'react';
import { useMemo, useState } from 'react';
import { ADD_USER_CONTAINER_HEIGHT } from '../../../constants/constants';
import { EntityReference } from '../../../generated/entity/data/table';
import { FocusTrapWithContainer } from '../FocusTrap/FocusTrapWithContainer';
Expand All @@ -30,6 +30,11 @@ export const EntitySelectableList = <T,>({
}: EntitySelectableListProps<T>) => {
const [popupVisible, setPopupVisible] = useState(false);

const selectedItemsAsEntityReferences = useMemo(
() => config.toEntityReference(selectedItems),
[selectedItems, config.toEntityReference]
);

const handleUpdate = async (updateItems: EntityReference[]) => {
const convertedItems = config.fromEntityReference(updateItems);
await onUpdate(convertedItems);
Expand All @@ -49,7 +54,7 @@ export const EntitySelectableList = <T,>({
multiSelect={multiSelect}
searchBarDataTestId={config.searchBarDataTestId}
searchPlaceholder={config.searchPlaceholder}
selectedItems={config.toEntityReference(selectedItems)}
selectedItems={selectedItemsAsEntityReferences}
onCancel={onCancel}
onUpdate={handleUpdate}
/>
Expand Down
Loading