Fixes #26939: Add FQN subtitle to Custom Property entity references#27362
Fixes #26939: Add FQN subtitle to Custom Property entity references#27362mohitjeswani01 wants to merge 3 commits intoopen-metadata:mainfrom
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
There was a problem hiding this comment.
Pull request overview
Updates Custom Property entity reference rendering in the UI to include the referenced entity’s fully qualified name (FQN) as a secondary subtitle, improving disambiguation when multiple entities share the same display name.
Changes:
- Render
item.fullyQualifiedNameas a muted subtitle under the primary entity name for entity reference values. - Adjust and add Jest tests to validate FQN subtitle rendering for
entityReferenceandentityReferenceListcases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/PropertyValue.tsx | Adds a second (muted) line under entity reference names to display FQN when available. |
| openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/PropertyValue.test.tsx | Updates existing assertions and adds coverage for FQN subtitle rendering and fallback behavior. |
|
|
||
| // Asserting that the subtitle did not mistakenly render 'undefined' or an empty variable text | ||
| expect(screen.queryByText('undefined')).not.toBeInTheDocument(); |
There was a problem hiding this comment.
The negative assertion here is too broad: checking that the literal text 'undefined' is absent doesn't actually verify that the FQN subtitle element is not rendered (and could also give false confidence if the subtitle renders as an empty string). Prefer asserting that the FQN subtitle node is absent, e.g., by querying for the known FQN text, or by adding a dedicated test id/role for the subtitle and asserting it is not in the document when fullyQualifiedName is missing.
| // Asserting that the subtitle did not mistakenly render 'undefined' or an empty variable text | |
| expect(screen.queryByText('undefined')).not.toBeInTheDocument(); | |
| expect( | |
| screen.queryByText('service.schema.entityReferenceName') | |
| ).not.toBeInTheDocument(); |
harshach
added
the
safe to test
Jest test CoverageUI tests summary
|
Code Review ✅ ApprovedAdds FQN subtitles to Custom Property entity references to resolve the visibility issue in #26939. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
🟡 Playwright Results — all passed (26 flaky)✅ 3630 passed · ❌ 0 failed · 🟡 26 flaky · ⏭️ 84 skipped
🟡 26 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
|
Hello @mohitjeswani01, thank you for your pr, but we already have on for this here, so I will be closing this pr. Please make sure that you are assigned an issue before submitting code for it. We will reopen this if necessary. |
Description:
Fixes #26939
I worked on updating the rendering logic inside
CustomPropertyTable/PropertyValue.tsxto display thefullyQualifiedName(FQN) as a secondary, muted subtitle beneath the primary entity name. This resolves an issue where multiple tables/entities sharing the exact same name across different remote systems could not be safely distinguished. The layout now follows the establishedgetEntityLabelpattern for UI consistency and falls back safely when the FQN is absent.All related testing scenarios have successfully passed.
Test Results
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>