fix(search): add tiebreaker sort to prevent export truncation on numeric sort fields#27429
Closed
harsh-vador wants to merge 2 commits intomainfrom
Closed
fix(search): add tiebreaker sort to prevent export truncation on numeric sort fields#27429harsh-vador wants to merge 2 commits intomainfrom
harsh-vador wants to merge 2 commits intomainfrom
Conversation
harsh-vador
added
safe to test
Code Review ✅ ApprovedAdds a tiebreaker sort to the search implementation to ensure consistent ordering and prevent export truncation on numeric fields. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Contributor
🟡 Playwright Results — all passed (21 flaky)✅ 3639 passed · ❌ 0 failed · 🟡 21 flaky · ⏭️ 89 skipped
🟡 21 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Problem
Search export truncated at ~1000 rows when sorting by numeric fields (e.g. totalVotes).
Root cause:
search_after pagination with no tiebreaker. When many documents share the same totalVotes value (e.g. 0), the cursor search_after=[0] asks for docs where totalVotes < 0 → empty batch → loop breaks early.
Fix
Add name.keyword ASC as a tiebreaker sort whenever:
_score(was already present, now uses constants)isExport=true— new flag passed to buildSearchRequestBuilder to distinguish export calls from regular searchThis guarantees a unique cursor per document regardless of the primary sort field, enabling stable
search_afterpagination across all 50K+ rows.Changes
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>