Fixes #27434: Add missing fontSize to SelectContext in Combobox and Autocomplete by RajdeepKushwaha5 · Pull Request #27435 · open-metadata/OpenMetadata

RajdeepKushwaha5 · 2026-04-16T12:30:33Z

Describe your changes:

PR #27379 added fontSize as a required property to SelectContext in select.tsx, but the two other components that also provide this context — combobox.tsx and autocomplete.tsx — were not updated. This causes a TS2741 TypeScript build error on main, blocking CI for all open PRs.

This PR adds the missing fontSize: 'md' (the same default used in select.tsx) to both providers:

combobox.tsx: SelectContext.Provider value={{ fontSize: 'md', size }}
autocomplete.tsx: selectContextValue now includes fontSize: 'md' as const

How I tested: Ran npx tsc --noEmit in openmetadata-ui-core-components/src/main/resources/ui — build passes with zero errors after this change.

cc @anuj-kumary

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

github-actions · 2026-04-16T12:31:00Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copilot

Pull request overview

Fixes a TypeScript build break in openmetadata-ui-core-components by ensuring all SelectContext.Provider usages provide the newly-required fontSize property (introduced in #27379).

Changes:

Add fontSize: 'md' to the SelectContext.Provider value in combobox.tsx.
Add fontSize: 'md' to the memoized selectContextValue used by autocomplete.tsx.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/select/combobox.tsx	Updates `SelectContext.Provider` value to include required `fontSize` (default `'md'`).
openmetadata-ui-core-components/src/main/resources/ui/src/components/base/autocomplete/autocomplete.tsx	Updates `selectContextValue` to include required `fontSize` (default `'md'`) to satisfy `SelectContext` typing.

RajdeepKushwaha5 · 2026-04-16T12:34:22Z

This is a 2-line fix for the TypeScript build error on main introduced by #27379. Could a maintainer add the safe to test label? This is blocking CI on all open PRs.

github-actions · 2026-04-16T16:20:31Z

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

RajdeepKushwaha5 · 2026-04-16T16:26:39Z

🚨 CI blocker — tiny 2-file fix ready for review/merge

Hey @PubChimps @harshach — opened a focused PR to unblock CI on main:

PR: <https://github.com/open-metadata/OpenMetadata/pull/27435|#27435 — Fixes #27434: Add missing fontSize to SelectContext in Combobox and Autocomplete>
Issue: https://github.com/open-metadata/OpenMetadata/issues/27434|#27434

Why this is urgent:
PR #27379 (merged 2026-04-15) made fontSize a required field on SelectContext, but only updated select.tsx. combobox.tsx and autocomplete.tsx also provide that context and were missed, so main is now failing tsc --noEmit with TS2741. This is blocking UI CI on every open PR — rebasing doesn't help.

The fix (6 lines, 2 files):
• combobox.tsx — destructure fontSize = 'md' from props and pass it through the provider (threads the existing ComboBoxProps.fontSize correctly — addressed Copilot's review comment)
• autocomplete.tsx — add fontSize: 'md' as const to the memoized context value (no prop exists on AutocompleteProps, so hardcoding the default matches createContext's default)

Validation: npx tsc --noEmit passes clean in openmetadata-ui-core-components/src/main/resources/ui. Zero behavior change — 'md' is the same default already used in select.tsx and createContext.

Review status:
• ✅ Gitar bot — approved
• ✅ Copilot AI — 1 comment, now addressed in latest push

Could a maintainer please add the safe to test label and take a look? cc @anuj-kumary (author of #27379) @chirag-madlani @karanh37

Thanks! 🙏

aniketkatkar97 · 2026-04-16T16:36:36Z

Thank you @RajdeepKushwaha5

github-actions · 2026-04-16T18:32:24Z

🟡 Playwright Results — all passed (28 flaky)

✅ 3659 passed · ❌ 0 failed · 🟡 28 flaky · ⏭️ 89 skipped

Shard	Passed	Flaky	Skipped
🟡 Shard 1	477	4	4
🟡 Shard 2	651	2	7
🟡 Shard 3	653	6	1
🟡 Shard 4	629	5	27
🟡 Shard 5	610	1	42
🟡 Shard 6	639	10	8

🟡 28 flaky test(s) (passed on retry)

Features/CustomizeDetailPage.spec.ts › Domain - customization should work (shard 1, 1 retry)
Flow/Tour.spec.ts › Tour should work from URL directly (shard 1, 1 retry)
Pages/Customproperties-part1.spec.ts › no duplicate card after update (shard 1, 1 retry)
Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
Features/Glossary/GlossaryWorkflow.spec.ts › should inherit reviewers from glossary when term is created (shard 2, 1 retry)
Features/ImpactAnalysis.spec.ts › Verify table columns visibility and content (shard 3, 1 retry)
Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 2 retries)
Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
Pages/Customproperties-part2.spec.ts › Entity Reference List (shard 3, 1 retry)
Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
Pages/DataContracts.spec.ts › Create Data Contract and validate for Worksheet (shard 4, 1 retry)
Pages/Domains.spec.ts › Should clear assets from data products after deletion of data product in Domain (shard 4, 1 retry)
Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4, 1 retry)
Pages/Entity.spec.ts › Glossary Term Add, Update and Remove (shard 4, 1 retry)
Pages/Glossary.spec.ts › Add and Remove Assets (shard 5, 1 retry)
Pages/Glossary.spec.ts › Column dropdown drag-and-drop functionality for Glossary Terms table (shard 6, 1 retry)
Pages/HyperlinkCustomProperty.spec.ts › should accept valid http and https URLs (shard 6, 1 retry)
Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for topic -> searchIndex (shard 6, 1 retry)
Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
Pages/Tag.spec.ts › Delete a Tag (shard 6, 2 retries)
Pages/Tag.spec.ts › Add and Remove Assets for Data Steward (shard 6, 2 retries)
Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
VersionPages/ClassificationVersionPage.spec.ts › Classification version page (shard 6, 1 retry)
VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

…Autocomplete Unblocks CI on this PR. main is currently failing tsc --noEmit with TS2741 because open-metadata#27379 made fontSize a required field on SelectContext but only updated select.tsx. combobox.tsx and autocomplete.tsx also provide that context and were missed, cascading into all py-tests and Playwright failures on every open PR. Mirrors the fix in PR open-metadata#27435.

…mplete PR open-metadata#27379 added fontSize as a required property to SelectContext but only updated select.tsx. This adds the missing fontSize property to combobox.tsx and autocomplete.tsx to fix the TypeScript build error (TS2741) that is currently blocking CI on all open PRs.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

gitar-bot · 2026-04-20T04:33:38Z

Code Review ✅ Approved

Adds missing fontSize to SelectContext within Combobox and Autocomplete components to ensure consistent typography. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

RajdeepKushwaha5 · 2026-04-20T07:13:19Z

ping @chirag-madlani

RajdeepKushwaha5 requested review from chirag-madlani and karanh37 as code owners April 16, 2026 12:30

Copilot AI review requested due to automatic review settings April 16, 2026 12:30

Copilot started reviewing on behalf of RajdeepKushwaha5 April 16, 2026 12:31 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread openmetadata-ui-core-components/src/main/resources/ui/src/components/base/select/combobox.tsx Outdated

RajdeepKushwaha5 force-pushed the fix/select-context-fontSize-missing branch from 7224014 to 486ee21 Compare April 16, 2026 16:20

anuj-kumary added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Apr 16, 2026

aniketkatkar97 approved these changes Apr 16, 2026

View reviewed changes

harshach had a problem deploying to test April 16, 2026 16:49 — with GitHub Actions Failure

harshach temporarily deployed to test April 16, 2026 16:49 — with GitHub Actions Inactive

harshach had a problem deploying to test April 16, 2026 16:49 — with GitHub Actions Failure

Copilot AI review requested due to automatic review settings April 17, 2026 02:26

RajdeepKushwaha5 force-pushed the fix/select-context-fontSize-missing branch from fa54f51 to 98ae3bb Compare April 17, 2026 02:26

Copilot started reviewing on behalf of RajdeepKushwaha5 April 17, 2026 02:27 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

RajdeepKushwaha5 temporarily deployed to test April 17, 2026 02:35 — with GitHub Actions Inactive

Merge branch 'main' into fix/select-context-fontSize-missing

b62a7d5

karanh37 approved these changes Apr 17, 2026

View reviewed changes

anuj-kumary had a problem deploying to test April 17, 2026 09:39 — with GitHub Actions Failure

anuj-kumary temporarily deployed to test April 17, 2026 09:39 — with GitHub Actions Inactive

Merge branch 'main' into fix/select-context-fontSize-missing

8dcc4be

Copilot AI review requested due to automatic review settings April 19, 2026 18:09

Copilot started reviewing on behalf of RajdeepKushwaha5 April 19, 2026 18:09 View session

Copilot AI reviewed Apr 19, 2026

View reviewed changes

RajdeepKushwaha5 temporarily deployed to test April 19, 2026 18:21 — with GitHub Actions Inactive

RajdeepKushwaha5 had a problem deploying to test April 19, 2026 18:21 — with GitHub Actions Failure

RajdeepKushwaha5 temporarily deployed to test April 19, 2026 18:21 — with GitHub Actions Inactive

RajdeepKushwaha5 had a problem deploying to test April 19, 2026 18:21 — with GitHub Actions Failure

Merge branch 'main' into fix/select-context-fontSize-missing

8b195bd

chirag-madlani temporarily deployed to test April 20, 2026 04:42 — with GitHub Actions Inactive

chirag-madlani merged commit b1879a4 into open-metadata:main Apr 20, 2026
38 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #27434: Add missing fontSize to SelectContext in Combobox and Autocomplete#27435

Fixes #27434: Add missing fontSize to SelectContext in Combobox and Autocomplete#27435
chirag-madlani merged 4 commits intoopen-metadata:mainfrom
RajdeepKushwaha5:fix/select-context-fontSize-missing

RajdeepKushwaha5 commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

RajdeepKushwaha5 commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

RajdeepKushwaha5 commented Apr 16, 2026

Uh oh!

aniketkatkar97 commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

gitar-bot Bot commented Apr 20, 2026 •

edited

Loading

Uh oh!

RajdeepKushwaha5 commented Apr 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

RajdeepKushwaha5 commented Apr 16, 2026

Describe your changes:

Type of change:

Checklist:

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

RajdeepKushwaha5 commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

RajdeepKushwaha5 commented Apr 16, 2026

Uh oh!

aniketkatkar97 commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟡 Playwright Results — all passed (28 flaky)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

gitar-bot Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RajdeepKushwaha5 commented Apr 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions Bot commented Apr 16, 2026 •

edited

Loading

gitar-bot Bot commented Apr 20, 2026 •

edited

Loading