Skip to content

Feat: Entity auto registration in topology#27450

Draft
harshsoni2024 wants to merge 1 commit intomainfrom
entity_auto_registration
Draft

Feat: Entity auto registration in topology#27450
harshsoni2024 wants to merge 1 commit intomainfrom
entity_auto_registration

Conversation

@harshsoni2024
Copy link
Copy Markdown
Contributor

Describe your changes:

Auto-registration in the Topology Framework

Problem:

  • Every connector must manually call self.register_record_(request) after yield Either(right=request). If a connector forgets self.register_record_, mark__as_deleted sees an empty source state and soft-deletes every entity for that service.

Improvement:

  • Add a source_state field to NodeStage that names the attribute on the source where FQNs should be collected. The topology runner auto-registers entity FQNs into this set after a successful yield — no connector code needed.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshsoni2024 harshsoni2024 changed the title Feat: entity auto registration in topology Feat: Entity auto registration in topology Apr 17, 2026
@github-actions github-actions Bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Apr 17, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 17, 2026

Code Review ✅ Approved

Implements entity auto-registration within the topology system to streamline resource discovery. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

store_all_in_context=True,
clear_context=True,
use_cache=True,
source_state="datamodel_source_state",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not even need this, just build it on the fly based on the context/type_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants