Upgrade CodeMirror v5 to v6

[Copilot]

• Investigate workflow failures on branch
• Identify root cause: All 5 CI failures caused by "Team Label" gate (lewagon/wait-on-check-action) — not code issues
• Verify code checks pass locally (ESLint ✅, TypeScript ✅, Jest ✅)
• Fix Create teams page similar to tags #1: Import ordering — organize-imports reorders @uiw/react-codemirror alphabetically before antd and @lezer/highlight before @toast-ui/editor
• Fix Replace catalog to openmetadata #2: Code review feedback — simplify early return in runHighlight
• Confirm all 52 unit tests pass (SchemaEditor + CodeEditor + ContractYaml)
• Run parallel validation — Code Review ✅, CodeQL ✅

fixes 3721

---

Summary by Gitar

• Component enhancements:
  • Updated SchemaEditor and CodeEditor to support dynamic line numbers and line wrapping via options.
  • Added support for readOnly: 'nocursor' as a valid configuration option.
• Testing infrastructure:
  • Introduced fillCodeMirrorEditor utility in Playwright to standardize interaction with CM6 editors.
  • Added unit tests for SchemaEditor and CodeEditor covering prop handling and configuration.
• Fixes:
  • Improved Playwright selectors for entity and tag selection to be more robust.
  • Fixed runHighlight to correctly include React keys for code fragments.

_{This will update automatically on new commits.}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

[gitar-bot]

Code Review ✅ Approved 3 resolved / 3 findings

CodeMirror v6 migration completes with native prop handling for line numbers, wrapping, and read-only states. All previous configuration discrepancies and React key warnings are resolved.

✅ 3 resolved

✅ Bug: Top-level readOnly prop and CM5 string values silently ignored

📄 openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/SchemaEditor.tsx:57 📄 openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/CodeEditor.tsx:55 📄 openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/SchemaEditor.interface.ts:24 📄 openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/SchemaEditor.interface.ts:28
Two related issues with read-only handling:

1. SchemaEditorProps defines a top-level readOnly?: boolean prop (line 24 of interface), but neither SchemaEditor.tsx nor CodeEditor.tsx destructure or use it. CodeWidget.tsx passes readOnly={disabled} as a direct prop, which is now silently ignored — the editor will be editable when it should be read-only.

2. QueryCard.tsx:248 passes readOnly: isEditMode ? false : 'nocursor' inside options. The CM5 string value 'nocursor' was valid in v5 but the new code checks options?.readOnly === true, which is false for 'nocursor'. This means the query viewer will be editable when not in edit mode, breaking the read-only behavior.

Both issues cause editors to be editable when they should be locked.

✅ Bug: Missing React key prop on plain code block fragment

📄 openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/CustomHtmlRederer/CustomHtmlRederer.tsx:174
In CustomHtmlRederer.tsx line 174, the fallback plain code block creates a React.Fragment without a key prop: [<React.Fragment>{codeText}</React.Fragment>]. While it's a single-element array so React won't warn currently, this is inconsistent with the runHighlight function which properly keys all fragments, and could cause issues if the array is later combined with other elements.

✅ Bug: options.lineNumbers and options.lineWrapping are silently ignored

📄 openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/SchemaEditor.interface.ts:26-27 📄 openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/SchemaEditor.tsx:59-70 📄 openmetadata-ui/src/main/resources/ui/src/components/Database/SchemaEditor/CodeEditor.tsx:57-66
The SchemaEditorProps interface defines lineNumbers and lineWrapping in the options type, but neither SchemaEditor.tsx nor CodeEditor.tsx reads these values to conditionally add/remove the corresponding CM6 extensions. SchemaEditor always enables both lineNumbers() and EditorView.lineWrapping, while CodeEditor always disables both. No current callers override these, but the interface suggests they should be configurable. Either wire them into the extensions array or remove them from the interface to avoid confusion.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}