Skip to content

(playwright) Stabilize Teams Hierarchy spec and replace toast-based team deletion checks#27470

Merged
harsh-vador merged 2 commits intomainfrom
fix-flaky-teams-hierarchy-spec
Apr 20, 2026
Merged

(playwright) Stabilize Teams Hierarchy spec and replace toast-based team deletion checks#27470
harsh-vador merged 2 commits intomainfrom
fix-flaky-teams-hierarchy-spec

Conversation

@harsh-vador
Copy link
Copy Markdown
Contributor

@harsh-vador harsh-vador commented Apr 17, 2026

Describe your changes:

Summary

This PR improves Playwright test reliability by tightening search export coverage and replacing a toast-only team deletion assertion with a real UI validation.

Changes

  • Stabilized SearchExport.spec.ts to rely on real page behavior for export count validation
  • Added end-to-end coverage for:
    • visible export count matching the first tab count
    • filtered result count matching exported CSV row count
    • browse/search export row count validation
  • Tightened waitForResponse usage to only resolve on successful 200 search responses
  • Isolated the > 200k assets export-limit behavior into a standalone mocked test
  • Replaced the toast assertion in TeamsHierarchy.spec.ts after team deletion with a stronger check:
    • search for the deleted team
    • assert no results are returned
Screenshot 2026-04-17 at 3 44 32 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harsh-vador harsh-vador self-assigned this Apr 17, 2026
@harsh-vador harsh-vador requested a review from a team as a code owner April 17, 2026 10:18
@harsh-vador harsh-vador added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Apr 17, 2026
@harsh-vador harsh-vador changed the title (playwright) Stabilize Playwright export coverage and replace toast-b… (playwright) Stabilize Playwright export coverage and replace toast-based team deletion checks Apr 17, 2026
@harsh-vador harsh-vador changed the title (playwright) Stabilize Playwright export coverage and replace toast-based team deletion checks (playwright) Stabilize Teams Hierarchy spec and replace toast-based team deletion checks Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.31% (59282/93635) 43.61% (31448/72106) 46.49% (9435/20293)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

🟡 Playwright Results — all passed (21 flaky)

✅ 3666 passed · ❌ 0 failed · 🟡 21 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 480 0 1 4
🟡 Shard 2 649 0 4 7
🟡 Shard 3 655 0 4 1
🟡 Shard 4 630 0 4 27
🟡 Shard 5 609 0 2 42
🟡 Shard 6 643 0 6 8
🟡 21 flaky test(s) (passed on retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/ActivityFeed.spec.ts › emoji reactions can be added when feed messages exist (shard 2, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/DataProductPersonaCustomization.spec.ts › Data Product - customize tab label should only render if it's customized by user (shard 2, 1 retry)
  • Features/Glossary/LargeGlossaryPerformance.spec.ts › should handle large number of glossary terms with pagination (shard 2, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Flow/AddRoleAndAssignToUser.spec.ts › Verify assigned role to new user (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Table (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Announcement create, edit & delete (shard 4, 1 retry)
  • Pages/EntityDataConsumer.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/EntityDataConsumer.spec.ts › Tier Add, Update and Remove (shard 5, 2 retries)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Data Model (shard 6, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for mlModel -> apiEndpoint (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 20, 2026

Code Review ✅ Approved

Stabilizes the Teams Hierarchy spec by replacing toast-based team deletion checks with more reliable assertions. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@harsh-vador harsh-vador merged commit df46180 into main Apr 20, 2026
46 checks passed
@harsh-vador harsh-vador deleted the fix-flaky-teams-hierarchy-spec branch April 20, 2026 12:13
harsh-vador added a commit that referenced this pull request Apr 20, 2026
…ased team deletion checks (#27470)

(cherry picked from commit df46180)
@github-actions
Copy link
Copy Markdown
Contributor

Failed to cherry-pick changes to the 1.12.6 branch.
Please cherry-pick the changes manually.
You can find more details here.

harsh-vador added a commit that referenced this pull request Apr 20, 2026
…ased team deletion checks (#27470)

(cherry picked from commit df46180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants