Skip to content

Fix aut flakiness restore entity inherited fields.spec.ts#27534

Merged
shrabantipaul-collate merged 15 commits intomainfrom
fix-aut-flakiness-RestoreEntityInheritedFields.spec.ts
Apr 21, 2026
Merged

Fix aut flakiness restore entity inherited fields.spec.ts#27534
shrabantipaul-collate merged 15 commits intomainfrom
fix-aut-flakiness-RestoreEntityInheritedFields.spec.ts

Conversation

@shrabantipaul-collate
Copy link
Copy Markdown
Contributor

@shrabantipaul-collate shrabantipaul-collate commented Apr 20, 2026

Describe your changes:

  • RestoreEntityInheritedFields.spec.ts: assign domain+DP on parent via UI; navigate entity-count tab for service pages; poll for inherited domain using waitForResponse before checking domain-link

  • CustomizeDetailPage.spec.ts: fix stale testid widget-info-tabs → add-widget-modal

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test Navigation & Logic:
    • Added SERVICE_ENTITY_TAB mapping to correctly navigate to service-specific tabs before assigning data products.
    • Implemented isDbEntity and is3Breadcrumb flags to handle navigation differences between table-like and service-management pages.
  • Test Flakiness Mitigation:
    • Replaced hard-coded assignment flow with a robust expect.poll loop in RestoreEntityInheritedFields.spec.ts that includes page reloads and API response synchronization.
  • UI Interaction Fix:
    • Updated CustomizeDetailPage.spec.ts to check for add-widget-modal visibility instead of the widget info tabs to avoid race conditions.

This will update automatically on new commits.

@shrabantipaul-collate shrabantipaul-collate added the safe to test Add this label to run secure Github workflows on PRs label Apr 20, 2026
@shrabantipaul-collate shrabantipaul-collate requested a review from a team as a code owner April 20, 2026 06:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
61.95% (60279/97287) 41.99% (31619/75292) 45% (9496/21098)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

🟡 Playwright Results — all passed (19 flaky)

✅ 3692 passed · ❌ 0 failed · 🟡 19 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 481 0 0 4
🟡 Shard 2 652 0 4 7
🟡 Shard 3 663 0 3 1
🟡 Shard 4 643 0 5 27
✅ Shard 5 611 0 0 42
🟡 Shard 6 642 0 7 8
🟡 19 flaky test(s) (passed on retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/BulkImport.spec.ts › Keyboard Delete selection (shard 2, 1 retry)
  • Features/ColumnBulkOperations.spec.ts › should show no results when searching for nonexistent column (shard 2, 1 retry)
  • Features/Glossary/GlossaryHierarchy.spec.ts › should cancel move operation (shard 2, 1 retry)
  • Features/IncidentManager.spec.ts › Complete Incident lifecycle with table owner (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for SearchIndex (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for File (shard 4, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate Owner Rule Any_In (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Inactive Announcement create & delete (shard 4, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/ODCSImportExport.spec.ts › Import ODCS missing status from test-data file shows error (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)
  • Pages/Users.spec.ts › Should navigate to user profile from feed card avatar click (shard 6, 2 retries)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 21, 2026

Code Review ✅ Approved

Stabilizes the entity inherited fields test suite by addressing intermittent timing issues during state restoration. No issues were found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@shrabantipaul-collate shrabantipaul-collate merged commit 0deb78b into main Apr 21, 2026
47 checks passed
@shrabantipaul-collate shrabantipaul-collate deleted the fix-aut-flakiness-RestoreEntityInheritedFields.spec.ts branch April 21, 2026 11:06
jatinmasaram pushed a commit to jatinmasaram/OpenMetadata that referenced this pull request May 2, 2026
…ata#27534)

* increase data contracts test timeout

* fix flakiness in RestoreEntityInheritedFields.spec.ts and CustomizeDetailPage.spec.ts

* Fix RestoreEntityInheritedFields flakiness

* fix RestoreEntityInheritedFields flakiness

* fix RestoreEntityInheritedFields flakiness

* fix lint issues

* fix one minor flaky test

---------

Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants