Fix aut flakiness restore entity inherited fields.spec.ts#27534
Merged
shrabantipaul-collate merged 15 commits intomainfrom Apr 21, 2026
Merged
Fix aut flakiness restore entity inherited fields.spec.ts#27534shrabantipaul-collate merged 15 commits intomainfrom
shrabantipaul-collate merged 15 commits intomainfrom
Conversation
added 7 commits
April 15, 2026 12:39
Contributor
Contributor
🟡 Playwright Results — all passed (19 flaky)✅ 3692 passed · ❌ 0 failed · 🟡 19 flaky · ⏭️ 89 skipped
🟡 19 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedStabilizes the entity inherited fields test suite by addressing intermittent timing issues during state restoration. No issues were found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
ShaileshParmar11
approved these changes
Apr 21, 2026
jatinmasaram
pushed a commit
to jatinmasaram/OpenMetadata
that referenced
this pull request
May 2, 2026
…ata#27534) * increase data contracts test timeout * fix flakiness in RestoreEntityInheritedFields.spec.ts and CustomizeDetailPage.spec.ts * Fix RestoreEntityInheritedFields flakiness * fix RestoreEntityInheritedFields flakiness * fix RestoreEntityInheritedFields flakiness * fix lint issues * fix one minor flaky test --------- Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes:
RestoreEntityInheritedFields.spec.ts: assign domain+DP on parent via UI; navigate entity-count tab for service pages; poll for inherited domain using waitForResponse before checking domain-link
CustomizeDetailPage.spec.ts: fix stale testid widget-info-tabs → add-widget-modal
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
SERVICE_ENTITY_TABmapping to correctly navigate to service-specific tabs before assigning data products.isDbEntityandis3Breadcrumbflags to handle navigation differences between table-like and service-management pages.expect.pollloop inRestoreEntityInheritedFields.spec.tsthat includes page reloads and API response synchronization.CustomizeDetailPage.spec.tsto check foradd-widget-modalvisibility instead of the widget info tabs to avoid race conditions.This will update automatically on new commits.