Skip to content

Fix (#27660): Re-enable Exasol cli-e2e-tests after fixing issues#27661

Open
ArBridgeman wants to merge 7 commits intoopen-metadata:mainfrom
exasol:fix/enable-exasol-cli-e2e-tests
Open

Fix (#27660): Re-enable Exasol cli-e2e-tests after fixing issues#27661
ArBridgeman wants to merge 7 commits intoopen-metadata:mainfrom
exasol:fix/enable-exasol-cli-e2e-tests

Conversation

@ArBridgeman
Copy link
Copy Markdown
Contributor

@ArBridgeman ArBridgeman commented Apr 23, 2026

Describe your changes:

Fixes #27660

To re-enable the Exasol cli-e2e-tests, I:

  • set up my local environment per OpenMetadata's documentation, including the pre-commit hooks
  • updated the installed ITDE in the setup.py
  • modified the test setup in ingestion/tests/cli_e2e/test_cli_exasol.py
  • ran all tests locally in my VM
  • added additional information for contacting us if issues arise again
  • added "exasol" again in the .github/workflows/py-cli-e2e-tests.yml

I worked on the tests because we would like to ensure that the Exasol connector continues to work.
Most of our tests are centralized in the ingestion/tests/cli_e2e/test_cli_exasol.py, so it is critical that these are regular run, and if there are issues, it would be helpful if we were contacted.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug Fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

Summary by Gitar

  • Linter compliance:
    • Added numerous inline # noqa comments across exasol ingestion source and CLI tests to suppress linting errors after migration to ruff.
  • Dependency updates:
    • Updated basedpyright to ~=1.39.0 and added nox to development dependencies in setup.py.

This will update automatically on new commits.

@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

🟡 Playwright Results — all passed (15 flaky)

✅ 3960 passed · ❌ 0 failed · 🟡 15 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 299 0 0 4
🟡 Shard 2 741 0 4 8
🟡 Shard 3 744 0 4 7
🟡 Shard 4 754 0 5 18
✅ Shard 5 687 0 0 41
🟡 Shard 6 735 0 2 8
🟡 15 flaky test(s) (passed on retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
  • Features/DataQuality/DataQuality.spec.ts › TestCase filters (shard 2, 1 retry)
  • Features/Glossary/GlossaryWorkflow.spec.ts › should start term as Draft when glossary has reviewers (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Features/Workflows/WorkflowOssRestrictions.spec.ts › event-type-select is disabled in OSS (shard 3, 1 retry)
  • Flow/AddRoleAndAssignToUser.spec.ts › Verify assigned role to new user (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Should clear search and show all properties for apiCollection in right panel (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Pipeline (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for SearchIndex (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Worksheet (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Create DataProducts and add remove assets (shard 4, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for dashboardDataModel -> topic (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@ArBridgeman
Copy link
Copy Markdown
Contributor Author

Hi @ulixius9

If it's possible, could I get feedback on this PR?

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 28, 2026

Code Review ✅ Approved

Re-enables Exasol cli-e2e-tests following previous stability fixes. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'open-metadata-ingestion'

Failed conditions
0.0% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable Exasol's ingestion/tests/cli_e2e/test_cli_exasol.py tests

3 participants