Fix notification alert sources: add Domain and Data Product, remove deprecated Location#27683
Open
Fix notification alert sources: add Domain and Data Product, remove deprecated Location#27683
Conversation
Contributor
🟡 Playwright Results — all passed (17 flaky)✅ 3957 passed · ❌ 0 failed · 🟡 17 flaky · ⏭️ 86 skipped
🟡 17 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
32b7957 to
ceaa0a6
Compare
ceaa0a6 to
9562df0
Compare
9562df0 to
a2f5914
Compare
…eprecated Location Fixes #27682
a2f5914 to
91c2ea8
Compare
Code Review ✅ ApprovedUpdates notification alert sources by adding Domain and Data Product fields while removing the deprecated Location field. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #27682
Summary
The Source dropdown in Settings → Notifications → Alerts → Create Alert is populated from
GET /api/v1/events/subscriptions/Notification/resources, which is backed byEventSubResourceDescriptor.json.This PR updates that descriptor file to:
domain— with filters: owner, FQN, event type, updater, general metadata events, updater-is-bot.filterByDomainis intentionally omitted because theDomainentity does not expose adomainsfield (it usesparent).dataProduct— with the same filter set used for other data assets (chart, dashboard, database, etc.), includingfilterByDomainsince Data Products belong to domains.location— this is a deprecated entity type that should not appear as a notification source.No Java code, no schema enum, no new filter functions are required — every filter referenced already exists in
FilterFunctionsDescriptor.jsonand is implemented inAlertsRuleEvaluator.java. The registry is reloaded on application startup.Verification
Entity.DOMAIN = "domain",Entity.DATA_PRODUCT = "dataProduct".domain.json,dataProduct.json) to ensure the fields they read actually exist on the target entity.Test plan
GET /api/v1/events/subscriptions/Notification/resourcesand confirmdomainanddataProductare present andlocationis absent.DomainandData Productappear in the Source dropdown, andLocationno longer does.Data Productas the source andfilterByDomainconfigured; perform an update to a Data Product in the matching domain and verify the alert fires.Domainas the source; update a Domain and verify the alert fires.Summary by Gitar
17738ec2which adds a warning message when searching for terms.This will update automatically on new commits.