Skip to content

Fix notification alert sources: add Domain and Data Product, remove deprecated Location#27683

Open
manerow wants to merge 2 commits intomainfrom
fix/notification-alert-sources-domain-dataproduct
Open

Fix notification alert sources: add Domain and Data Product, remove deprecated Location#27683
manerow wants to merge 2 commits intomainfrom
fix/notification-alert-sources-domain-dataproduct

Conversation

@manerow
Copy link
Copy Markdown
Contributor

@manerow manerow commented Apr 24, 2026

Fixes #27682

Summary

The Source dropdown in Settings → Notifications → Alerts → Create Alert is populated from GET /api/v1/events/subscriptions/Notification/resources, which is backed by EventSubResourceDescriptor.json.

This PR updates that descriptor file to:

  • Add domain — with filters: owner, FQN, event type, updater, general metadata events, updater-is-bot. filterByDomain is intentionally omitted because the Domain entity does not expose a domains field (it uses parent).
  • Add dataProduct — with the same filter set used for other data assets (chart, dashboard, database, etc.), including filterByDomain since Data Products belong to domains.
  • Remove location — this is a deprecated entity type that should not appear as a notification source.

No Java code, no schema enum, no new filter functions are required — every filter referenced already exists in FilterFunctionsDescriptor.json and is implemented in AlertsRuleEvaluator.java. The registry is reloaded on application startup.

Verification

  • Entity type strings match canonical constants: Entity.DOMAIN = "domain", Entity.DATA_PRODUCT = "dataProduct".
  • All filters chosen were checked against the corresponding schemas (domain.json, dataProduct.json) to ensure the fields they read actually exist on the target entity.

Test plan

  • Start a local server; hit GET /api/v1/events/subscriptions/Notification/resources and confirm domain and dataProduct are present and location is absent.
  • In the UI, open the Create Alert form and verify Domain and Data Product appear in the Source dropdown, and Location no longer does.
  • Create a notification alert with Data Product as the source and filterByDomain configured; perform an update to a Data Product in the matching domain and verify the alert fires.
  • Create a notification alert with Domain as the source; update a Domain and verify the alert fires.

Summary by Gitar

  • Miscellaneous:
    • Included changes from commit 17738ec2 which adds a warning message when searching for terms.

This will update automatically on new commits.

@manerow manerow added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

🟡 Playwright Results — all passed (17 flaky)

✅ 3957 passed · ❌ 0 failed · 🟡 17 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 298 0 1 4
🟡 Shard 2 739 0 5 8
🟡 Shard 3 746 0 2 7
🟡 Shard 4 756 0 3 18
🟡 Shard 5 686 0 1 41
🟡 Shard 6 732 0 5 8
🟡 17 flaky test(s) (passed on retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
  • Features/DomainFilterQueryFilter.spec.ts › Subdomain assets should be visible when parent domain is selected (shard 2, 1 retry)
  • Features/DomainFilterQueryFilter.spec.ts › Domain filter should work with different asset types (shard 2, 1 retry)
  • Features/LandingPageWidgets/DomainWidgetFilter.spec.ts › Domains widget should show only selected domain when domain filter is active (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Flow/SchemaTable.spec.ts › schema table test (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Should verify property name is visible for apiCollection in right panel (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Directory (shard 4, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate Owner Rule Not_In (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Inactive Announcement create & delete (shard 5, 1 retry)
  • Features/AutoPilot.spec.ts › Create Service and check the AutoPilot status (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Tier Add, Update and Remove (shard 6, 1 retry)
  • Pages/SubDomainPagination.spec.ts › Verify subdomain count and pagination functionality (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@manerow manerow force-pushed the fix/notification-alert-sources-domain-dataproduct branch from 32b7957 to ceaa0a6 Compare April 24, 2026 11:33
@manerow manerow force-pushed the fix/notification-alert-sources-domain-dataproduct branch from ceaa0a6 to 9562df0 Compare April 25, 2026 10:19
@manerow manerow force-pushed the fix/notification-alert-sources-domain-dataproduct branch from 9562df0 to a2f5914 Compare April 27, 2026 06:29
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 27, 2026

Code Review ✅ Approved

Updates notification alert sources by adding Domain and Data Product fields while removing the deprecated Location field. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification Alert sources: 'Location' shown but deprecated; 'Domain' and 'Data Product' missing

2 participants