fix flaky contract semantic rules version#27704
Merged
shrabantipaul-collate merged 4 commits intomainfrom Apr 27, 2026
Merged
Conversation
Contributor
chirag-madlani
approved these changes
Apr 24, 2026
Contributor
🟡 Playwright Results — all passed (17 flaky)✅ 3956 passed · ❌ 0 failed · 🟡 17 flaky · ⏭️ 86 skipped
🟡 17 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedPins the contract semantic rules version to prevent test flakiness caused by upstream changes. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
shrabantipaul-collate
added a commit
that referenced
this pull request
Apr 27, 2026
Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes:
Fix flaky entity version semantic rule tests in AUT
Issue
Fix
Replaced the domain-assignment-based version bump approach with extreme threshold values: 99.9 to always satisfy the pass condition and 0.01 to always satisfy the fail condition.
Any realistic entity version falls between these bounds, making the tests deterministic regardless of background version changes in CI.
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>