Skip to content

fix flaky contract semantic rules version #27704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shrabantipaul-collate merged 4 commits into from
Apr 27, 2026
Merged

fix flaky contract semantic rules version #27704

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb17d9a
fix flaky contract semantic rules version
Apr 24, 2026
f378d2e
Merge branch 'main' into fix-contract-semantics-rule-version-specs
shrabantipaul-collate Apr 24, 2026
2941fe8
Merge branch 'main' into fix-contract-semantics-rule-version-specs
shrabantipaul-collate Apr 24, 2026
28c1b45
Merge branch 'main' into fix-contract-semantics-rule-version-specs
shrabantipaul-collate Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 58 additions & 100 deletions ...metadata-ui/src/main/resources/ui/playwright/e2e/Pages/DataContractsSemanticRules.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1503,6 +1503,8 @@ test.describe('Data Contracts Semantics Rule Domain', () => {
});
});

// Version comparison tests use extreme thresholds (0.01 / 99.9) so results are
// deterministic regardless of how many background version bumps CI introduces.
test.describe('Data Contracts Semantics Rule Version', () => {
test('Validate Entity Version Is', async ({ page, browser }) => {
test.slow();
Expand Down Expand Up @@ -1748,15 +1750,7 @@ test.describe('Data Contracts Semantics Rule Version', () => {

const { apiContext, afterAction } = await performAdminLogin(browser);
const table = new TableClass();
const domain = new Domain();
await table.create(apiContext);
await domain.create(apiContext);
// Only domain assign bumps the entity version (+0.1); contract save does not.
// threshold = initialVersion + 0.1: entity < threshold passes before domain assign, fails after.
const initialVersion = table.entityResponseData?.version ?? 0.1;
const versionThreshold = Number.parseFloat(
(initialVersion + 0.1).toFixed(2)
).toString();
await afterAction();

await test.step('Open contract section and start adding contract', async () => {
Expand Down Expand Up @@ -1787,11 +1781,12 @@ test.describe('Data Contracts Semantics Rule Version', () => {
DATA_CONTRACT_SEMANTIC_OPERATIONS.less
);

// Use 99.9 — any realistic entity version is always below this, so the
// check passes regardless of how many version bumps CI introduces.
await ruleLocator
.locator('.rule--value .rule--widget--NUMBER .ant-input-number-input')
.fill(versionThreshold);
.fill('99.9');

// save and trigger contract validation
await saveAndTriggerDataContractValidation(page, true);

await expect(
Expand All @@ -1803,23 +1798,19 @@ test.describe('Data Contracts Semantics Rule Version', () => {
});

await test.step('Contract with < condition for version should failed', async () => {
await assignSingleSelectDomain(page, domain.responseData);

await page.getByTestId('manage-contract-actions').click();

await page
.getByTestId('contract-run-now-button')
.waitFor({ state: 'visible' });

const runNowResponse = page.waitForResponse(
'/api/v1/dataContracts/*/validate'
);
await page.getByTestId('contract-run-now-button').click();
await runNowResponse;
// Lower the threshold to 0.01 — any realistic entity version always
// exceeds this, making the < check fail regardless of version bumps.
await clickEditContractButton(page);
await page.getByRole('tab', { name: 'Semantics' }).click();

await page.reload();
const versionInput = page
.locator('.group')
.first()
.locator('.rule--value .rule--widget--NUMBER .ant-input-number-input');
await versionInput.clear();
await versionInput.fill('0.01');

await waitForAllLoadersToDisappear(page);
await saveAndTriggerDataContractValidation(page);

await expect(
page.getByTestId('contract-status-card-item-semantics-status')
Expand All @@ -1836,15 +1827,7 @@ test.describe('Data Contracts Semantics Rule Version', () => {

const { apiContext, afterAction } = await performAdminLogin(browser);
const table = new TableClass();
const domain = new Domain();
await table.create(apiContext);
await domain.create(apiContext);
// Only domain assign bumps the entity version (+0.1); contract save does not.
// threshold = initialVersion: entity > threshold fails before domain assign, passes after.
const initialVersion = table.entityResponseData?.version ?? 0.1;
const versionThreshold = Number.parseFloat(
initialVersion.toFixed(2)
).toString();
await afterAction();

await test.step('Open contract section and start adding contract', async () => {
Expand Down Expand Up @@ -1875,11 +1858,12 @@ test.describe('Data Contracts Semantics Rule Version', () => {
DATA_CONTRACT_SEMANTIC_OPERATIONS.greater
);

// Use 99.9 — any realistic entity version is always below this, so
// entity_version > 99.9 always fails regardless of version bumps in CI.
await ruleLocator
.locator('.rule--value .rule--widget--NUMBER .ant-input-number-input')
.fill(versionThreshold);
.fill('99.9');

// save and trigger contract validation
await saveAndTriggerDataContractValidation(page, true);

await expect(
Expand All @@ -1892,23 +1876,19 @@ test.describe('Data Contracts Semantics Rule Version', () => {
});

await test.step('Contract with > condition for version should passed', async () => {
await assignSingleSelectDomain(page, domain.responseData);

await page.getByTestId('manage-contract-actions').click();

await page
.getByTestId('contract-run-now-button')
.waitFor({ state: 'visible' });

const runNowResponse = page.waitForResponse(
'/api/v1/dataContracts/*/validate'
);
await page.getByTestId('contract-run-now-button').click();
await runNowResponse;
// Lower the threshold to 0.01 — any realistic entity version always
// exceeds this, making the > check pass regardless of version bumps.
await clickEditContractButton(page);
await page.getByRole('tab', { name: 'Semantics' }).click();

await page.reload();
const versionInput = page
.locator('.group')
.first()
.locator('.rule--value .rule--widget--NUMBER .ant-input-number-input');
await versionInput.clear();
await versionInput.fill('0.01');

await waitForAllLoadersToDisappear(page);
await saveAndTriggerDataContractValidation(page);

await expect(
page.getByTestId('contract-status-card-item-semantics-status')
Expand All @@ -1927,15 +1907,7 @@ test.describe('Data Contracts Semantics Rule Version', () => {

const { apiContext, afterAction } = await performAdminLogin(browser);
const table = new TableClass();
const domain = new Domain();
await table.create(apiContext);
await domain.create(apiContext);
// Only domain assign bumps the entity version (+0.1); contract save does not.
// threshold = initialVersion: entity <= threshold passes before domain assign, fails after.
const initialVersion = table.entityResponseData?.version ?? 0.1;
const versionThreshold = Number.parseFloat(
initialVersion.toFixed(2)
).toString();
await afterAction();

await test.step('Open contract section and start adding contract', async () => {
Expand Down Expand Up @@ -1966,11 +1938,12 @@ test.describe('Data Contracts Semantics Rule Version', () => {
DATA_CONTRACT_SEMANTIC_OPERATIONS.less_equal
);

// Use 99.9 — any realistic entity version is always below this, so
// entity_version <= 99.9 always passes regardless of version bumps in CI.
await ruleLocator
.locator('.rule--value .rule--widget--NUMBER .ant-input-number-input')
.fill(versionThreshold);
.fill('99.9');

// save and trigger contract validation
await saveAndTriggerDataContractValidation(page, true);

await expect(
Expand All @@ -1982,23 +1955,19 @@ test.describe('Data Contracts Semantics Rule Version', () => {
});

await test.step('Contract with <= condition for version should failed', async () => {
await assignSingleSelectDomain(page, domain.responseData);

await page.getByTestId('manage-contract-actions').click();

await page
.getByTestId('contract-run-now-button')
.waitFor({ state: 'visible' });

const runNowResponse = page.waitForResponse(
'/api/v1/dataContracts/*/validate'
);
await page.getByTestId('contract-run-now-button').click();
await runNowResponse;
// Lower the threshold to 0.01 — any realistic entity version always
// exceeds this, making the <= check fail regardless of version bumps.
await clickEditContractButton(page);
await page.getByRole('tab', { name: 'Semantics' }).click();

await page.reload();
const versionInput = page
.locator('.group')
.first()
.locator('.rule--value .rule--widget--NUMBER .ant-input-number-input');
await versionInput.clear();
await versionInput.fill('0.01');

await waitForAllLoadersToDisappear(page);
await saveAndTriggerDataContractValidation(page);

await expect(
page.getByTestId('contract-status-card-item-semantics-status')
Expand All @@ -2018,15 +1987,7 @@ test.describe('Data Contracts Semantics Rule Version', () => {

const { apiContext, afterAction } = await performAdminLogin(browser);
const table = new TableClass();
const domain = new Domain();
await table.create(apiContext);
await domain.create(apiContext);
// Only domain assign bumps the entity version (+0.1); contract save does not.
// threshold = initialVersion + 0.1: entity >= threshold fails before domain assign, passes after (equal satisfies >=).
const initialVersion = table.entityResponseData?.version ?? 0.1;
const versionThreshold = Number.parseFloat(
(initialVersion + 0.1).toFixed(2)
).toString();
await afterAction();

await test.step('Open contract section and start adding contract', async () => {
Expand Down Expand Up @@ -2057,11 +2018,12 @@ test.describe('Data Contracts Semantics Rule Version', () => {
DATA_CONTRACT_SEMANTIC_OPERATIONS.greater_equal
);

// Use 99.9 — any realistic entity version is always below this, so
// entity_version >= 99.9 always fails regardless of version bumps in CI.
await ruleLocator
.locator('.rule--value .rule--widget--NUMBER .ant-input-number-input')
.fill(versionThreshold);
.fill('99.9');

// save and trigger contract validation
await saveAndTriggerDataContractValidation(page, true);

await expect(
Expand All @@ -2073,23 +2035,19 @@ test.describe('Data Contracts Semantics Rule Version', () => {
});

await test.step('Contract with >= condition for version should passed', async () => {
await assignSingleSelectDomain(page, domain.responseData);

await page.getByTestId('manage-contract-actions').click();

await page
.getByTestId('contract-run-now-button')
.waitFor({ state: 'visible' });

const runNowResponse = page.waitForResponse(
'/api/v1/dataContracts/*/validate'
);
await page.getByTestId('contract-run-now-button').click();
await runNowResponse;
// Lower the threshold to 0.01 — any realistic entity version always
// exceeds this, making the >= check pass regardless of version bumps.
await clickEditContractButton(page);
await page.getByRole('tab', { name: 'Semantics' }).click();

await page.reload();
const versionInput = page
.locator('.group')
.first()
.locator('.rule--value .rule--widget--NUMBER .ant-input-number-input');
await versionInput.clear();
await versionInput.fill('0.01');

await waitForAllLoadersToDisappear(page);
await saveAndTriggerDataContractValidation(page);

await expect(
page.getByTestId('contract-status-card-item-semantics-status')
Expand Down
Loading