Skip to content

Add relevent terms relation in term details page #27751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anuj-kumary merged 9 commits into from
Apr 27, 2026
Merged

Add relevent terms relation in term details page #27751

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d829fd6
Add relevent terms relation in term details page
anuj-kumary Apr 27, 2026
75aca4a
fix lint issue
anuj-kumary Apr 27, 2026
78c93b1
nit
anuj-kumary Apr 27, 2026
bf15cea
nit
anuj-kumary Apr 27, 2026
d92d3c8
Merge branch 'main' into issue-#27750
anuj-kumary Apr 27, 2026
921930e
nit
anuj-kumary Apr 27, 2026
a928722
Merge branch 'issue-#27750' of github.com:open-metadata/OpenMetadata …
anuj-kumary Apr 27, 2026
bdae956
fix lint issue
anuj-kumary Apr 27, 2026
11a5f0c
Refactor ontology test
anuj-kumary Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 68 additions & 55 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/OntologyExplorer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,19 +93,6 @@ async function clickFirstGraphNode(page: Page): Promise<void> {
await page.mouse.click(firstPos.x, firstPos.y);
}

async function readSearchHighlightIds(page: Page): Promise<string[]> {
return page.locator('.ontology-g6-container').evaluate((el: HTMLElement) => {
const raw = el.dataset.searchHighlightIds;
if (!raw) {
return [];
}
try {
return JSON.parse(raw) as string[];
} catch {
return [];
}
});
}

async function createApiContext(browser: Browser) {
const page = await browser.newPage({
Expand Down Expand Up @@ -893,67 +880,77 @@ test.describe('Ontology Explorer', () => {
});
});

test.describe('Search Graph Overlay', () => {
test('should show overlay when search query is entered', async ({
test.describe('Search Filtering', () => {
test('should show only the matching node and its neighbours when a search query is entered', async ({
page,
}) => {
await waitForGraphLoaded(page);
await applyGlossaryFilter(page, glossary.responseData.id);
await waitForGraphLoaded(page);

const searchInput = page
.getByTestId('ontology-graph-search')
.locator('input');
await searchInput.fill(term1.data.name);
await expect(page.getByTestId('ontology-search-overlay')).toBeVisible();

const positions = await readNodePositions(page);
expect(
positions,
'term1 must be visible — it matches the search query'
).toHaveProperty(term1.responseData.id);
expect(
positions,
'term2 must be visible — it is a direct neighbour of term1'
).toHaveProperty(term2.responseData.id);
});

test('should hide overlay when search query is cleared', async ({
test('should restore all nodes when the search query is cleared', async ({
page,
}) => {
await waitForGraphLoaded(page);
await applyGlossaryFilter(page, glossary.responseData.id);
await waitForGraphLoaded(page);

const searchInput = page
.getByTestId('ontology-graph-search')
.locator('input');
await searchInput.fill(term1.data.name);
await expect(page.getByTestId('ontology-search-overlay')).toBeVisible();
const filteredCount = Object.keys(await readNodePositions(page)).length;

await searchInput.clear();
await expect(
page.getByTestId('ontology-search-overlay')
).not.toBeVisible();
const restoredCount = Object.keys(await readNodePositions(page)).length;
expect(restoredCount).toBeGreaterThanOrEqual(filteredCount);
});

test('matched term node should remain rendered in the graph during search', async ({
test('should show empty graph state when the search matches nothing', async ({
page,
}) => {
await waitForGraphLoaded(page);
await applyGlossaryFilter(page, glossary.responseData.id);
await waitForGraphLoaded(page);

const searchInput = page
.getByTestId('ontology-graph-search')
.locator('input');
await searchInput.fill(term1.data.name);
await expect(page.getByTestId('ontology-search-overlay')).toBeVisible();

const positions = await readNodePositions(page);
await searchInput.fill('__nonexistent_term_xyz__');

expect(
positions,
'term1 node must still be present in node positions while its name is the active search query'
).toHaveProperty(term1.responseData.id);
await expect(page.getByTestId('ontology-graph-empty')).toBeVisible();
await expect(
page.locator('.ontology-g6-container canvas').first()
).toBeVisible();
});

test('should keep overlay visible and not crash when search term matches nothing', async ({
test('should recover from a no-match state when the search is cleared', async ({
page,
}) => {
await waitForGraphLoaded(page);
const searchInput = page
.getByTestId('ontology-graph-search')
.locator('input');
await searchInput.fill('__nonexistent_term_xyz__');
await expect(page.getByTestId('ontology-graph-empty')).toBeVisible();

await expect(page.getByTestId('ontology-search-overlay')).toBeVisible();
await searchInput.clear();
await expect(
page.locator('.ontology-g6-container canvas').first()
).toBeVisible();
page.getByTestId('ontology-graph-empty')
).not.toBeVisible();
});
});

Expand Down Expand Up @@ -1447,7 +1444,7 @@ test.describe('Ontology Explorer - Cross Glossary Edges', () => {
});
});

test.describe('Ontology Explorer - Search Highlight Node-Level Effect', () => {
test.describe('Ontology Explorer - Search Filtering - Node Visibility', () => {
const highlightGlossary = new Glossary();
const termAlpha = new GlossaryTerm(highlightGlossary);
const termBeta = new GlossaryTerm(highlightGlossary);
Expand Down Expand Up @@ -1479,7 +1476,7 @@ test.describe('Ontology Explorer - Search Highlight Node-Level Effect', () => {
await disposeApiContext(page, apiContext);
});

test('searching by a term name highlights that term and its connected neighbour', async ({
test('searching by a term name shows only that term and its connected neighbour', async ({
page,
}) => {
await navigateAndFilterByGlossary(page, highlightGlossary.responseData.id);
Expand All @@ -1488,16 +1485,24 @@ test.describe('Ontology Explorer - Search Highlight Node-Level Effect', () => {
.getByTestId('ontology-graph-search')
.locator('input');
await searchInput.fill(termAlpha.data.name);
await expect(page.getByTestId('ontology-search-overlay')).toBeVisible();

const highlighted = await readSearchHighlightIds(page);
const positions = await readNodePositions(page);

expect(highlighted).toContain(termAlpha.responseData.id);
expect(highlighted).toContain(termBeta.responseData.id);
expect(highlighted).not.toContain(termGamma.responseData.id);
expect(
positions,
'termAlpha must be visible — it matches the search query'
).toHaveProperty(termAlpha.responseData.id);
expect(
positions,
'termBeta must be visible — it is directly connected to termAlpha'
).toHaveProperty(termBeta.responseData.id);
expect(
positions,
'termGamma must be hidden — it is unrelated to the search query'
).not.toHaveProperty(termGamma.responseData.id);
});

test('searching by the isolated term highlights only that term', async ({
test('searching by the isolated term shows only that term', async ({
page,
}) => {
await navigateAndFilterByGlossary(page, highlightGlossary.responseData.id);
Expand All @@ -1506,16 +1511,24 @@ test.describe('Ontology Explorer - Search Highlight Node-Level Effect', () => {
.getByTestId('ontology-graph-search')
.locator('input');
await searchInput.fill(termGamma.data.name);
await expect(page.getByTestId('ontology-search-overlay')).toBeVisible();

const highlighted = await readSearchHighlightIds(page);
const positions = await readNodePositions(page);

expect(highlighted).toContain(termGamma.responseData.id);
expect(highlighted).not.toContain(termAlpha.responseData.id);
expect(highlighted).not.toContain(termBeta.responseData.id);
expect(
positions,
'termGamma must be visible — it matches the search query'
).toHaveProperty(termGamma.responseData.id);
expect(
positions,
'termAlpha must be hidden — it does not match and has no edge to termGamma'
).not.toHaveProperty(termAlpha.responseData.id);
expect(
positions,
'termBeta must be hidden — it does not match and has no edge to termGamma'
).not.toHaveProperty(termBeta.responseData.id);
});

test('clearing the search removes all highlight state from the DOM', async ({
test('clearing the search restores all three terms to the graph', async ({
page,
}) => {
await navigateAndFilterByGlossary(page, highlightGlossary.responseData.id);
Expand All @@ -1524,13 +1537,13 @@ test.describe('Ontology Explorer - Search Highlight Node-Level Effect', () => {
.getByTestId('ontology-graph-search')
.locator('input');
await searchInput.fill(termAlpha.data.name);
await expect(page.getByTestId('ontology-search-overlay')).toBeVisible();

await searchInput.clear();
await expect(page.getByTestId('ontology-search-overlay')).not.toBeVisible();

const highlighted = await readSearchHighlightIds(page);
expect(highlighted).toHaveLength(0);
const positions = await readNodePositions(page);
expect(positions).toHaveProperty(termAlpha.responseData.id);
expect(positions).toHaveProperty(termBeta.responseData.id);
expect(positions).toHaveProperty(termGamma.responseData.id);
});
});

Expand Down
15 changes: 2 additions & 13 deletions openmetadata-ui/src/main/resources/ui/src/components/OntologyExplorer/OntologyExplorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ const ONTOLOGY_TOOLBAR_CARD_CLASS =
const ONTOLOGY_ENTITY_SUMMARY_SLIDEOUT_WIDTH = 576;

interface GraphEmptyStateProps {
message: string;
testId: string;
readonly message: string;
readonly testId: string;
}

function GraphEmptyState({ message, testId }: GraphEmptyStateProps) {
Expand Down Expand Up @@ -104,7 +104,6 @@ const OntologyExplorer: React.FC<OntologyExplorerProps> = ({
filteredGraphData,
hierarchyGraphData,
hierarchyBakedPositions,
graphSearchHighlight,
glossaryColorMap,
isHierarchyView,
exportableGlossaryId,
Expand Down Expand Up @@ -223,14 +222,6 @@ const OntologyExplorer: React.FC<OntologyExplorerProps> = ({
}

return (
<>
{filters.searchQuery.trim() ? (
<div
aria-hidden
className="tw:pointer-events-none tw:absolute tw:inset-0 tw:z-1 tw:bg-gray-950/6"
data-testid="ontology-search-overlay"
/>
) : null}
<div className="tw:relative tw:z-1 tw:h-full tw:w-full tw:min-h-0">
<OntologyGraph
edges={graphDataToShow.edges}
Expand All @@ -245,7 +236,6 @@ const OntologyExplorer: React.FC<OntologyExplorerProps> = ({
}
glossaries={glossaries}
glossaryColorMap={glossaryColorMap}
graphSearchHighlight={graphSearchHighlight}
hierarchyCombos={
isHierarchyView && hierarchyGraphData
? hierarchyGraphData.combos.map((c) => ({
Expand Down Expand Up @@ -287,7 +277,6 @@ const OntologyExplorer: React.FC<OntologyExplorerProps> = ({
</>
)}
</div>
</>
);
};

Expand Down
3 changes: 3 additions & 0 deletions ...ata-ui/src/main/resources/ui/src/components/OntologyExplorer/hooks/useOntologyExplorer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ export function useOntologyExplorer({
relationTypes,
settings,
scope,
entityId,
glossaryId,
termGlossaryId,
dataSource,
Expand Down Expand Up @@ -1192,6 +1193,7 @@ export function useOntologyExplorer({
const nextFilters: GraphFilters = {
...filters,
viewMode: 'overview' satisfies GraphViewMode,
showCrossGlossaryOnly: false,
};
if (graphData) {
dataModeInitialLoadUsesSpinnerRef.current = true;
Expand All @@ -1207,6 +1209,7 @@ export function useOntologyExplorer({
setFilters({
...filters,
viewMode: modelFiltersRef.current.viewMode,
showCrossGlossaryOnly: modelFiltersRef.current.showCrossGlossaryOnly,
});
setTermAssetCounts({});
}
Expand Down
Loading
Loading