-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(security): bump vulnerable transitive deps across service modules #27753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e33cf0b
8b305de
4219632
d39f484
f3955e1
75d3fad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ | |
| <!-- Kubernetes client version (should match openmetadata-service) --> | ||
| <kubernetes-client.version>21.0.1</kubernetes-client.version> | ||
| <!-- Jackson version (should match parent project) --> | ||
| <jackson.version>2.17.2</jackson.version> | ||
| <jackson.version>2.21.2</jackson.version> | ||
| </properties> | ||
|
Comment on lines
23
to
27
|
||
|
|
||
| <dependencies> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Quality: k8s-operator jackson.version property redundant with parent BOM
The parent pom now imports
jackson-bomin<dependencyManagement>, which governs versions for allcom.fasterxml.jackson.*artifacts across child modules. However,openmetadata-k8s-operator/pom.xmlstill declares a local<jackson.version>property (line 26) and hardcodes<version>${jackson.version}</version>on itsjackson-databindandjackson-dataformat-yamldependencies (lines 48, 54). This creates a maintenance burden: the comment says "should match parent project" but requires manual sync. If someone bumps only the parent BOM, the k8s-operator will silently stay on the old version.Consider removing the local
jackson.versionproperty and the explicit<version>tags on the Jackson dependencies — the parent's BOM import will resolve the correct versions automatically.Suggested fix:
Was this helpful? React with 👍 / 👎 | Reply
gitar fixto apply this suggestion