Reduce max concurrent embedding requests to 5#27845
Open
mohityadav766 wants to merge 1 commit intomainfrom
Open
Reduce max concurrent embedding requests to 5#27845mohityadav766 wants to merge 1 commit intomainfrom
mohityadav766 wants to merge 1 commit intomainfrom
Conversation
Code Review ✅ ApprovedReduces the maximum concurrent embedding requests to five to improve stability. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the default Elasticsearch natural language search embedding throttling to reduce parallel calls to the configured embedding provider, helping avoid provider-side rate limits / HTTP2 connection pressure.
Changes:
- Reduced the default
maxConcurrentEmbeddingRequestsfrom 10 to 5 (still overrideable viaMAX_CONCURRENT_EMBEDDING_REQUESTS).
| semanticSearchEnabled: ${SEMANTIC_SEARCH_ENABLED:-false} | ||
| embeddingProvider: ${EMBEDDING_PROVIDER:-bedrock} # Options: "openai", "bedrock", "djl" | ||
| maxConcurrentEmbeddingRequests: ${MAX_CONCURRENT_EMBEDDING_REQUESTS:-10} | ||
| maxConcurrentEmbeddingRequests: ${MAX_CONCURRENT_EMBEDDING_REQUESTS:-5} |
Contributor
🟡 Playwright Results — all passed (11 flaky)✅ 3987 passed · ❌ 0 failed · 🟡 11 flaky · ⏭️ 86 skipped
🟡 11 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
maxConcurrentEmbeddingRequestsfrom10to5inconf/openmetadata.yaml.This will update automatically on new commits.